Add method normalizeWebsiteOfUrl to format the website of url to lower case#537
Merged
MariaHCD merged 6 commits intoMay 17, 2023
Merged
Conversation
6 tasks
Gonals
previously approved these changes
May 16, 2023
Contributor
|
Looks good, but there are some conflicts! |
Contributor
|
@fedirjh Could you review this as well? |
Contributor
|
Reviewing shortly. @eh2077 could you please include App screenshots testing ? |
eh2077
force-pushed
the
18415-parse-website-to-case-insensitive
branch
from
8aa27e2 to
fc9b7bc
Compare
Contributor
Author
fedirjh
reviewed
May 16, 2023
fedirjh
left a comment
fedirjh
left a comment
Contributor
There was a problem hiding this comment.
Looks good , left few comments
Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
Co-authored-by: Fedi Rajhi <fedirjh@gmail.com>
fedirjh
previously approved these changes
May 16, 2023
Gonals
previously approved these changes
May 17, 2023
Contributor
Author
|
@MariaHCD Friendly bump! Would you like to have a look at this PR? Thank you! |
MariaHCD
reviewed
May 17, 2023
MariaHCD
left a comment
MariaHCD
left a comment
Contributor
There was a problem hiding this comment.
LGTM! One minor comment and I'm just going to quickly test this on OldDot to ensure nothing breaks there.
MariaHCD
reviewed
May 17, 2023
MariaHCD
left a comment
MariaHCD
left a comment
Contributor
There was a problem hiding this comment.
Did some testing on OldDot, looks good!
Co-authored-by: Maria D'Costa <mariahcdcosta@gmail.com>
MariaHCD
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new method normalizeWebsiteOfUrl in str.js to format the website of url to lower case. The new method is used in both
linkandautolinkrule replacement to format thehrefproperty of an anchor tag. It can also be used in the App codebase when handling edited link.Fixed Issues
$ Expensify/App#18514
Tests
google.comof the url is in lower case in the initial draft, likeand save the comment
4. Verify that the link is unchanged.
Screen.Recording.2023-05-16.at.9.46.32.PM.mov
QA
N/A