Skip to content

Add Str method to check for valid URL#354

Merged
jasperhuangg merged 2 commits into
masterfrom
maria-add-url-validation
Mar 22, 2021
Merged

Add Str method to check for valid URL#354
jasperhuangg merged 2 commits into
masterfrom
maria-add-url-validation

Conversation

@MariaHCD

Copy link
Copy Markdown
Contributor

Added a method to Str.js to check for valid URLs

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/156558

Tests

Automated tests. Will also be tested with the Web-Secure version bump PR

QA

No QA

@MariaHCD MariaHCD requested a review from a team March 19, 2021 07:10
@MariaHCD MariaHCD self-assigned this Mar 19, 2021
@github-actions

github-actions Bot commented Mar 19, 2021

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@botify botify requested review from jasperhuangg and removed request for a team March 19, 2021 07:10
@MariaHCD

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@MariaHCD MariaHCD requested a review from a team as a code owner March 19, 2021 07:13
@botify botify removed the request for review from a team March 19, 2021 07:13

@jasperhuangg jasperhuangg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasperhuangg jasperhuangg merged commit b89c2c5 into master Mar 22, 2021
@jasperhuangg jasperhuangg deleted the maria-add-url-validation branch March 22, 2021 02:42
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants