Skip to content

[NO QA] Add new constant for pending card icon#164

Merged
johnmlee101 merged 1 commit into
masterfrom
stites-addConst
Aug 2, 2019
Merged

[NO QA] Add new constant for pending card icon#164
johnmlee101 merged 1 commit into
masterfrom
stites-addConst

Conversation

@stitesExpensify

Copy link
Copy Markdown
Contributor

@johnmlee101 will you please review this?

We need this const to update the getIcon function here https://github.com/Expensify/Web-Expensify/pull/25432/files#diff-2e17bbc74c6736a97b56af3caa15aba3R2350

Fixed Issues

$ Expensify/Expensify#108240

Tests

  1. Pull this and pull https://github.com/Expensify/Web-Expensify/pull/25432/files
  2. Make sure a pending transactions have the icon on the reports page
    2019-08-02_12-42-53

QA

N/A

@stitesExpensify stitesExpensify self-assigned this Aug 2, 2019

@johnmlee101 johnmlee101 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants