[No QA] Revert billing docs PR to fix main lint failure#95785
Conversation
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
melvin-bot
Bot
requested review from
VictoriaExpensify and
deetergp
and removed request for
a team
|
@deetergp @VictoriaExpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 645ae56fb7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| </ul> | ||
| {% else %} | ||
| <a href="/{{ activePlatform }}/hubs/{{ hub.href }}/{{ item.href }}" class="icon-with-link link"> | ||
| <a href="{{ item.href }}" class="icon-with-link link"> |
There was a problem hiding this comment.
On nested hub pages such as /new-expensify/hubs/connections/netsuite/Troubleshooting.html, this relative href makes inactive sibling sections resolve under the current nested directory (for example quickbooks-online becomes /new-expensify/hubs/connections/netsuite/quickbooks-online), but the generated page is /new-expensify/hubs/connections/quickbooks-online.html. This breaks LHN navigation between sibling sections whenever the user is viewing a nested section page, so keep the full /{{ activePlatform }}/hubs/{{ hub.href }}/{{ item.href }} path here.
Useful? React with 👍 / 👎.
|
|
||
| ## How to transfer billing ownership in Expensify | ||
|
|
||
| To transfer billing responsibility to another **Workspace Admin**, ask that member to [follow these steps to transfer billing ownership](LINK). |
There was a problem hiding this comment.
This public help article now ships a Markdown link to the literal target LINK, which will render as a broken relative URL instead of sending Workspace Admins to the transfer-billing-ownership instructions. Since the same article later references the Billing Overview anchor for this flow, this should point at the real destination before the reverted docs are republished.
Useful? React with 👍 / 👎.
|
@VictoriaExpensify looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/VictoriaExpensify in version: 9.4.33-0 🚀
|
3 participants
Summary
helpsite-billing-articles), which introduced unsafe type assertions in.github/scripts/createDocsRoutes.tsand broke thelint / ESLint checkjob onmain.mainCI to green while the billing docs work is re-landed in a follow-up PR with lint-safe YAML parsing helpers.Test plan
lint / ESLint checkpasses on this PRnpm run createDocsRoutesstill runs successfullyMade with Cursor