Skip to content

fix: cap tab navigation span duration to drop idle-inflated telemetry#95781

Draft
BartekObudzinski wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:fix/tab-navigation-span-max-duration
Draft

fix: cap tab navigation span duration to drop idle-inflated telemetry#95781
BartekObudzinski wants to merge 1 commit into
Expensify:mainfrom
callstack-internal:fix/tab-navigation-span-max-duration

Conversation

@BartekObudzinski

@BartekObudzinski BartekObudzinski commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

The five slowest ManualNavigateToInboxTab spans in production over the last 14 days are 2.0h, 50.7min, 45.1min, 32.6min and 18.1min (releases 9.4.21-9 through 9.4.28-2, across Windows, macOS and iOS). None of them measure a navigation: their traces show zero JS, network or interaction activity for the entire span window, and each span ends at the moment the client resumes. The clearest example is an 18-minute span whose end shares a timestamp with an 89ms ManualOpenReport span, so the client and API were fast the moment the user actually interacted. In the last 14 days, 188 production ManualNavigateToInboxTab spans exceeded 60s while the real p99 is ~1.5s.

Span durations are wall-clock. A machine sleep, frozen browser tab, or suspended mobile app between the tab click (span start in InboxTabButton) and the end signal (useInboxTabSpanLifecycle onLayout/focus, or a cancel) inflates the duration to the length of the idle gap. #95480 already drops the spans that exit through cancelSpan (canceled: true), but a stale span that ends through the regular endSpan path after the app wakes up (sidebar layout or focus firing on resume) is not canceled and still ships with the idle gap as its duration.

The fix extends maxDurationFilter, which previously only applied to SubmitToDestinationVisible with a 60s cap, to also cover the tab-navigation ops (TAB_NAVIGATION_SPAN_IDS). It now filters both root transactions and adopted child spans, mirroring the structure of canceledTabNavigationFilter. The 60s cap is 40x the tab-navigation p99, so no legitimate navigation measurement is dropped. This is a telemetry send-time filter only, with no change to app behavior.

Note for metric consumers: ManualNavigateToInboxTab and ManualNavigateToReports* max/p99.9 will drop definitionally once this deploys, because multi-minute idle artifacts stop shipping.

Fixed Issues

$
PROPOSAL:

Tests

  1. Run npx jest tests/unit/maxDurationFilterTest.ts and verify all tests pass. The over-cap paths (root transaction and child span) can only be produced synthetically, so they are covered there.
  2. Open the web app with the DevTools console and Network tab open.
  3. Navigate to the Reports tab, then click the Inbox tab. Verify a console line [Sentry][ManualNavigateToInboxTab] Ending span appears and the ManualNavigateToInboxTab transaction is still present in the Sentry envelope requests (normal sub-cap spans are unaffected).
  4. Click the Reports tab and verify the ManualNavigateToReports* spans are likewise still sent.
  5. Verify Inbox and Reports tab navigation still works normally on narrow and wide layouts.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant