Pass unavailableTranslation param - batch 1 by cretadn22 · Pull Request #95758 · Expensify/App

cretadn22 · 2026-07-09T20:19:50Z

Explanation of Change

Fixed Issues

$ #66392
PROPOSAL: #66392

Tests

Go to Report pages
Verify title column displays in the correct format and sort function works well
Back to LHN
Open any archived expense report
Verify the report name and title display correctly

Verify that no errors appear in the JS console

Offline tests

Go to Report pages
Verify title column displays in the correct format and sort function works well
Back to LHN
Open any archived expense report
Verify the report name and title display correctly

QA Steps

Go to Report pages
Verify title column displays in the correct format and sort function works well
Back to LHN
Open any archived expense report
Verify the report name and title display correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-13.at.22.48.10.mov

…ude an unavailable translation fallback.

melvin-bot · 2026-07-09T20:19:56Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-09T20:25:25Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/OptionsListUtils/index.ts	`86.09% <ø> (ø)`
src/libs/ReportNameUtils.ts	`81.96% <100.00%> (+0.70%)`	⬆️
src/libs/SearchUIUtils.ts	`63.11% <50.00%> (+0.23%)`	⬆️
... and 222 files with indirect coverage changes

…le translation fallback for policy names

shubham1206agra · 2026-07-12T16:56:35Z

@cretadn22 Please update your test case.

shubham1206agra · 2026-07-12T16:58:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-07-12.at.10.26.44.PM.mov

cretadn22 · 2026-07-13T15:51:22Z

@shubham1206agra I've updated the test steps in the PR description as requested. Could you please check again?

github-actions · 2026-07-13T16:58:32Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-13T17:04:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95758.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-6ff48c7b37c-3fececf-6ff2b185419724121f2ce8c86f3cf57f121f1305/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-6ff48c7-3fececf-75f424ee4d07b22001244ade8cf51b4a1d308e32/index.html

Web 🕸️
https://95758.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Remove an erroneous empty-string argument that shifted getSortedSections parameters and broke the typecheck on main. Co-authored-by: Cursor <cursoragent@cursor.com>

OSBotify · 2026-07-14T11:38:03Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.34-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-14T11:40:15Z

No help site changes required

I reviewed the changes in this PR and no updates to the help site files under docs/articles are needed.

Why: This is a purely internal refactor — part of the effort to deprecate Onyx.connect(). The change threads an unavailableTranslation parameter into getPolicyName() in three utility files (OptionsListUtils/index.ts, ReportNameUtils.ts, SearchUIUtils.ts) so the "Workspace unavailable" fallback label is resolved through the passed-in translate function instead of relying on an implicit Onyx dependency. The remaining changes are unit tests.

There is no change to user-facing behavior, UI labels, feature names, or flows — the fallback string and the report/policy naming behavior are functionally identical to before. HelpDot articles document product behavior for end users, and nothing here alters what a user sees or does. So there is nothing to add, remove, or correct on the help site.

Since no docs change is required, I have not created a draft PR.

⚠️ Note: I could not verify this in a live browser (web prep failed in this run, so NewDot could not be driven). This conclusion is based on static analysis of the diff, the linked issue, and the affected code paths.

@cretadn22, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-07-16T05:14:41Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

OSBotify · 2026-07-16T06:05:34Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.34-14 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Updated getInvoicesChatName and getInvoicePayerName functions to incl…

c20a568

…ude an unavailable translation fallback.

cretadn22 requested review from a team as code owners July 9, 2026 20:19

melvin-bot Bot assigned cretadn22 Jul 9, 2026

melvin-bot Bot requested review from heyjennahay and shubham1206agra and removed request for a team and heyjennahay July 9, 2026 20:19

melvin-bot Bot removed the request for review from a team July 9, 2026 20:19

getSortedTransactionData and getSortedReportData to include unavailab…

1e659a0

…le translation fallback for policy names

shubham1206agra approved these changes Jul 13, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny July 13, 2026 15:56

mountiny approved these changes Jul 13, 2026

View reviewed changes

mountiny merged commit 6ff48c7 into Expensify:main Jul 13, 2026
36 checks passed

This was referenced Jul 13, 2026

[Due for payment 2026-07-23] Investigate workflow job failing on main: test / test (job 1) #95981

Closed

[Due for payment 2026-07-23] Investigate workflow job failing on main: typecheck / typecheck #95982

Closed

This was referenced Jul 13, 2026

Fix iOS freeze when picking a brand-new P2P recipient on the distance confirmation step #95771

Merged

Fix: physical-address error persists after selecting a valid address #94528

Merged

mountiny mentioned this pull request Jul 13, 2026

[NoQA] Fix typecheck failure in SearchUIUtilsTest from PR #95758 #95985

Merged

52 tasks

MelvinBot mentioned this pull request Jul 13, 2026

Pin initially-selected items to the top of long search filter lists #95986

Merged

53 tasks

OSBotify mentioned this pull request Jul 14, 2026

Deploy Checklist: New Expensify 2026-07-14 #96044

Closed

applause-bot Bot mentioned this pull request Jul 14, 2026

Spends - Sort function on column briefly show an empty report page #96074

Open

7 tasks

melvin-bot Bot mentioned this pull request Jul 16, 2026

Remove Onyx.connect() for the key: ONYXKEYS.ARE_TRANSLATIONS_LOADING in src/libs/PersonalDetailsUtils.ts #66392

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Pass unavailableTranslation param - batch 1#95758

Pass unavailableTranslation param - batch 1#95758
mountiny merged 2 commits into
Expensify:mainfrom
cretadn22:migrate-unavailableTranslation-batch-1

cretadn22 commented Jul 9, 2026 •

edited

Loading

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

codecov Bot commented Jul 9, 2026 •

edited by github-actions Bot

Loading

Uh oh!

shubham1206agra commented Jul 12, 2026

Uh oh!

shubham1206agra commented Jul 12, 2026

Uh oh!

cretadn22 commented Jul 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

MelvinBot commented Jul 14, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

cretadn22 commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 9, 2026

Uh oh!

codecov Bot commented Jul 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shubham1206agra commented Jul 12, 2026

Uh oh!

shubham1206agra commented Jul 12, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

cretadn22 commented Jul 13, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

OSBotify commented Jul 14, 2026

Uh oh!

MelvinBot commented Jul 14, 2026

No help site changes required

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

OSBotify commented Jul 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cretadn22 commented Jul 9, 2026 •

edited

Loading

codecov Bot commented Jul 9, 2026 •

edited by github-actions Bot

Loading