[Payment due @Krishna2323] Add tooltip to company card table#95744
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-07-10.00-36-29.mp4 |
|
@JS00001 LGTM for Company Cards. A few other tables still need the same treatment:
Happy to handle these in a follow-up if you want. Most of them were missed in my PRs. 🥲 |
|
@Krishna2323 that'd be great, could you do a follow up for that please? |
|
🎯 @Krishna2323, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
@Krishna2323 can you create an issue for it and assign it to you? |
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.4.33-0 🚀
|
|
🤖 I reviewed the changes in this PR against the help site files under No help site (HelpDot) changes are required. This PR is a UI-only enhancement: it swaps Expensify's help articles document how to use features (e.g., importing, assigning, and managing company cards), not per-element hover behavior like tooltips on truncated text. There is nothing in the existing company card articles that this change contradicts or that needs updating. Because no changes are required, I did not create a draft docs PR. @JS00001, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR (Note: no docs PR was created since no help site changes are needed — if you'd still like a documentation update to cover something specific here, let me know and I'll draft one.) |
|
Deploy Blocker #95862 was identified to be related to this PR. |
Explanation of Change
Adds tooltips to company card table
Fixed Issues
$ https://expensify.slack.com/archives/C07NMDKEFMH/p1783621262548049?thread_ts=1783347263.055509&cid=C07NMDKEFMH
Tests
Add the mock company card feed
Shrink your screen down until the name of the card overflows (ellipses)
Hover over the name
Ensure a tooltip is shown
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
Reviewer Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).Avatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-07-09.at.2.35.18.PM.mov