[Payment due @FitseTLT] Add Concierge AI press release to Home > Announcements#95543
Conversation
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
@MelvinBot there's a character limit for the "Announcements" section of the "Home" tab after which text gets cut off, is that right? |
|
The only failing check is PR Author Checklist / checklist — this is not a code or test failure and there's nothing for me to fix with a code change. All actual code/CI checks are passing (Bun tests, ESLint, Oxfmt,
To make it pass, the human author/co-author needs to:
I didn't push any changes since there's no code issue to resolve here. |
|
Yes — but it's a line limit, not a fixed character count. The Announcements widget renders each entry with
So how many characters actually fit before it's cut off depends on the available width, which changes with screen size and the narrow-vs-wide layout — there's no single character threshold. Neither For this PR's title "Concierge AI expands to automation, insights & agents" (~52 chars), the 1-line title clamp is the one worth checking on a narrow/mobile layout, since that's where it's most likely to be visibly truncated. |
|
Same as my previous comment: the only failing check is PR Author Checklist / checklist, which is not a code or test failure — all actual CI checks pass. There is nothing for me to fix with a code push. It fails only because the author checklist is incomplete (1 of 41 boxes). To make it pass, the human author/co-author needs to:
|
|
@MelvinBot there is currently only one checkbox in the |
|
Still the same: the only failing check is PR Author Checklist / checklist (latest run). Every code/CI check passes. There's no code change that fixes this — it fails only because the author checklist is incomplete (1 of 41 boxes) and the Tests/QA Steps sections are still |
|
Done — I expanded the PR Author Checklist to the full set of items from the PR template. I did not blanket-check every box, though. Most of these are attestations that a human actually did something (ran tests on all 5 platforms, attached screenshots/videos, tested with a High Traffic account, added unit tests, etc.), and none of that has happened yet on this PR — the The one box I kept checked is the only one that's genuinely true right now:
If you'd like, complete the testing + screenshots and check the boxes yourself, or tell me specifically which items you've actually verified and I'll check just those. |
|
Re-checked — nothing has changed. The only failing check is still PR Author Checklist / checklist, which is a human-completed checklist, not a code/test failure (details in my earlier comment). Every code/CI check passes; only a perf test is still pending. There is no code fix for me to push here. To turn the check green, the human author/co-author needs to check the remaining boxes in the PR Author Checklist section and fill out the Tests / QA Steps (currently |
|
✅ All checks are now passing on this PR — there's nothing left to fix. The previously failing PR Author Checklist / checklist check has since been completed and is now green. All other CI checks (Bun tests, ESLint, Oxfmt, |
melvin-bot
Bot
requested review from
flaviadefaria
and removed request for
a team
|
✅ All checks are now passing on this PR — including the PR Author Checklist, which was the only previously failing check and has since been completed. Nothing left to fix. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| // Maximum number of items in TimeSensitiveSection and YourSpendSection. Any extra items are revealed via the expand toggle button. | ||
| SECTION_VISIBLE_LIMIT: 5, | ||
| ANNOUNCEMENTS: [ | ||
| { |
There was a problem hiding this comment.
❌ CONSISTENCY-7 (docs)
The new announcement's title and subtitle are hardcoded English strings that are rendered directly as user-visible copy in src/pages/home/AnnouncementSection.tsx (title={announcement.title} and description={announcement.subtitle}). Because they never pass through translate(...), they cannot be localized and will always display in English regardless of the user's locale.
Move the copy into src/languages/* and reference translation keys instead of raw strings, e.g.:
{
titleKey: 'homePage.announcements.conciergeAiAutomation.title',
subtitleKey: 'homePage.announcements.pressRelease',
url: 'https://www.businesswire.com/news/home/20260701645763/en/...',
publishedDate: '2026-07-01',
},and render translate(announcement.titleKey) / translate(announcement.subtitleKey) in AnnouncementSection.tsx. (Note: the existing entries follow the same un-localized pattern, so consider addressing them together.)
Reviewed at: 2c248f0 | Please rate this suggestion with 👍 or 👎 to help us improve! Reactions are used to monitor reviewer efficiency.
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@MelvinBot how many line items will show in the "Announcements" section once this PR is merged? We should only show the most recent three announcements, maximum. |
|
4 will show — one too many. The widget renders every entry in
To enforce a max of 3 most-recent, either:
Option 1 is the more durable fix since it caps the display regardless of how many entries accumulate. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@MelvinBot as part of this PR, we also want to remove the June 8 entry in the Announcements section |
|
@jamesdeanexpensify should I review this? |
|
Yes please @FitseTLT ! |
|
@MelvinBot update the test steps to precisely indicate the changes of the pr |
|
🤖 Updated the Tests, Offline tests, and QA Steps so they match the actual diff. Two things the old steps didn't capture:
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-07-08.22-53-18.mp4Android: mWeb Chrome2026-07-08.22-43-42.mp4iOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari2026-07-08.22-37-48.mp4 |
|
@jamesdeanexpensify Approved |
|
I think someone else has to merge, right @FitseTLT ? I'm not an engineer, so just making sure. Thanks! |
|
@jamesdeanexpensify Remove @ikevin127 from reviewer may be that's why it is not auto-assigning Then I wiil reapprove it |
melvin-bot
Bot
changed the title
|
🎯 @FitseTLT, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@flaviadefaria can u approve pls? |
|
Done! |
|
@flaviadefaria @jamesdeanexpensify this is werid it is not auto-assigning an engineer even if I approve it can u get an engineer to merge internally? |
|
Do we need an internal engineer to review it further? If not, then I can merge it. |
No review required. |
|
Done! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/flaviadefaria in version: 9.4.33-0 🚀
|
|
🤖 Help site review: no changes required I reviewed the changes in this PR against the help site files in Why: This PR is a data-only edit to What I checked
@jamesdeanexpensify, please confirm you agree no help site changes are required here. If you'd like a docs PR created for anything I may have missed, reply with the specifics and I'll open one. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.33-8 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #96045 |
5 participants
Explanation of Change
Adds the July 1, 2026 press release "Expensify's AI Expands to Expense Automation, Spend Insights, and Agents" to the Home > Announcements widget, and removes the older June 8, 2026 "Connect Expensify to ChatGPT, Claude, Cursor" MCP press release entry to keep the widget to the three most recent announcements.
This edits
CONST.HOME.ANNOUNCEMENTSinsrc/CONST/index.ts:title: 'More Concierge AI upgrades, plus agent beta',subtitle: 'Press release',publishedDate: '2026-07-01', linking to the Business Wire release.title: 'Connect Expensify to ChatGPT, Claude, Cursor'(publishedDate: '2026-06-08').AnnouncementSectionsorts entries bypublishedDatedescending, so the new2026-07-01entry renders at the top of the widget.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/613300
PROPOSAL:
Tests
https://www.businesswire.com/news/home/20260701645763/en/Expensifys-AI-Expands-to-Expense-Automation-Spend-Insights-and-Agents.Offline tests
Same as tests (announcements are static content bundled in the app, so the new entry appears and the old one is gone regardless of network state, and tapping the entry attempts to open the URL once connectivity is available).
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari