Decompose ReportActionsList: 10 - restore useEffectEven by LukasMod · Pull Request #95478 · Expensify/App

LukasMod · 2026-07-07T09:06:55Z

Explanation of Change

Converted the two mark-as-read effects in src/hooks/useMarkAsRead.ts from plain useEffect (with eslint-disable react-hooks/exhaustive-deps) to useEffectEvent handlers called from thin effects:

handleReportChangeMarkAsRead()
handleAppVisibilityMarkAsRead(isFocused) — isFocused is passed as an argument

React runs its passive effect but skips the commit phase that refreshes the Effect Event closure, so isFocused stays stuck at the stale true. The guard then passed and readNewestAction re-marked a report the user had just marked unread. Probably related to react-freeze.
Passing isFocused as an argument uses the trigger-render value (false on switch-away), so the guard bails correctly.

isVisible is not passed — it tracks global tab visibility, which does not diverge per-screen, so reading it from the closure is safe. (Verified on web: isVisibleArg always equaled the closure value; only isFocused went stale.)

Fixed Issues

$ #89771
$ #95103
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Test: LHN - Marking an unread message as unread does not mark the conversation as unread

Navigate to a unread conversation with some history
Mark a new message as unread
Navigate away from the conversation
The conversation is marked as unread. When navigating back to the conversation, the new message marker is still displayed on top of the message

Offline tests

QA Steps

Verify that no errors appear in the JS console

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android.web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios.web.mov

MacOS: Chrome / Safari

web.mov

LukasMod · 2026-07-07T09:07:12Z

@codex review

chatgpt-codex-connector · 2026-07-07T09:12:14Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 93e9b15015

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-07-07T09:13:23Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-07-07T09:13:27Z

@rlinoz Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

No product review required.

LukasMod · 2026-07-09T07:16:29Z

Updated with latest main

codecov · 2026-07-09T07:18:48Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/hooks/useMarkAsRead.ts	`94.20% <100.00%> (+0.17%)`	⬆️
... and 12 files with indirect coverage changes

DylanDylann · 2026-07-09T07:53:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-07-09.at.15.13.46.mov

Android: mWeb Chrome

Screen.Recording.2026-07-09.at.14.56.09.mov

iOS: HybridApp

Screen.Recording.2026-07-09.at.15.13.07.mov

iOS: mWeb Safari

Screen.Recording.2026-07-09.at.14.57.44.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-08.at.18.22.04.mov

DylanDylann · 2026-07-09T07:53:14Z

@codex review

chatgpt-codex-connector · 2026-07-09T07:57:49Z

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: 8f5a6f3325

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

DylanDylann

LGTM

github-actions · 2026-07-09T15:08:24Z

🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-07-09T15:14:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-09T15:33:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95478.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-9283bc9d1c5-3ded924-45913a17ee4f50472e6f778a4b6e4b35b2cd6d08/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-9283bc9-3ded924-060e6da5d4ced56a2f15ac08a064d4f485845238/index.html

Web 🕸️
https://95478.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-10T16:19:35Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-10T16:22:44Z

🤖 No help site changes required.

I reviewed this PR against the help site content under docs/articles. This change is a purely internal implementation fix — it converts two useEffect blocks in src/hooks/useMarkAsRead.ts into useEffectEvent handlers to fix a stale-closure bug where a report the user had just marked unread was being re-marked as read when switching away.

No user-facing feature, tab, setting, button, or workflow is added or changed.
The "mark as unread" behavior itself is unchanged from the user's perspective — this fix just makes the existing behavior correct.
No help article under docs/articles documents this behavior (a search for "mark as unread" / "mark as read" returned no matching articles), so there is nothing to update.

Because there's no documentation impact, I did not create a draft docs PR.

add useEffectEvent to remove react-hooks/exhaustive-deps

93e9b15

melvin-bot Bot assigned LukasMod Jul 7, 2026

LukasMod marked this pull request as ready for review July 7, 2026 09:13

LukasMod requested review from a team as code owners July 7, 2026 09:13

melvin-bot Bot requested review from a team, DylanDylann and JmillsExpensify and removed request for a team July 7, 2026 09:13

melvin-bot Bot requested review from rlinoz and removed request for a team July 7, 2026 09:13

JmillsExpensify reviewed Jul 7, 2026

View reviewed changes

LukasMod mentioned this pull request Jul 7, 2026

[Due for payment 2026-07-13] [Split #88320] PR 10 - Compiler-clean pipeline hooks #89771

Open

JmillsExpensify changed the title ~~Decompose ReportActionsList: 10 - restore useEffectEvent~~ Decompose ReportActionsList: 10 - restore useEffectEven Jul 7, 2026

Merge branch 'main' of github.com:Expensify/App into decompose/ral-10-2

8f5a6f3

DylanDylann approved these changes Jul 9, 2026

View reviewed changes

rlinoz approved these changes Jul 9, 2026

View reviewed changes

rlinoz merged commit 9283bc9 into Expensify:main Jul 9, 2026
35 checks passed

OSBotify mentioned this pull request Jul 10, 2026

Deploy Checklist: New Expensify 2026-07-10 #95814

Open

73 tasks

Uh oh!

Conversation

LukasMod commented Jul 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

LukasMod commented Jul 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 7, 2026

Uh oh!

melvin-bot Bot commented Jul 7, 2026

Uh oh!

melvin-bot Bot commented Jul 7, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

LukasMod commented Jul 9, 2026

Uh oh!

codecov Bot commented Jul 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DylanDylann commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Jul 9, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 9, 2026

Uh oh!

DylanDylann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

MelvinBot commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

LukasMod commented Jul 7, 2026 •

edited

Loading

codecov Bot commented Jul 9, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Jul 9, 2026 •

edited

Loading