Pass isReportActionsExist to openReport (p1) by bernhardoj · Pull Request #95465 · Expensify/App

bernhardoj · 2026-07-07T06:30:43Z

Explanation of Change

Fixed Issues

$ #73651
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

A.

Open any chat with scrollable messages
Mark as unread the latest message
Scroll up until "New message" badge shows
Press "New message" badge
Verify there is no error

B.

[User B] Send an attachment to any chat that User A doesn't have access to. Copy the link
[User A] Open the link
Verify there is no error on the app (the OpenReport will fail because no report is found for User A)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

web.2.mp4

melvin-bot · 2026-07-07T06:30:49Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-07-07T06:35:09Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...equestReportView/MoneyRequestReportActionsList.tsx	`63.89% <ø> (+0.13%)`	⬆️
src/hooks/useReportActionsScroll.ts	`98.23% <ø> (+0.21%)`	⬆️
src/libs/actions/Report/index.ts	`70.61% <100.00%> (+0.02%)`	⬆️
...een/routes/report/ReportAttachmentModalContent.tsx	`97.14% <100.00%> (+0.08%)`	⬆️
...alScreen/routes/TransactionReceiptModalContent.tsx	`0.00% <0.00%> (ø)`
...s/report/ReportAddAttachmentModalContent/index.tsx	`0.00% <0.00%> (ø)`
... and 422 files with indirect coverage changes

JmillsExpensify

LGTM

eVoloshchak · 2026-07-08T16:43:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

screen-20260709-144108-1783600851632.mp4

Android: mWeb Chrome

Screen.Recording.2026-07-09.at.14.30.37.mov

iOS: HybridApp

Screen.Recording.2026-07-09.at.14.27.08.mov

iOS: mWeb Safari

Screen.Recording.2026-07-09.at.14.21.24.mov

MacOS: Chrome / Safari

Screen.Recording.2026-07-09.at.14.20.24.mov

eVoloshchak

LGTM!

luacmartins · 2026-07-09T15:36:41Z

    hasCompletedGuidedSetupFlow?: boolean;

+    /** Whether the report has report actions or not */
+    isReportActionsExist?: boolean;


Suggested change

isReportActionsExist?: boolean;

hasReportActions?: boolean;

luacmartins · 2026-07-09T17:12:42Z

@@ -0,0 +1,20 @@
+import {getOneTransactionThreadReportID} from '@libs/ReportActionsUtils';


I don't think this was supposed to be commited?

My bad. Deleted the file

luacmartins

LGTM

OSBotify · 2026-07-09T21:25:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-09T22:27:28Z

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-09T22:36:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95465.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-665e743c5fb-aa76580-671fc1a80dee71e301dbf1f1b1c36f338be7ffd6/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-665e743-aa76580-13162d9fcb35b0ead3337c4373f61c8541f819bf/index.html

Web 🕸️
https://95465.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-10T16:19:26Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-10T16:22:16Z

🤖 I reviewed the changes in this PR and no help site changes are required under docs/articles.

Why: This PR is a purely internal technical refactor with no user-facing behavior change. It adds an optional hasReportActions parameter to openReport() so callers can pass whether report actions exist (part of deprecating Onyx.connect() for the REPORT_ACTIONS key, per issue #73651). The remaining changes just thread that param through call sites and update unit tests.

There are no new features, settings, tabs, buttons, or workflows — nothing that a customer-facing help article documents. Accordingly, I did not create a draft docs PR.

@bernhardoj, please confirm you agree no help site updates are needed here. If you believe a docs change is warranted, let me know what behavior should be documented and I'll create the draft PR.

start passing isReportActionsExist to openReport

3fd4f37

bernhardoj requested review from a team as code owners July 7, 2026 06:30

melvin-bot Bot assigned bernhardoj Jul 7, 2026

melvin-bot Bot requested review from JmillsExpensify and eVoloshchak and removed request for a team July 7, 2026 06:30

github-actions Bot reviewed Jul 7, 2026

View reviewed changes

Comment thread src/libs/actions/Report/index.ts Outdated

remove todo

106f520

JmillsExpensify previously approved these changes Jul 7, 2026

View reviewed changes

eVoloshchak approved these changes Jul 9, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins July 9, 2026 12:42

luacmartins requested changes Jul 9, 2026

View reviewed changes

rename

68a326e

bernhardoj dismissed JmillsExpensify’s stale review via 68a326e July 9, 2026 15:57

luacmartins approved these changes Jul 9, 2026

View reviewed changes

luacmartins requested changes Jul 9, 2026

View reviewed changes

delete wrong commited file

f2e2d50

luacmartins approved these changes Jul 9, 2026

View reviewed changes

luacmartins merged commit 665e743 into Expensify:main Jul 9, 2026
35 checks passed

OSBotify mentioned this pull request Jul 10, 2026

Deploy Checklist: New Expensify 2026-07-10 #95814

Open

72 tasks

		@@ -0,0 +1,20 @@
		import {getOneTransactionThreadReportID} from '@libs/ReportActionsUtils';

Uh oh!

Conversation

bernhardoj commented Jul 7, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 7, 2026

Uh oh!

Uh oh!

codecov Bot commented Jul 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Jul 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

luacmartins Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

bernhardoj Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

MelvinBot commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Jul 7, 2026 •

edited by github-actions Bot

Loading

eVoloshchak commented Jul 8, 2026 •

edited

Loading

luacmartins Jul 9, 2026 •

edited

Loading