[CP Staging + Prod] Revert "feat: Enable react-native-nitro-fetch (V2)"#95284
Conversation
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Want me to do a quick test? |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d48b490a66
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "SWIFT_OBJC_INTEROP_MODE" => "objcxx", | ||
| # Enables stricter modular headers | ||
| "DEFINES_MODULE" => "YES", |
There was a problem hiding this comment.
Keep Swift header suppression for static iOS pods
On iOS builds this repo uses use_frameworks! :linkage => :static in ios/Podfile; removing the SWIFT_INSTALL_OBJC_HEADER => NO xcconfig here re-enables generation/installation of the ObjC compatibility header for the ExpensifyNitroUtils Swift+C++ interop pod, which the removed comment explicitly marked as breaking static linkage on Xcode 26.4. In that CI/release environment the native iOS build fails before the app launches, even though NitroFetch itself has been removed, so this workaround should be preserved while reverting the fetch dependency.
Useful? React with 👍 / 👎.
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
chrispader
left a comment
There was a problem hiding this comment.
LGTM! Closing #95285 in favor of this!
This comment has been minimized.
This comment has been minimized.
|
@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
[CP Staging + Prod] Revert "feat: Enable react-native-nitro-fetch (V2)" (cherry picked from commit 6df583c)
[CP Staging + Prod] Revert "feat: Enable react-native-nitro-fetch (V2)" (cherry picked from commit 6df583c) (cherry-picked to staging by mountiny)
…667859320-1 🍒 Cherry pick PR #95284 to staging 🍒
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.27-1 🚀
|
|
🤖 I reviewed the changes in this PR against the help site articles under No help site changes are required. I did not create a draft PR. Why: This PR is a manual revert of the internal
There are no changes to UI components, If you believe a specific user-facing behavior did change here that I should document, let me know and I'll take another pass. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
This is a manual revert of feat: Enable
react-native-nitro-fetch(V2) (merge commit3d794aef41bd071269b1324bd27b6d64503766b8).Because
maindiverged since that PR merged (the codebase-wide Oxfmt reformat, perf: remove flaggedExpenses, the native certificate-pinning + Sentry work, and a hermes-engine bump), a plaingit revertdid not apply cleanly. The conflicts were resolved manually so that only the changes introduced by #94469 are reverted, while unrelated follow-up work is preserved:src/libs/Prefetch/*tree, thesrc/polyfills/NitroFetch.*polyfills, and the nativeAutoPrefetcher.prefetchOnStart(...)entrypoint inMainApplication.kt— while keeping the follow-upSentryNativeSDKManager.initialize(...)andCertificatePinning.install()calls.fetchusage inHttpUtils.ts(drops thereact-native-nitro-fetchimport and prefetch wiring).enhanceParameters.ts,Reauthentication.ts, andtrackAuthenticationError.tsto their pre-feat: Enablereact-native-nitro-fetch(V2) #94469 form (removesAUTHENTICATION_COMMAND,getBaseRequestParameters, andgetPartnerCredentials).react-native-nitro-fetchdependency and revertsreact-native-nitro-modules(0.35.9 → 0.35.0) andnitrogen(0.35.5 → 0.35.0) inpackage.json, along with the regeneratedExpensifyNitroUtilsnitrogen output andios/Podfile.lockentries. The follow-up hermes-engine bump onmainis preserved.tests/actions/SessionTest.ts,tests/unit/NetworkTest.tsx,tests/unit/APITest.ts, andtests/unit/SessionUtilsTest.ts, while keeping the unrelatedFailureTrackerreset import added onmain.Fixed Issues
$ #90023
PROPOSAL:
Tests
fetchimplementation.Offline tests
None needed.
QA Steps
Run a full QA smoke of core flows, since this revert touches all network requests across the whole app (startup
OpenApp/ReconnectApp, sign in/out, and reauthentication).PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari