Skip to content

[CP Staging + Prod] Revert "feat: Enable react-native-nitro-fetch (V2)"#95284

Merged
mountiny merged 1 commit into
mainfrom
revert-nitro-fetch-v2-94469
Jul 3, 2026
Merged

[CP Staging + Prod] Revert "feat: Enable react-native-nitro-fetch (V2)"#95284
mountiny merged 1 commit into
mainfrom
revert-nitro-fetch-v2-94469

Conversation

@mountiny

@mountiny mountiny commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This is a manual revert of feat: Enable react-native-nitro-fetch (V2) (merge commit 3d794aef41bd071269b1324bd27b6d64503766b8).

Because main diverged since that PR merged (the codebase-wide Oxfmt reformat, perf: remove flaggedExpenses, the native certificate-pinning + Sentry work, and a hermes-engine bump), a plain git revert did not apply cleanly. The conflicts were resolved manually so that only the changes introduced by #94469 are reverted, while unrelated follow-up work is preserved:

  • Removes the entire src/libs/Prefetch/* tree, the src/polyfills/NitroFetch.* polyfills, and the native AutoPrefetcher.prefetchOnStart(...) entrypoint in MainApplication.kt — while keeping the follow-up SentryNativeSDKManager.initialize(...) and CertificatePinning.install() calls.
  • Restores native fetch usage in HttpUtils.ts (drops the react-native-nitro-fetch import and prefetch wiring).
  • Reverts enhanceParameters.ts, Reauthentication.ts, and trackAuthenticationError.ts to their pre-feat: Enable react-native-nitro-fetch (V2) #94469 form (removes AUTHENTICATION_COMMAND, getBaseRequestParameters, and getPartnerCredentials).
  • Removes the react-native-nitro-fetch dependency and reverts react-native-nitro-modules (0.35.9 → 0.35.0) and nitrogen (0.35.5 → 0.35.0) in package.json, along with the regenerated ExpensifyNitroUtils nitrogen output and ios/Podfile.lock entries. The follow-up hermes-engine bump on main is preserved.
  • Reverts the related tests in tests/actions/SessionTest.ts, tests/unit/NetworkTest.tsx, tests/unit/APITest.ts, and tests/unit/SessionUtilsTest.ts, while keeping the unrelated FailureTracker reset import added on main.

Fixed Issues

$ #90023
PROPOSAL:

Tests

  1. Open the app and confirm it loads normally and the UI hydrates.
  2. Open a report and confirm it loads.
  3. Open DevTools / native logs and confirm network requests succeed via the standard fetch implementation.
  4. Sign out and sign back in and confirm reauthentication works.
  • Verify that no errors appear in the JS console

Offline tests

None needed.

QA Steps

Run a full QA smoke of core flows, since this revert touches all network requests across the whole app (startup OpenApp/ReconnectApp, sign in/out, and reauthentication).

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

This reverts the changes introduced by PR #94469 (merge commit
3d794ae).

Co-authored-by: Cursor <cursoragent@cursor.com>
@mountiny mountiny requested review from a team as code owners July 3, 2026 14:07
@melvin-bot melvin-bot Bot requested review from mkhutornyi and trjExpensify and removed request for a team July 3, 2026 14:07
@melvin-bot

melvin-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny changed the title Revert "feat: Enable react-native-nitro-fetch (V2)" [CP Staging +Prod] Revert "feat: Enable react-native-nitro-fetch (V2)" Jul 3, 2026
@mountiny mountiny changed the title [CP Staging +Prod] Revert "feat: Enable react-native-nitro-fetch (V2)" [CP Staging + Prod] Revert "feat: Enable react-native-nitro-fetch (V2)" Jul 3, 2026
@mkhutornyi

Copy link
Copy Markdown
Contributor

Want me to do a quick test?

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d48b490a66

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines 56 to 58
"SWIFT_OBJC_INTEROP_MODE" => "objcxx",
# Enables stricter modular headers
"DEFINES_MODULE" => "YES",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Swift header suppression for static iOS pods

On iOS builds this repo uses use_frameworks! :linkage => :static in ios/Podfile; removing the SWIFT_INSTALL_OBJC_HEADER => NO xcconfig here re-enables generation/installation of the ObjC compatibility header for the ExpensifyNitroUtils Swift+C++ interop pod, which the removed comment explicitly marked as breaking static linkage on Xcode 26.4. In that CI/release environment the native iOS build fails before the app launches, even though NitroFetch itself has been removed, so this workaround should be preserved while reverting the fetch dependency.

Useful? React with 👍 / 👎.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 93.33% <ø> (ø)
src/libs/API/types.ts 100.00% <ø> (ø)
src/libs/HttpUtils.ts 87.50% <100.00%> (+0.83%) ⬆️
src/libs/Network/enhanceParameters.ts 96.96% <100.00%> (+0.30%) ⬆️
src/libs/Reauthentication.ts 61.70% <100.00%> (+0.83%) ⬆️
src/libs/Request.ts 100.00% <100.00%> (ø)
src/libs/SessionUtils.ts 96.00% <ø> (-0.37%) ⬇️
src/libs/actions/Session/index.ts 41.54% <100.00%> (+0.12%) ⬆️
src/libs/telemetry/trackAuthenticationError.ts 100.00% <ø> (ø)
... and 7 files with indirect coverage changes

@chrispader chrispader left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Closing #95285 in favor of this!

@github-actions

This comment has been minimized.

@melvin-bot melvin-bot Bot requested a review from puneetlath July 3, 2026 14:33
@melvin-bot

melvin-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

@puneetlath Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny merged commit 6df583c into main Jul 3, 2026
51 of 55 checks passed
@mountiny mountiny deleted the revert-nitro-fetch-v2-94469 branch July 3, 2026 14:47
@melvin-bot melvin-bot Bot added the Emergency label Jul 3, 2026
@melvin-bot

melvin-bot Bot commented Jul 3, 2026

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Jul 3, 2026
@OSBotify

OSBotify commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

mountiny added a commit that referenced this pull request Jul 3, 2026
[CP Staging + Prod] Revert "feat: Enable react-native-nitro-fetch (V2)"

(cherry picked from commit 6df583c)
mountiny added a commit that referenced this pull request Jul 3, 2026
[CP Staging + Prod] Revert "feat: Enable react-native-nitro-fetch (V2)"

(cherry picked from commit 6df583c)

(cherry-picked to staging by mountiny)
justinpersaud added a commit that referenced this pull request Jul 3, 2026
…667859320-1

🍒 Cherry pick PR #95284 to staging 🍒
@OSBotify

OSBotify commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.27-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against the help site articles under App/docs/articles.

No help site changes are required. I did not create a draft PR.

Why: This PR is a manual revert of the internal react-native-nitro-fetch (V2) networking feature. Every changed file is internal engineering with no user-facing surface:

  • Network/prefetch internals — src/libs/Prefetch/*, src/polyfills/NitroFetch.*, src/libs/HttpUtils.ts, src/libs/Network/enhanceParameters.ts, src/libs/Reauthentication.ts, src/libs/Request.ts
  • Native + build config — android/.../MainApplication.kt, ios/Podfile.lock, package.json, package-lock.json, nitrogen generated output
  • Tests and jest setup

There are no changes to UI components, src/languages/* copy, feature names, tab/settings labels, or any user-facing behavior. The revert simply restores the standard fetch implementation transparently to end users, so there is nothing to document or update on the help site.

If you believe a specific user-facing behavior did change here that I should document, let me know and I'll take another pass.

@OSBotify

OSBotify commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging Emergency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants