[CP Staging] Revert PR #94784 to stop loginToAccountIDMap massive logs#95233
Conversation
Removes the loginToAccountIDMap derived Onyx key and restores the pre-94784 Attendee type/shape. Resolves conflicts with #94299 by keeping the flaggedExpenses hook migration. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d877b2cd26
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }).length; | ||
| if (ownerAccountID !== undefined) { | ||
| // Normal case: filter by accountID | ||
| attendeesMinusOwnerCount = attendees.filter((a) => a?.accountID !== ownerAccountID).length; |
There was a problem hiding this comment.
When iouReport.ownerAccountID is available but comment.attendees comes from older/server data that only has email (the shape used before this change), this branch treats every attendee with no accountID as a non-owner because undefined !== ownerAccountID. A control-policy expense with attendee tracking required and only the report owner in the attendee list will therefore clear/avoid the missingAttendees violation, even though there is no non-owner attendee. Please fall back to comparing the owner login/email when an attendee lacks accountID rather than counting it as non-owner.
Useful? React with 👍 / 👎.
mountiny
changed the title
Aligns expectations with the reverted Attendee fields restored in IOUUtils after reverting PR #94784. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Reverting the merge commit of PR #94784 also reverted the submodule gitlink to its pre-94784 value. Reset it to origin/main so the PR contains no submodule diff. Co-authored-by: Cursor <cursoragent@cursor.com>
…-type Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/libs/actions/OnyxDerived/configs/loginToAccountIDMap.ts
Co-authored-by: Shubham Agrawal <58412969+shubham1206agra@users.noreply.github.com>
The reviewer suggestion changed the attendee text field from login to displayName, so update the expected value accordingly. Co-authored-by: Cursor <cursoragent@cursor.com>
robertjchen
left a comment
robertjchen
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…650615538-1 🍒 Cherry pick PR #95233 to staging 🍒
|
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.4.27-1 🚀
|
|
🤖 Help site review — no changes required I reviewed the changes in this PR against Why: This PR reverts #94784 to remove the internal The existing attendee help articles (e.g. If the BE-aligned attendee shape from #94784 / #82191 is later re-landed with a logging-safe approach and that changes anything user-facing, docs should be revisited then — but nothing is needed for this revert. |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀
Bundle Size Analysis (Sentry): |
5 participants
Explanation of Change
Reverts PR #94784, which introduced the
loginToAccountIDMapderived Onyx key. That key maps every personal-details email to an account ID and is written viaOnyx.set()whenever personal details change. react-native-onyx logs every top-level property name on each set, so accounts with many contacts produce log lines over 1 MiB. Web-Expensify'sLogAPIdrops those messages and raisesLogAPI - Massive log message given(Expensify/Expensify#655280).This revert removes
loginToAccountIDMapand restores the pre-94784 Attendee type/shape (lookup viapersonalDetailsListbyaccountID). Conflicts with #94299 were resolved by keeping the flagged-expenses hook migration (no re-add ofFLAGGED_EXPENSESderived key).Tradeoff: Attendee type no longer matches the BE-aligned shape from #94784 / #82191 until re-landed with a logging-safe approach.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/655280
PROPOSAL:
Tests
LogAPI - Massive log message givenalerts are triggered from[Onyx] set called for key: loginToAccountIDMapmessages.Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari