Skip to content

[No QA] merge main#95100

Merged
stephanieelliott merged 701 commits into
helpsite-billing-articlesfrom
main
Jul 1, 2026
Merged

[No QA] merge main#95100
stephanieelliott merged 701 commits into
helpsite-billing-articlesfrom
main

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

daledah and others added 30 commits June 29, 2026 22:32
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…unts

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Canonical subpath exports replace tsconfig paths and dist/* imports.
Keep a narrow webpack/jest/storybook shim only for live-markdown's
stale expensify-common/dist/utils import.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep expensify-common SafeString imports and adopt main's search approve
refactor and TripReservationUtils date-fns imports.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
0.1.329 uses expensify-common/utils, so webpack, jest, and storybook no
longer need expensify-common/dist/utils aliases.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
stephanieelliott and others added 8 commits July 1, 2026 10:19
…fDocs

[Payment due @truph01] [No QA] Docs updates for E/A#92275 bulk Download as PDF for reports
Docs updates for E/A#93451 Add Recently added slot to Home Overview
…al-saved-searches

[No QA] Docs updates for E/A#93937 saved searches sorted alphabetically
[Rules Revamp] Release 2: Move category-based creation into Rules; add Require fields and Flag for review
…rface

[No QA] Docs updates for E/A#94131 surface RuleBot in Agent rules section
fix: Created expense at submitted report then create expense at ws chat add to the submitted report
…cipantSelection

Guard P2P participant selection against negative-amount expenses from self DM
@stephanieelliott stephanieelliott requested review from a team as code owners July 1, 2026 23:21
@melvin-bot melvin-bot Bot requested review from flaviadefaria and removed request for a team July 1, 2026 23:21
@stephanieelliott stephanieelliott merged commit 233db29 into helpsite-billing-articles Jul 1, 2026
96 of 97 checks passed
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR adds a new Onyx.connectWithoutView call, so I've requested a review from the Onyx performance reviewers (@tgolen, @mountiny, @luacmartins) — a review from any one of them is enough. Please add a link in your PR description to the Slack discussion where the @frontend-performance team approved using connectWithoutView here.

@melvin-bot

melvin-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @sakluger

@melvin-bot melvin-bot Bot requested review from MonilBhavsar and sakluger and removed request for a team July 1, 2026 23:22
@melvin-bot

melvin-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

@MonilBhavsar @sakluger One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions github-actions Bot changed the title merge main [No QA] merge main Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.02% <ø> (-0.05%) ⬇️
src/DelegateAccessHandler.tsx 93.33% <ø> (ø)
src/ONYXKEYS.ts 100.00% <ø> (ø)
src/SCREENS.ts 100.00% <ø> (ø)
src/components/ApproverSelectionList.tsx 90.90% <100.00%> (+0.21%) ⬆️
...rc/components/Attachments/AttachmentView/index.tsx 52.94% <ø> (ø)
src/components/AvatarWithDisplayName.tsx 80.41% <100.00%> (+0.20%) ⬆️
src/components/ButtonWithDropdownMenu/index.tsx 89.65% <100.00%> (+0.44%) ⬆️
...rc/components/Charts/hooks/useChartLabelFormats.ts 94.11% <100.00%> (ø)
src/components/Charts/hooks/useChartLabelLayout.ts 100.00% <100.00%> (ø)
... and 105 more
... and 470 files with indirect coverage changes

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR merges main into the helpsite-billing-articles branch. Among the 300+ changed files, five HelpDot articles received documentation changes. All are additive, incremental updates to existing published articles (new sections, new FAQ entries, and small factual corrections) rather than new articles. The proposed changes are consistently well-structured and adhere closely to the governance standards.

Scores Summary

  • Readability: 9/10 - Clear, scannable prose. New sections use short sentences, bulleted actions, and concrete examples (e.g. the "added today but dated months ago" example). Numbered steps in the export article are sequential and action-oriented.
  • AI Readiness: 9/10 - New H2 headings are task-based and feature-specific ("How the Recently added section works on Home", "How to download multiple reports as PDFs"). FAQ entries are question-led. Metadata (keywords, internalScope) was updated in step with the new content in both Expensify-Home-Overview.md and How-to-Export-Reports.md, keeping search intent aligned.
  • Style Compliance: 9/10 - Exact UI labels are bolded (Recently added, View all expenses, Download as PDF, Selected). The three dots menu uses the required bold three dots (vertical ellipsis) format. Navigation uses the approved unified phrasing "In the navigation tabs (on the left on web, on the bottom on mobile)".

Key Findings

  • Strong governance alignment: heading hierarchy stays at H1/H2 only, headings are task/question based, and the FAQ section is used correctly.
  • Metadata discipline: keyword and internalScope updates accompany the new content instead of drifting out of date.
  • The export article correctly renames the existing heading to "How to download a single report as a PDF" to disambiguate from the new bulk section, and handles the failure case with a dedicated FAQ.
  • Minor style concern in Split-Expenses.md: "(but this functionality will be available soon)" introduces a soft, forward-looking promise. Governance favors deterministic, present-state statements; consider stating the current limitation without the roadmap promise.

Recommendations

  • Split-Expenses.md: Reword to describe only the current behavior (state that unreported expenses cannot be split yet) and drop the "available soon" phrasing to avoid dating the article.
  • Create-Agent-Rules.md: The added sentence is fine, but agent / Agent rules casing is mixed across the surrounding text; confirm it matches the exact product UI casing.
  • No blocking issues for the documentation changes in this PR.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Expensify-Home-Overview.md - New "Recently added" section plus 2 FAQ entries; metadata updated. Compliant.
  • docs/articles/new-expensify/reports-and-expenses/How-to-Export-Reports.md - Added bulk PDF download section plus failure FAQ; heading disambiguated; metadata updated. Compliant.
  • docs/articles/new-expensify/reports-and-expenses/Using-Reports-in-New-Expensify.md - One clarifying sentence on saved search ordering. Compliant.
  • docs/articles/new-expensify/ai-agents/Create-Agent-Rules.md - One sentence on the RuleBot enforcement display. Compliant; minor casing check suggested.
  • docs/articles/new-expensify/reports-and-expenses/Split-Expenses.md - One-line factual correction; minor "available soon" wording concern.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.