Skip to content

[Snyk] Fix for 1 vulnerabilities#95061

Merged
Beamanator merged 3 commits into
mainfrom
snyk-fix-e46a80424a41cbbc59375157ec7c9713
Jul 9, 2026
Merged

[Snyk] Fix for 1 vulnerabilities#95061
Beamanator merged 3 commits into
mainfrom
snyk-fix-e46a80424a41cbbc59375157ec7c9713

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-ESBUILD-17750822
@MelvinBot

Copy link
Copy Markdown
Contributor Author

Merge Risk: Low

This update includes minor version bumps for Storybook and tsx, consisting of new features, performance improvements, and bug fixes without any documented breaking changes for the specified version ranges.

Key Changes:

  • @storybook/cli & storybook (10.1.10 → 10.4.6): This is a minor update within the same major version. The releases between these versions introduce features like improved React component metadata, AI-assisted setup workflows, and various bug fixes. No breaking changes are documented in this range.

  • tsx (4.21.0 → 4.22.0): This minor update primarily upgrades the underlying esbuild dependency and adds support for newer Node.js versions. The release notes do not indicate any breaking changes.

Overall, the risk associated with this upgrade is low.

Notice 🤖: This content was augmented using artificial intelligence. AI-generated content may contain errors and should be reviewed for accuracy before use.

@MelvinBot MelvinBot requested a review from a team as a code owner July 1, 2026 15:39
@melvin-bot melvin-bot Bot requested review from Beamanator and removed request for a team July 1, 2026 15:40
@melvin-bot

melvin-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eec1a4623c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread package.json
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Fixed the failing checks.

Root cause: This Snyk PR bumped @storybook/cli (10.1.1010.4.6), storybook (10.1.1010.4.6), and tsx (4.21.04.22.0) in package.json but did not regenerate package-lock.json. Every CI job starts with npm ci, which requires the two files to be in sync and hard-fails otherwise — so all checks failed at the setup step with:

npm error npm ci can only install packages when your package.json and package-lock.json ... are in sync.
npm error Invalid: lock file's @storybook/cli@10.1.10 does not satisfy @storybook/cli@10.4.6
npm error Invalid: lock file's storybook@10.1.10 does not satisfy storybook@10.4.6
npm error Invalid: lock file's tsx@4.21.0 does not satisfy tsx@4.22.0

Fix: Ran npm install to regenerate package-lock.json so it satisfies the bumped versions (including their transitive dependency updates), then committed and pushed. Only package-lock.json changed.

The re-run checks should now get past npm ci. If any genuinely test-related check still fails after this, it would be unrelated to the lock-file sync and worth a separate look.

@Beamanator

Copy link
Copy Markdown
Contributor

@MelvinBot pull main and re-review this PR

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Pulled main and re-reviewed. This is a low-risk, dev-dependency-only Snyk bump — safe to approve once the re-run finishes green.

main pulled in: I merged main into the branch server-side ("Update branch") — the branch is now up to date (behind_by: 0). The merge was clean and dependency-neutral: main had only advanced by a Mobile-Expensify submodule bump, which doesn't touch any JS package, so the package.jsonpackage-lock.json sync from my earlier fix is intact.

Re-review of the change: the diff only touches package.json + package-lock.json and bumps three devDependencies (build/test tooling, not shipped to the app runtime):

  • @storybook/cli 10.1.1010.4.6 (minor, same major)
  • storybook 10.1.1010.4.6 (minor, same major)
  • tsx 4.21.04.22.0 (minor — mainly an esbuild bump)

All are within-major minor bumps with no documented breaking changes.

CI status: the previous pre-merge run was fully green. Post-merge checks are re-running now — 0 failures so far; the npm ci-gated jobs (test, typecheck, build, Storybook tests) are still in progress. Since main didn't touch the dependency files, I expect them to pass again — worth a glance before merging to confirm.


Reply with @MelvinBot <feedback> if you'd like me to dig into anything further.

@codecov

codecov Bot commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 11 files with indirect coverage changes

@Beamanator Beamanator merged commit b794ad3 into main Jul 9, 2026
48 checks passed
@Beamanator Beamanator deleted the snyk-fix-e46a80424a41cbbc59375157ec7c9713 branch July 9, 2026 19:02
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.4.33-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants