[Home Page] Design Followup for Recently Added Slot by adamgrzybowski · Pull Request #95056 · Expensify/App

adamgrzybowski · 2026-07-01T14:37:17Z

Explanation of Change

The receipt hover preview used to appear in a fixed corner of the screen; it now anchors beside the hovered row's thumbnail, growing upward and flipping/clamping so it stays fully on-screen near the edges.
Standardized the card header overflow action into a reusable WidgetHeaderMenu (Medium Ghost three-dots button + popover) so every widget header keeps a consistent height and behavior.
Extracted hard-coded style values into shared variables and added unit tests for the preview positioning logic.

Fixed Issues

$ #94159
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

Verify that no errors appear in the JS console

QA Steps

Open a report/list with transaction rows that have receipts and hover a receipt thumbnail. Verify the preview appears beside the row (not in the corner) and grows upward.
Hover a receipt row near the right edge and near the top/bottom of the viewport. Verify the preview flips/clamps so it stays fully visible on-screen.
Open a home widget header three-dots menu. Verify the menu opens anchored to the button and the header height is unchanged.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-01.at.16.02.20.mp4

Position the receipt preview beside the hovered thumbnail instead of a fixed corner, standardize card header menus with WidgetHeaderMenu, and extract shared style values into variables.

melvin-bot · 2026-07-01T14:37:24Z

@dannymcclain @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 96b1b878ec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-07-01T14:48:42Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/ThreeDotsMenu/index.tsx	`94.20% <100.00%> (+8.26%)`	⬆️
...emRow/ReceiptPreview/getAnchoredPreviewPosition.ts	`100.00% <100.00%> (ø)`
src/pages/home/RecentlyAddedSection/index.tsx	`100.00% <100.00%> (+2.22%)`	⬆️
.../home/common/WidgetHeaderMenu/WidgetHeaderMenu.tsx	`100.00% <100.00%> (ø)`
src/styles/index.ts	`60.30% <ø> (-0.41%)`	⬇️
src/styles/variables.ts	`100.00% <ø> (ø)`
...nents/TransactionItemRow/DataCells/ReceiptCell.tsx	`90.62% <66.66%> (-2.48%)`	⬇️
...endOverTimeSection/SpendOverTimeSectionContent.tsx	`0.00% <0.00%> (ø)`
...onents/TransactionItemRow/ReceiptPreview/index.tsx	`0.00% <0.00%> (ø)`
... and 122 files with indirect coverage changes

dannymcclain · 2026-07-01T14:55:59Z

@adamgrzybowski the receipt preview is looking really good (side note: how do I get that red car?!? I love ittttttt)

For the more button, is there any way to make the space on the right side of the button the same as the top?

TBH this is not that big of a deal, because I actually think it looks pretty good as is, but it would be extra good if they were equal :)

cc @shawnborton too!

shawnborton · 2026-07-01T14:57:00Z

Receipt placement looks good! Agree with Danny's comment about the icon button.

…, fix button spacing - Cap the receipt preview's bottom to the viewport so a row scrolled partially off the bottom keeps the preview fully on-screen - Rename WidgetHeaderMenu/index.tsx to WidgetHeaderMenu.tsx (CONSISTENCY-9) and drop the unused WidgetHeaderMenuProps export (knip) - Add a negative right margin so the header menu icon's right spacing matches its top spacing

adamgrzybowski · 2026-07-01T15:18:12Z

@dannymcclain something like this?

Haha, you could buy it in Poland for $100 when I was a kid 😄 Now the price is only growing

dannymcclain · 2026-07-01T15:25:18Z

Button placement looks great 👍

🥹 Look at how cute he is 🚗

ZhenjaHorbach · 2026-07-02T09:35:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-07-02.11.28.40.mov

Android: mWeb Chrome

2026-07-02.11.27.01.mov

iOS: HybridApp

2026-07-02.11.28.40.mov

iOS: mWeb Safari

2026-07-02.11.27.01.mov

MacOS: Chrome / Safari

2026-07-02.11.25.38.mov

ZhenjaHorbach · 2026-07-02T09:35:48Z

But overall changes look good

github-actions · 2026-07-02T16:12:06Z

🚧 JmillsExpensify has triggered a test Expensify/App build. You can view the workflow run here.

# Conflicts: # src/components/TransactionItemRow/DataCells/ReceiptCell.tsx # src/components/TransactionItemRow/ReceiptPreview/index.tsx # src/pages/home/RecentlyAddedSection/index.tsx # src/pages/home/SpendOverTimeSection/SpendOverTimeSectionContent.tsx

JmillsExpensify

All looks good to me!

ZhenjaHorbach · 2026-07-03T10:39:10Z

@adamgrzybowski
Let's fix oxfmt issues

adamgrzybowski · 2026-07-06T09:30:10Z

Let's merge this PR to avoid conflicts @grgia

Reuse ThreeDotsMenu (with shouldSelfPosition) so widget header menus get the shared More tooltip and resize-aware popover positioning. Add opt-in props to ThreeDotsMenu for the ghost-button look: iconWidth/iconHeight, iconHoverStyle, shouldChangeFillOnOpen, and testID.

Stabilize the usePopoverPosition mock reference so ThreeDotsMenu's layout effect doesn't loop infinitely once the popover opens.

OSBotify · 2026-07-06T13:13:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-06T13:23:03Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-06T13:30:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95056.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-13f9a435ad4-1af49bb-5f82092551a1c218a24badc5d82248ed2e7b3e97/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-13f9a43-1af49bb-87a934b1f7a04c25227457c80f51cb936bfd4c74/index.html

Web 🕸️
https://95056.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-06T15:47:03Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.4.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-06T15:50:29Z

🤖 Help site review: no changes required.

I reviewed the changes in this PR against the help site content under App/docs/articles. This is a UI/design refinement PR with no user-facing behavior or feature changes that the help site documents:

Receipt hover preview now anchors beside the hovered row's thumbnail (growing upward and flipping/clamping near screen edges) instead of sitting in a fixed corner — a positioning refinement, not a functional change.
Widget header overflow menu was standardized into a reusable WidgetHeaderMenu (three-dots button + popover) for consistent header height/behavior — an internal component refactor.
Style values were extracted into shared variables and unit tests were added.

None of these introduce, remove, or alter any documented product feature, setting, tab, or flow. There are no help articles describing the receipt hover-preview positioning or the home widget header menu, so no draft PR was created.

If you believe a specific article should be updated, let me know which one and I'll take another look.

OSBotify · 2026-07-07T17:54:46Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.28-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

shawnborton · 2026-07-10T13:36:12Z

Hmm I don't think we wanted to change the location of the receipt thumbnail on the Spend page when the menu is expanded, is that right?

adamgrzybowski · 2026-07-13T09:23:13Z

@shawnborton I will fix that

adamgrzybowski · 2026-07-13T14:00:40Z

@shawnborton

Hmm, this is from the main. Are you still able to reproduce this problem? Also, are you sure that this comes from this PR?

shawnborton · 2026-07-13T15:20:11Z

Hmm I am seeing it still on staging. Maybe it doesn't come from this PR? I can file a separate bug report and we can investigate from there.

adamgrzybowski · 2026-07-13T15:40:40Z

@shawnborton tag me in the new issue, maybe I will have some additional context. I am currently looking into related code

Anchor receipt hover preview to row and add WidgetHeaderMenu

96b1b87

Position the receipt preview beside the hovered thumbnail instead of a fixed corner, standardize card header menus with WidgetHeaderMenu, and extract shared style values into variables.

adamgrzybowski requested review from a team as code owners July 1, 2026 14:37

melvin-bot Bot assigned adamgrzybowski Jul 1, 2026

melvin-bot Bot requested review from ZhenjaHorbach, dannymcclain and flaviadefaria and removed request for a team July 1, 2026 14:37

adamgrzybowski changed the title ~~Anchor receipt hover preview to row and add WidgetHeaderMenu~~ [Home Page] Design Followup for Recently Added Slot Jul 1, 2026

chatgpt-codex-connector Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread src/components/TransactionItemRow/ReceiptPreview/getAnchoredPreviewPosition.ts

github-actions Bot reviewed Jul 1, 2026

View reviewed changes

Comment thread src/pages/home/common/WidgetHeaderMenu/WidgetHeaderMenu.tsx Outdated

ZhenjaHorbach reviewed Jul 2, 2026

View reviewed changes

Comment thread src/components/TransactionItemRow/DataCells/ReceiptCell.tsx Outdated

Move AnchorPosition type to common TransactionItemRow types

5e4449d

This comment has been minimized.

Sign in to view

JmillsExpensify requested review from JmillsExpensify and removed request for flaviadefaria July 3, 2026 10:35

JmillsExpensify previously approved these changes Jul 3, 2026

View reviewed changes

Run fmt

686cd8c

adamgrzybowski dismissed JmillsExpensify’s stale review via 686cd8c July 3, 2026 14:06

ZhenjaHorbach approved these changes Jul 3, 2026

View reviewed changes

melvin-bot Bot requested a review from grgia July 3, 2026 16:13

grgia reviewed Jul 6, 2026

View reviewed changes

Comment thread src/pages/home/common/WidgetHeaderMenu/WidgetHeaderMenu.tsx Outdated

adamgrzybowski added 2 commits July 6, 2026 13:22

Fix RecentlyAddedSection overflow menu test hang

7a3557c

Stabilize the usePopoverPosition mock reference so ThreeDotsMenu's layout effect doesn't loop infinitely once the popover opens.

grgia approved these changes Jul 6, 2026 •

edited

Loading

View reviewed changes

grgia merged commit 13f9a43 into Expensify:main Jul 6, 2026
35 checks passed

OSBotify mentioned this pull request Jul 6, 2026

Deploy Checklist: New Expensify 2026-07-06 #95398

Closed

46 tasks

applause-bot Bot mentioned this pull request Jul 6, 2026

[Exploratory] Home - Loading spinner is displayed at the bottom of preview after cropping receipt. #95429

Open

7 tasks

melvin-bot Bot mentioned this pull request Jul 7, 2026

[Due for payment 2026-07-14] [Home Page] Design Followup for Recently Added Slot #94159

Closed

dilshodmackbook-sketch mentioned this pull request Jul 13, 2026

[$250] Receipt hover preview zoom opens on the wrong side of the thumbnail #95975

Open

7 tasks

Uh oh!

Conversation

adamgrzybowski commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 1, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented Jul 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

dannymcclain commented Jul 1, 2026

Uh oh!

shawnborton commented Jul 1, 2026

Uh oh!

adamgrzybowski commented Jul 1, 2026

Uh oh!

dannymcclain commented Jul 1, 2026

Uh oh!

Uh oh!

ZhenjaHorbach commented Jul 2, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

ZhenjaHorbach commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

This comment has been minimized.

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jul 3, 2026

Uh oh!

adamgrzybowski commented Jul 6, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

MelvinBot commented Jul 6, 2026

Uh oh!

OSBotify commented Jul 7, 2026

Uh oh!

shawnborton commented Jul 10, 2026

Uh oh!

adamgrzybowski commented Jul 13, 2026

Uh oh!

adamgrzybowski commented Jul 13, 2026

Uh oh!

shawnborton commented Jul 13, 2026

Uh oh!

adamgrzybowski commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

adamgrzybowski commented Jul 1, 2026 •

edited

Loading

codecov Bot commented Jul 1, 2026 •

edited by github-actions Bot

Loading