Fix all-empty column sort reordering rows and flipping between asc/desc by mukhrr · Pull Request #95022 · Expensify/App

mukhrr · 2026-07-01T04:37:28Z

Explanation of Change

Fixed Issues

$ #94893
PROPOSAL: #93146 (comment)

Tests

Go to Spend -> Expenses on web
Enable all columns
Try to click every empty sortable column

Verify sort order doesn't change in table
Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

The same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

REC-20260701095655.mp4

melvin-bot · 2026-07-01T04:37:33Z

@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

trjExpensify

@shawnborton @dannymcclain just confirming our expectation here. The column in question is empty, so we flip asc/desc but that effectively does nothing to the table because it's empty. We cool with that? I think it's probably fine vs. say disabling the click on an empty column?

shawnborton · 2026-07-01T15:55:37Z

Yeah I don't feel strongly... I guess in an ideal world, if the column truly has no data, you shouldn't be able to sort on it, but I don't know how hard that would be to pull off. But I'm happy to go with what is in the PR for now.

dannymcclain · 2026-07-01T15:56:58Z

I feel the same as Shawn 👍

trjExpensify · 2026-07-01T16:05:06Z

Works for me!

trjExpensify

👍

ahmedGaber93 · 2026-07-03T04:16:10Z

+            expect(ascendingResult.map((item) => ('transactionID' in item ? item.transactionID : undefined))).toEqual(inputOrder);
+            expect(descendingResult.map((item) => ('transactionID' in item ? item.transactionID : undefined))).toEqual(inputOrder);
+        });
+


@mukhrr can we also add a unit test to confirm (Reimbursable/Billable) columns still tie-break by created and this PR not blocking the exist behaviour.

ahmedGaber93 · 2026-07-03T04:29:12Z

@mukhrr, could you please update the QA steps and confirm that this issue is a large-screen web only?

ahmedGaber93 · 2026-07-03T04:32:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-03.at.7.25.55.AM.mov

codecov · 2026-07-03T06:55:53Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/SearchUIUtils.ts	`63.49% <100.00%> (+0.13%)`	⬆️
... and 24 files with indirect coverage changes

…ated Reimbursable/Billable resolve to a non-empty "yes"/"no" sort value, so the empty-guard added for Expensify#94893 is skipped and the created/transactionID tie breaker still runs and still honors sortOrder. This locks in that the fix does not regress the boolean-column behavior added in Expensify#77800. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

mukhrr · 2026-07-03T07:22:13Z

@mukhrr, could you please update the QA steps and confirm that this issue is a large-screen web only?

@ahmedGaber93 I don't think it's possible to enable empty columns in OP for mobile since there is no table

ahmedGaber93 · 2026-07-03T16:36:51Z

@mukhrr, could you please update the QA steps and confirm that this issue is a large-screen web only?

@ahmedGaber93 I don't think it's possible to enable empty columns in OP for mobile since there is no table

Yes, I just meant to mention this in the test steps.

Tests

Web only

...
...

QA steps

Same as Test step

mukhrr · 2026-07-03T17:16:38Z

@mukhrr, could you please update the QA steps and confirm that this issue is a large-screen web only?

@ahmedGaber93 I don't think it's possible to enable empty columns in OP for mobile since there is no table

Yes, I just meant to mention this in the test steps.

Tests

Web only

...

...

QA steps

Same as Test step

Ah yes, thanks. Updated now

mukhrr · 2026-07-03T17:36:46Z

@ahmedGaber93 i think we are good to go ?

github-actions · 2026-07-06T11:35:17Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-06T11:41:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #95022.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-02e4d0d8ae3-9f3daf7-2aee42f68a70ba689eabf0e76b5cd9a6e40d425c/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-02e4d0d-9f3daf7-172bcd8e564fc53b546bd067f93588db8249eb22/index.html

Web 🕸️
https://95022.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-06T11:54:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-07-06T15:46:59Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.28-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-06T15:50:38Z

🤖 Help site review: no changes required.

This PR fixes an internal bug in the Search table's sort logic (src/libs/SearchUIUtils.ts): clicking a sortable column that is empty for every row now keeps the existing row order and behaves identically for ascending/descending, instead of reordering rows via the created/transactionID tie-breaker.

This is a bug fix to a tie-breaker edge case, not a new or changed user-facing feature, tab, setting, or button. Expensify's help site (docs/articles) documents how features work at a functional level — it does not document column-sort tie-breaking internals, and no existing article describes this behavior. There is nothing to add or update.

No draft docs PR was created since no documentation change is warranted.

@mukhrr, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-07-07T17:54:43Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.4.28-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Fix all-empty column sort reordering rows and flipping between asc/desc

60b81ff

mukhrr requested review from a team as code owners July 1, 2026 04:37

melvin-bot Bot assigned mukhrr Jul 1, 2026

melvin-bot Bot requested review from ahmedGaber93 and trjExpensify July 1, 2026 04:37

melvin-bot Bot removed request for a team July 1, 2026 04:37

removed unnecessary issue number in comment

a819eb0

mukhrr mentioned this pull request Jul 1, 2026

[Due for payment 2026-07-14] Sorting an all-empty column (Posted/Approved/Withdrawal ID) reorders rows and flips between asc/desc #94893

Open

trjExpensify reviewed Jul 1, 2026

View reviewed changes

JS00001 previously approved these changes Jul 1, 2026

View reviewed changes

trjExpensify previously approved these changes Jul 1, 2026

View reviewed changes

ahmedGaber93 reviewed Jul 3, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into fix/94893

ecf1423

mukhrr dismissed stale reviews from trjExpensify and JS00001 via 105f39c July 3, 2026 07:10

mukhrr requested a review from ahmedGaber93 July 3, 2026 07:22

ahmedGaber93 approved these changes Jul 3, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 July 3, 2026 18:24

JS00001 approved these changes Jul 6, 2026

View reviewed changes

JS00001 merged commit 02e4d0d into Expensify:main Jul 6, 2026
39 checks passed

github-actions Bot mentioned this pull request Jul 6, 2026

Investigate workflow job failing on main: test / test (job 3) #95384

Closed

OSBotify mentioned this pull request Jul 6, 2026

Deploy Checklist: New Expensify 2026-07-06 #95398

Closed

46 tasks

applause-bot Bot mentioned this pull request Jul 7, 2026

[Exploratory] Spend - "Sort Order" is not resetted when column is disabled and empty columns reappear. #95459

Open

7 tasks

Uh oh!

Conversation

mukhrr commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 1, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Jul 1, 2026

Uh oh!

dannymcclain commented Jul 1, 2026

Uh oh!

trjExpensify commented Jul 1, 2026

Uh oh!

trjExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 Jul 3, 2026

Choose a reason for hiding this comment

Uh oh!

ahmedGaber93 commented Jul 3, 2026

Uh oh!

ahmedGaber93 commented Jul 3, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 3, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mukhrr commented Jul 3, 2026

Uh oh!

ahmedGaber93 commented Jul 3, 2026

Tests

QA steps

Uh oh!

mukhrr commented Jul 3, 2026

Tests

QA steps

Uh oh!

mukhrr commented Jul 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

github-actions Bot commented Jul 6, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

MelvinBot commented Jul 6, 2026

Uh oh!

OSBotify commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mukhrr commented Jul 1, 2026 •

edited

Loading

codecov Bot commented Jul 3, 2026 •

edited by github-actions Bot

Loading