Skip to content

[No QA] Docs updates for E/A#90791 document bank-account search filter operator#94957

Open
MelvinBot wants to merge 2 commits into
mainfrom
docs-bank-account-search-filter
Open

[No QA] Docs updates for E/A#90791 document bank-account search filter operator#94957
MelvinBot wants to merge 2 commits into
mainfrom
docs-bank-account-search-filter

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Why

Expensify/App#90791 adds a new Bank account advanced filter (operator bank-account:) on the expense Search page. It lets users with multiple settlement bank accounts scope expense results to the bank account they were reimbursed from.

The help article Use Search Operators to Filter and Analyze exhaustively lists every expense search operator, so this new operator should be documented there to keep the reference complete.

What changed

  • Added bank-account: to the How to filter expenses using search operators list, describing that it scopes expenses to the settlement bank account they were reimbursed from, that suggestions appear after the colon (shown as bank name + last four digits, e.g. Chase xx1234), and that it's available only when the user has at least one bank account.
  • Added bank account filter to the article keywords for retrieval.

Verification against the live behavior / UI

  • Operator syntax bank-account: confirmed in CONST.SEARCH.SYNTAX_FILTER_KEYS.BANK_ACCOUNT.
  • Advanced-filter row label is Bank account (common.bankAccount).
  • Picker/chip/autocomplete label format ${bankName} xx${last4} confirmed in getBankAccountSearchLabel.
  • Filter is gated to the expense Search type and only renders when the user has at least one filterable bank account (isFilterableBankAccount).

Authoring was checked against docs/HELPSITE_NAMING_CONVENTIONS.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/TEMPLATE.md — the change is a single list addition within the existing single-workflow article, so headings and structure are unchanged.


@allgandalf, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Gandalf <allgandalf@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 30, 2026
@stephanieelliott
stephanieelliott marked this pull request as ready for review July 6, 2026 16:41
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 6, 2026 16:41
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes a small, well-targeted addition to Use-Search-Operators-to-Filter-and-Analyze.md, documenting the new bank-account: expense search operator introduced in E/A#90791. It adds one bullet to the existing operator list and appends bank account filter to the article keywords. No structural changes were made, which is appropriate for a single list addition within an existing single-workflow article.

Scores Summary

  • Readability: 9/10 - The new bullet is clear, concise, and follows the exact format of the surrounding operator list (backtick-wrapped operator, en-dash, description, example). The example Chase xx1234 is concrete and helpful.
  • AI Readiness: 9/10 - Adding bank account filter to keywords improves retrieval for real search intent. The description uses full, natural phrasing and the UI-exact operator syntax. internalScope is present and unchanged. No new headings were needed, so the heading hierarchy remains compliant.
  • Style Compliance: 9/10 - Uses the exact operator syntax (bank-account:) verified against CONST.SEARCH.SYNTAX_FILTER_KEYS.BANK_ACCOUNT, and the label format bankName xx last4 matches getBankAccountSearchLabel. Consistent with naming and authoring conventions. No prohibited or vague navigation language introduced.

Key Findings

  • The addition matches the established list pattern precisely (operator, en-dash separator, description, inline example) for good consistency.
  • Keyword addition is scoped and relevant, aiding semantic retrieval without keyword stuffing.
  • Minor nit: the advanced-filter UI row is labeled Bank account per the PR description; the article describes the operator but does not reference that exact bold UI label. Since this section documents operator syntax (not UI navigation), this is acceptable and not a blocker.
  • The change stays strictly within the single-workflow scope of the article, with no scope creep or extra cross-links.

Recommendations

  • No blocking changes required. The addition is compliant and ready.
  • Optional: consider mirroring the fuller example style used by some other entries if a sample query would help, but the current example is sufficient.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md - Approved. One operator bullet and one keyword added; format, terminology, and metadata all compliant.

Note: This is a summary review. The change is small enough that no separate inline comments were necessary.

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#90791 document bank-account search filter operator [No QA] Docs updates for E/A#90791 document bank-account search filter operator Jul 6, 2026
@stephanieelliott
stephanieelliott requested a review from a team July 6, 2026 16:57
@melvin-bot

melvin-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot
melvin-bot Bot requested review from greg-schroeder and removed request for a team July 6, 2026 16:57
@melvin-bot

melvin-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott

Copy link
Copy Markdown
Contributor

Little bump @greg-schroeder

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://7d2e4ffc.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants