Skip the Skia web chart when a WebGL2 context can't be created by wildan-m · Pull Request #94937 · Expensify/App

wildan-m · 2026-06-30T07:24:47Z

Explanation of Change

On web, an uncaught failed to create webgl context: err 0 is reported to Sentry (APP-7MV) — 527 users and 6,337 events on /home. Charts render with Skia (CanvasKit), which requests a WebGL2 context and never falls back to WebGL1. When that context can't be created (hardware acceleration off, GPU blocklisted, or the per-page context limit exhausted), CanvasKit throws from its async draw loop — on a requestAnimationFrame/setTimeout callback that no try/catch or error boundary can catch.

The shared chart wrapper already shows an "Unable to display chart" empty state when its WebGL probe fails, but the probe accepted a WebGL1 context (which CanvasKit won't use) and treated a missing context as supported, so this case slipped through. This makes the probe require WebGL2 the way CanvasKit does; the shader-precision check and capable clients are unchanged.

Fixed Issues

$ #93834
PROPOSAL: #93834 (comment)

Tests

The Sentry crash only reproduces on clients that can't create a WebGL2 rendering context (hardware acceleration disabled, GPU blocklisted, or the per-page context limit exhausted), so that condition is simulated from the console.

Go to Search → Spend and open the Spend over time insight (a Skia line chart). Verify the chart renders normally.
Open Top categories and Top merchants. Verify those Skia charts render normally too (regression check on the shared wrapper).

Go back to Spend over time, then simulate a client that can't create a WebGL2 context — open the browser console and run:

// Fail webgl2 context creation the way an incapable/blocked GPU does. webgl1 is left working on
// purpose: CanvasKit still requests webgl2, so this is the exact "failed to create webgl context" case.
const original = HTMLCanvasElement.prototype.getContext;
HTMLCanvasElement.prototype.getContext = function (type, ...args) {
    return type === 'webgl2' ? null : original.call(this, type, ...args);
};
// The probe reuses one context across mounts, so mark existing contexts lost to force a fresh probe.
window.WebGL2RenderingContext?.prototype && (WebGL2RenderingContext.prototype.isContextLost = () => true);
window.WebGLRenderingContext?.prototype && (WebGLRenderingContext.prototype.isContextLost = () => true);

Do not reload the page — a full reload clears this override. The probe runs on each chart mount, so trigger a fresh mount with client-side navigation instead.

Switch between the nearby insight tabs — e.g. Top categories and Top merchants. Each switch re-mounts the chart (the probe runs per mount) with the override still active.
Verify the chart area shows the "Unable to display chart" empty state and the page does not crash — no failed to create webgl context: err 0 (or any other uncaught error) appears in the console. (Before this change, the same step throws that error from CanvasKit's asynchronous draw loop.)
Reload the page to clear the override, reopen any insight chart, and verify it renders normally again — confirming clients that can create a WebGL2 context are unaffected.

Platform scope: Steps 3–5 simulate the condition through the browser console, so they apply to MacOS: Chrome/Safari (desktop). On the other platforms the override can't be injected on-device, so just confirm there's no regression — the Spend over time, Top categories, and Top merchants charts still render normally:

mWeb (Android Chrome / iOS Safari): the fix is active here too (mWeb uses the same web chart wrapper); the override can only be injected via remote debugging.
iOS / Android Native: not affected — native charts render their *ChartContent directly and never touch SkiaWebChart/CanvasKit.
Verify that no errors appear in the JS console

Offline tests

This change does not affect offline behavior — the WebGL2 capability check and the chart rendering behave identically online and offline.

QA Steps

This change only hardens the WebGL-capability check that gates the web charts; the crash condition is environmental and can't be reliably forced on staging. Just confirm there's no regression around the charts on a WebGL-capable client:

Go to Search → Spend → Insights and open Spend over time, Top categories, and Top merchants.
Verify each chart renders normally — no "Unable to display chart" empty state, and no errors in the console.

The definitive result is only observable in production: once this deploys, the APP-7MV Sentry issue should stop receiving new failed to create webgl context events.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

MacOS: Chrome / Safari

Kapture.2026-07-06.at.09.05.58.mp4

Android: mWeb Chrome

Kapture.2026-07-06.at.09.24.20.mp4

Android: Native

Kapture.2026-07-06.at.09.16.40.mp4

iOS: Native

Kapture.2026-07-06.at.09.11.01.mp4

iOS: mWeb Safari

Kapture.2026-07-06.at.09.09.28.mp4

…ble CanvasKit crash

…ebgl-precheck

…ebgl-precheck # Conflicts: # src/components/HTMLEngineProvider/HTMLRenderers/VictoryChartRenderer/index.tsx

CanvasKit requests a webgl2 context whenever the WebGL2 API exists and never falls back to webgl1, throwing an uncatchable "failed to create webgl context" when it can't create one. Make the support probe request webgl2 the same way and treat an uncreatable context as unsupported, so SkiaWebChart shows its empty state instead of crashing. Removes the earlier standalone precheck it supersedes.

…ebgl-precheck

melvin-bot · 2026-07-06T02:29:48Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-07-06T02:29:52Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

truph01 · 2026-07-06T08:45:47Z

@codex review

chatgpt-codex-connector · 2026-07-06T08:51:11Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: fd1576b849

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

mountiny · 2026-07-06T15:00:48Z

@truph01 any ETA? thanks

joekaufmanexpensify · 2026-07-06T21:19:42Z

No product review needed.

truph01 · 2026-07-09T04:47:34Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-09.at.11.39.37.mov

OSBotify · 2026-07-09T11:48:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-09T11:51:02Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-09T11:58:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94937.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-b53bea4183d-3ded924-a56c26701195342e0e61e94d956f8ac368d716fb/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-b53bea4-3ded924-9c495fc0b7074c260afefc02da97a544a68adc99/index.html

Web 🕸️
https://94937.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-10T16:18:17Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.33-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-07-10T16:21:13Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site articles under docs/articles, and no updates are needed.

Why: This is an internal crash-prevention fix. It hardens the WebGL2 capability probe in isSkiaWebSupported.ts so that when a WebGL2 context can't be created, the chart shows the already-existing "Unable to display chart" empty state instead of throwing failed to create webgl context from CanvasKit's async draw loop.

There's no new feature, no changed workflow, no new/renamed setting, tab, or button, and no change to any documented user-facing behavior. The Insights help articles (e.g. How-to-Use-Insights-in-Expensify.md, View-the-Top-Categories-report.md, View-the-Top-Merchants-report.md) describe how to use Insights and their charts — they do not document rendering internals or error/empty states, so nothing in them becomes inaccurate as a result of this change.

Since no changes are required, I did not create a draft docs PR.

@wildan-m, if you believe a specific help article should be updated as a result of this change, let me know which one and I'll draft the update.

wildan-m added 4 commits June 18, 2026 00:30

Skip Skia chart on web when WebGL2 is unavailable to prevent uncatcha…

5212662

…ble CanvasKit crash

Merge remote-tracking branch 'upstream/main' into wildan/93834-skia-w…

1fd50b4

…ebgl-precheck

Trim WebGL precheck comments to focus on the why

eadf8b3

Add unit tests for isWebGLAvailable

fb667cf

melvin-bot Bot assigned wildan-m Jun 30, 2026

wildan-m added 3 commits July 5, 2026 03:17

Merge remote-tracking branch 'upstream/main' into wildan/93834-skia-w…

12fb5e9

…ebgl-precheck # Conflicts: # src/components/HTMLEngineProvider/HTMLRenderers/VictoryChartRenderer/index.tsx

Merge remote-tracking branch 'upstream/main' into wildan/93834-skia-w…

fd1576b

…ebgl-precheck

wildan-m marked this pull request as ready for review July 6, 2026 02:29

wildan-m requested review from a team as code owners July 6, 2026 02:29

melvin-bot Bot requested review from a team, joekaufmanexpensify and truph01 and removed request for a team July 6, 2026 02:29

melvin-bot Bot requested review from mountiny and removed request for a team July 6, 2026 02:29

wildan-m mentioned this pull request Jul 6, 2026

[$250] [Sentry: APP-7MV] Web WebGL context creation failure on /home #93834

Open

joekaufmanexpensify removed their request for review July 6, 2026 21:19

truph01 approved these changes Jul 9, 2026

View reviewed changes

mountiny approved these changes Jul 9, 2026

View reviewed changes

mountiny merged commit b53bea4 into Expensify:main Jul 9, 2026
41 of 42 checks passed

OSBotify mentioned this pull request Jul 10, 2026

Deploy Checklist: New Expensify 2026-07-10 #95814

Open

74 tasks

Uh oh!

Conversation

wildan-m commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 6, 2026

Uh oh!

melvin-bot Bot commented Jul 6, 2026

Uh oh!

truph01 commented Jul 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 6, 2026

Uh oh!

mountiny commented Jul 6, 2026

Uh oh!

joekaufmanexpensify commented Jul 6, 2026

Uh oh!

truph01 commented Jul 9, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

OSBotify commented Jul 10, 2026

Uh oh!

MelvinBot commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wildan-m commented Jun 30, 2026 •

edited

Loading