refactor: add dedicated ExpenseReportSearchView by BartekObudzinski · Pull Request #94822 · Expensify/App

BartekObudzinski · 2026-06-29T10:51:53Z

Explanation of Change

This adds a dedicated ExpenseReportSearchView for the expense-report search type (the report view, no group-by), composing the shared useSearchListViewState hook and SearchListViewLayout chrome over BaseSearchList (the same pattern as ExpenseFlatSearchView). The router now dispatches the expense-report type to it instead of the legacy SearchList shell.

Reports render ExpenseReportListItem rows. Selection is tracked at the child-transaction level (plus empty reports), so the selection counts flatten each report's transactions rather than counting the report rows. Report rows do not animate their exit (only grouped expenses do).

Fixed Issues

$ #95033

Tests

Open the Search tab and run a search that returns expense reports (the Reports type, no group-by).
Verify the report rows render the same as before.
Click a row and verify it opens the report as before.
Select a few transactions across different reports and verify the selected count and the select-all state are correct (the count reflects transactions, not report rows).
Long press a report row and verify it behaves the same as before.
Switch to another search type (expenses, chats) and back, and verify each list still renders correctly.

Verify that no errors appear in the JS console

Offline tests

Go offline.
Open the report search and verify the list still renders and rows remain tappable.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-07-01.at.11.49.57.mov

Android: mWeb Chrome

iOS: Native

flow-1-chat.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-01.at.10.59.50.mov

…rt-view # Conflicts: # src/components/Search/index.tsx

codecov · 2026-07-01T06:31:31Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/ChatSearchView.tsx	`100.00% <ø> (ø)`
src/components/Search/ExpenseGroupedSearchView.tsx	`61.11% <ø> (-0.43%)`	⬇️
src/components/Search/ExpenseReportSearchView.tsx	`100.00% <100.00%> (ø)`
src/components/Search/index.tsx	`0.72% <0.00%> (-0.01%)`	⬇️
... and 10 files with indirect coverage changes

…type

BartekObudzinski · 2026-07-01T12:11:00Z

@codex review

melvin-bot · 2026-07-01T12:11:01Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-07-01T12:11:06Z

@mountiny Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-07-01T12:16:16Z

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: b574590d41

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

MelvinBot · 2026-07-01T13:54:54Z

✅ Web verification passed

Verified on the web build of this PR branch (perf/search-s6-report-view). All requested checks passed with no JS console errors.

Step	Result
Open the Search tab	✅
Run a search with the Reports type (no group-by)	✅ `POST /api/Search?` and `POST /api/OpenSearchPage?` → 200
Report rows render	✅ Report row shows Date / Status / Title / From / Total / Action columns
Clicking a row opens the report	✅ `POST /api/OpenReport?` → 200, report detail opened

Reports search results (report rows render):

After clicking a report row (report opens):

More screenshots

Reports search empty state:

Search/Spend tab with the Reports sub-tab:

Verified with a $10.00 test expense on a fresh account. The Reports (report view) list rendered ExpenseReportListItem rows as expected and the row remained tappable, opening the report detail.

JmillsExpensify

No product review required.

daledah · 2026-07-01T15:59:41Z

+        );
+    } else if (isExpenseReportType) {
+        searchListContent = (
+            <ExpenseReportSearchView


Nit: The ExpenseReportSearchView and ExpenseFlatSearchView invocations share 16 of 18 identical prop assignments. I think we should consider extracting the common props into a shared object and spreading it onto each view.

@VickyStash @TMisiukiewicz Yeah maybe something to follow up on

@mountiny @BartekObudzinski should be back on Monday and can work on this follow-up

Applied in clean up pr #95370

daledah · 2026-07-01T15:59:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-01.at.23.25.47.mov

daledah

There's only one minor comment remaining. Other than that, the changes LGTM.

BartekObudzinski · 2026-07-01T18:53:32Z

OOO until next week 👋 If anything comes up, I've asked the callstack team to keep an eye on things. Thanks!

mountiny · 2026-07-02T11:40:44Z

+
+ExpenseReportSearchView.displayName = 'ExpenseReportSearchView';


Suggested change

ExpenseReportSearchView.displayName = 'ExpenseReportSearchView';

Done in 5d274ee

# Conflicts: # src/components/Search/index.tsx

mountiny · 2026-07-02T13:09:21Z

+        );
+    } else if (isExpenseReportType) {
+        searchListContent = (
+            <ExpenseReportSearchView


@VickyStash @TMisiukiewicz Yeah maybe something to follow up on

OSBotify · 2026-07-02T13:16:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-07-02T13:23:54Z

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-07-02T13:29:19Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #94822.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-e27957884d0-78d7f86-90a8c9c08ba171682f417fae67db5761f0827732/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-e279578-78d7f86-4993c0a032ed91df330562d1246b27d3fa52208b/index.html

Web 🕸️
https://94822.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-07-03T16:43:51Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.27-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-07-03T16:45:35Z

🤖 Help site review: no docs changes required

I reviewed the changes in this PR against Expensify's help site content under App/docs/articles, applying HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

Conclusion: No help site updates are needed, so I did not create a draft docs PR.

Why: This is a purely internal refactor. It adds a dedicated ExpenseReportSearchView component and rewires the Search router to dispatch the expense-report search type to it (the same pattern already used by ExpenseFlatSearchView), replacing the legacy SearchList shell.

No user-facing behavior changes — the PR's own test steps confirm rows "render the same as before", open the report "as before", and long-press "behaves the same as before".
No new or changed UI copy, labels, tab names, buttons, or feature names — the only translate reference in the diff is a Jest mock in the new test file.
Help site articles document product features and workflows; nothing user-visible changed here for those articles to reflect.

If a user-visible change to the Search experience is intended (new labels, new grouping options, changed flows), let me know and I'll scope the specific articles that would need updating.

OSBotify · 2026-07-06T15:31:45Z

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

refactor: add dedicated ExpenseReportSearchView

9ed038e

melvin-bot Bot assigned BartekObudzinski Jun 29, 2026

Merge remote-tracking branch 'upstream/main' into perf/search-s6-repo…

543f339

…rt-view # Conflicts: # src/components/Search/index.tsx

refactor: type isRowSelected with the canonical SelectedTransactions …

e91b54b

…type

mountiny mentioned this pull request Jul 1, 2026

[Due for payment 2026-07-13] [$125] refactor: add dedicated ExpenseReportSearchView #95033

Closed

test: rename txns fixture key to satisfy spellcheck

b574590

BartekObudzinski marked this pull request as ready for review July 1, 2026 12:10

BartekObudzinski requested review from a team as code owners July 1, 2026 12:10

melvin-bot Bot requested review from JmillsExpensify and daledah July 1, 2026 12:10

melvin-bot Bot removed the request for review from a team July 1, 2026 12:11

melvin-bot Bot requested review from a team and mountiny and removed request for a team July 1, 2026 12:11

JmillsExpensify reviewed Jul 1, 2026

View reviewed changes

daledah reviewed Jul 1, 2026

View reviewed changes

daledah approved these changes Jul 1, 2026

View reviewed changes

mountiny reviewed Jul 2, 2026

View reviewed changes

VickyStash added 2 commits July 2, 2026 14:52

Merge branch 'main' into perf/search-s6-report-view

c3d83d5

# Conflicts: # src/components/Search/index.tsx

Clean up

5d274ee

mountiny approved these changes Jul 2, 2026

View reviewed changes

mountiny merged commit e279578 into Expensify:main Jul 2, 2026
35 checks passed

OSBotify mentioned this pull request Jul 3, 2026

Deploy Checklist: New Expensify 2026-07-03 #95291

Closed

98 tasks


		ExpenseReportSearchView.displayName = 'ExpenseReportSearchView';

Uh oh!

Conversation

BartekObudzinski commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jul 1, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

BartekObudzinski commented Jul 1, 2026

Uh oh!

melvin-bot Bot commented Jul 1, 2026

Uh oh!

melvin-bot Bot commented Jul 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 1, 2026

Uh oh!

MelvinBot commented Jul 1, 2026

✅ Web verification passed

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

daledah Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

daledah commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

daledah left a comment

Choose a reason for hiding this comment

Uh oh!

BartekObudzinski commented Jul 1, 2026

Uh oh!

mountiny Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

VickyStash Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

mountiny Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

OSBotify commented Jul 3, 2026

Uh oh!

MelvinBot commented Jul 3, 2026

Uh oh!

OSBotify commented Jul 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

BartekObudzinski commented Jun 29, 2026 •

edited

Loading

codecov Bot commented Jul 1, 2026 •

edited by github-actions Bot

Loading

daledah commented Jul 1, 2026 •

edited

Loading