[No QA] Crash diagnostics: stop reporting hidden/backgrounded tabs as crashes#94818
Merged
mountiny merged 4 commits intoJul 5, 2026
Conversation
Contributor
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bca7b4f224
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
… stale hidden sample
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
Bot
requested review from
JmillsExpensify and
eh2077
and removed request for
a team
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppNA Android: mWeb ChromeNA iOS: HybridAppNA iOS: mWeb SafariNA MacOS: Chrome / SafariScreen.Recording.2026-06-29.at.11.31.10.PM.mov
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 64218c6f24
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
JmillsExpensify
left a comment
JmillsExpensify
left a comment
Contributor
There was a problem hiding this comment.
No product review required.
Contributor
|
@eh2077 can you review and test please? |
eh2077
approved these changes
Jun 30, 2026
eh2077
left a comment
eh2077
left a comment
Contributor
There was a problem hiding this comment.
tested various cases and confirmed
- the new handler syncExitStateWithVisibility records correct exit state
- the new guard skips normal hidden tabs
- new tags saved correctly to Sentry
mountiny
requested changes
Jun 30, 2026
mountiny
left a comment
mountiny
left a comment
Contributor
There was a problem hiding this comment.
Can you please resolve the pending comments
…ity in wasForeground
Contributor
Author
|
@mountiny done! |
Contributor
|
@mountiny kind bump here 🙂 |
mountiny
approved these changes
Jul 5, 2026
mountiny
left a comment
mountiny
left a comment
Contributor
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
- I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
46 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.4.28-0 🚀
|
Contributor
|
🤖 No help site changes required. I reviewed this PR against the help site articles under Why: This is a web-only, non-UI change to internal crash-reporting telemetry (
The help site documents customer-facing product behavior, and this diagnostic change is invisible to users. A search of @sosek108, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR (Note: no help site PR was created because no documentation changes are required for this internal telemetry change. If you believe a specific article should be updated, let me know which one and I'll draft the change.) |
4 tasks
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.28-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The web crash diagnostic (
crashDiagnostics) reports a session to Sentry as a "possible tab crash" when its heartbeat goes stale without a clean-exit marker (Sentry issue APP-F6C: "previous browser session ended abnormally", ~2.2k events / ~1.3k users).Investigation of production events + Fullstory replays showed the large majority are false positives — healthy tabs, not crashes:
freezeevent, which only fires for the subset of background tabs Chrome actually suspends, and never in Safari/Firefox. A tab that is merelyhidden(freeze-ineligible due to an open Pusher WebSocket / Onyx IndexedDB / Web Lock, or suspended by laptop sleep) keeps a stale heartbeat with no clean-exit marker and gets misreported.hiddenfor 15.5 h with a flat heap at ~3% of the limit; abandoned/transitiontabshiddenfor 38 h. Both reported as "crashes." Several kept heartbeating after being reported, proving they never died.This PR keys the clean-exit state off page visibility instead of
freeze, so a backgrounded tab is treated as expected-silence rather than a crash, and adds indexed Sentry tags so the genuine foreground crashes can be isolated.What changed (
src/libs/telemetry/crashDiagnostics/index.ts):cleanExitnow followsdocument.visibilityState(via a newvisibilitychangelistener and per-heartbeat update);hidden⇒ clean.freeze/pagehidestill mark clean;pageshow/resumere-sync to visibility.hiddenat its last heartbeat is dropped, never reported.reapDeadSessionsonly removes a clean record once it is also stale, so a live backgrounded tab's diagnostics aren't deleted.lastVisibility,wasForeground,heapPressure(from session peak, not last sample, since an OOM spike can occur between heartbeats),sessionDurationBucket,browserEngine. Peak heap/DOM added toextra.Fixed Issues
$ #93916
PROPOSAL:
Tests
This is web-only, non-UI telemetry. Verify via the browser DevTools and Sentry:
crashDiagnostics_session_<id>entry being written/updated.cleanExit: false.cleanExitis nowtrue(last sample'svisibilityishidden).cleanExitflips back tofalse.chrome://crash(no clean-exit marker is written). Reopen the app and confirm exactly one Sentry eventcrashDiagnostics: abnormal_exitis captured, taggedlastVisibility: visible.abnormal_exitevent on next launch.Offline tests
Same as Tests — the diagnostic uses
localStorageonly and is unaffected by network state.QA Steps
No QA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — web-only telemetry, no UI.
Android: mWeb Chrome
N/A — web-only telemetry, no UI.
iOS: Native
N/A — web-only telemetry, no UI.
iOS: mWeb Safari
N/A — web-only telemetry, no UI.
MacOS: Chrome / Safari
Nagranie.z.ekranu.2026-06-29.o.12.30.26.mov