Skip to content

[No QA] Docs updates for E/A#92289 legal name and physical address VBBA copy - #94501

Merged
bfitzexpensify merged 1 commit into
mainfrom
melvin-docs-vbba-92289
Jul 2, 2026
Merged

[No QA] Docs updates for E/A#92289 legal name and physical address VBBA copy#94501
bfitzexpensify merged 1 commit into
mainfrom
melvin-docs-vbba-92289

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Documentation updates for Expensify/App#92289, which updated the copy and validation in the verified business bank account (VBBA) setup flow:

  • Added a legal name step subheader: Please enter your full legal name as it appears on your ID.
  • Added an address step subheader and now block PO boxes and mail drops (private mailboxes / PMB) with the inline error: A physical address is required. PO boxes and mail drops are not accepted.

What changed in the docs

Updated docs/articles/new-expensify/wallet-and-payments/Connect-a-US-Business-Bank-Account.md:

  1. Corrected the company address guidance. It previously said PO Boxes or mail drops "will be flagged for review and may delay verification." With this PR, those addresses are now rejected outright at the address step — you can't continue until you enter a physical address. Updated the copy to reflect the blocking behavior.
  2. Added a new "What personal details to enter when connecting your bank account" section that tells customers to enter their full legal name exactly as it appears on their ID (the core fix from the linked issue, intended to reduce VBA verification failures from nicknames), and reiterates the physical-address requirement for the personal/home address.

Fixed Issues

Docs follow-up for #92289 (issue #92019).


@samranahm, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

…etup

Co-authored-by: Samran Ahmed <samranahm@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 24, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#92289 legal name and physical address VBBA copy [No QA] Docs updates for E/A#92289 legal name and physical address VBBA copy Jun 24, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://daa625c5.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott marked this pull request as ready for review July 1, 2026 20:29
@stephanieelliott
stephanieelliott self-requested a review as a code owner July 1, 2026 20:29
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review posted below.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes two focused changes to Connect-a-Business-Bank-Account.md: it adds a new What personal details to enter when connecting your bank account section, and it rewords the PO box guidance in the existing company address step so both address rules read consistently. The changes are small, well-targeted, and improve clarity around a common verification failure point (nicknames and PO boxes). They fit cleanly into the existing single-workflow article.

Scores Summary

  • Readability: 9/10 - New content is clear, scannable, and uses bold labels with sequential numbered steps. Sentences explain the consequence (verification failure or delay), which helps the reader.
  • AI Readiness: 8/10 - New heading is task-based (starts with "What") and searchable, uses only H2, and preserves correct hierarchy. Minor gap: the heading says "your bank account" rather than the full feature name "business bank account" used elsewhere in the article.
  • Style Compliance: 9/10 - UI labels (Legal name, Date of birth) are bolded correctly, "Social Security Number" is spelled out, and the reworded company address step now matches the new personal address wording. No prohibited navigation phrasing introduced.

Key Findings

  • Positive: The new section fills a real gap (what personal details are required before ID verification) and preemptively addresses the top verification failure causes (nicknames, PO boxes).
  • Positive: The PO box rewording is now consistent across the personal-address and company-address steps.
  • Minor: The new heading uses "your bank account" instead of the full feature name "business bank account" used throughout the rest of the article, slightly reducing terminology consistency and retrieval precision.
  • Minor: The new personal-details section has no screenshot placeholder for the input state, whereas nearby sections include them.

Recommendations

  • Align the new heading with the article feature naming: consider "What personal details to enter when connecting a business bank account".
  • Optionally add a screenshot placeholder for the personal details entry screen to match surrounding sections.
  • No blocking issues. The changes are safe to merge after the minor heading tweak.

Files Reviewed

  • docs/articles/new-expensify/wallet-and-payments/Connect-a-Business-Bank-Account.md - New personal-details section plus reworded company address step. Compliant; minor terminology alignment suggested.

Note: Detailed line-by-line feedback has been provided as inline comments.

@stephanieelliott
stephanieelliott requested a review from a team July 1, 2026 20:42
@melvin-bot

melvin-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

@melvin-bot
melvin-bot Bot requested review from bfitzexpensify and removed request for a team July 1, 2026 20:43
@melvin-bot

melvin-bot Bot commented Jul 1, 2026

Copy link
Copy Markdown

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@bfitzexpensify

bfitzexpensify commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@bfitzexpensify
bfitzexpensify merged commit 1560443 into main Jul 2, 2026
20 checks passed
@bfitzexpensify
bfitzexpensify deleted the melvin-docs-vbba-92289 branch July 2, 2026 10:58
@OSBotify

OSBotify commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.4.27-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants