Skip to content

add initial migrations#94474

Draft
collectioneur wants to merge 1 commit into
Expensify:mainfrom
software-mansion-labs:collectioneur/transition-tracker-left-usages-part-1
Draft

add initial migrations#94474
collectioneur wants to merge 1 commit into
Expensify:mainfrom
software-mansion-labs:collectioneur/transition-tracker-left-usages-part-1

Conversation

@collectioneur

@collectioneur collectioneur commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

# File Line Code / usage Why it was added PR that first introduced it
13 src/libs/Navigation/helpers/cleanupAfterExpenseCreate.ts ✅ can be tested 17 InteractionManager.runAfterInteractions(() => removeDraftTransactionsByIDs(draftTransactionIDs)); Defers removal of draft transactions past the modal-dismiss animation so cleanup doesn't block the JS thread / cause jank during post-submit navigation. #88055 — refactor: Remove shouldHandleNavigation from requestMoney and trackExpense
14 src/libs/NavigationFocusReturn.ts ✅ can be tested 322 imHandle = InteractionManager.runAfterInteractions(() => { Defers restoring keyboard focus to the triggering element past the navigation transition so React Navigation's focus work and useAutoFocusInput settle first. #87852 — fix: Keyboard Navigation: The focus is lost and does not return to triggering element
15 src/libs/actions/replaceOptimisticReportWithActualReport.ts 86 InteractionManager.runAfterInteractions(() => { Defers clearing the optimistic report and re-routing to the preexisting report until after interactions, avoiding navigation jank when the API returns a preexistingReportID. #70240 — Auto reporting: backward compatibility
16 src/pages/DynamicReportDetailsPage.tsx ✅ can be tested 1088 InteractionManager.runAfterInteractions(() => { Delays the transaction deletion until the RHP close animation finishes, preventing a brief "Not Found" flash inside the animating-out panel. #83613 — Fix 'Not Found' page flash after deleting expense
17 src/pages/Search/SearchTransactionsChangeReport.tsx ✅ can be tested 247 InteractionManager.runAfterInteractions(() => { Defers clearing selected transactions until after goBack navigation/animation, so the not-found page isn't briefly shown on report change from the search view. #69678 — fix: do not show notFound page on report change from searchView
19 src/pages/inbox/ReportFetchHandler.tsx 326 interactionTask = InteractionManager.runAfterInteractions(() => { Defers subscribing to report-leaving Pusher events past the chat-switch interaction/animation to improve chat switch performance. #38255 — perf: improve chat switch performance - fixed (originally #32336, reverted, reapplied here)
20 src/pages/inbox/report/useReportActionsNewActionLiveTail.ts 79 InteractionManager.runAfterInteractions(() => { Defers scrolling the list to the bottom on a new action past interactions so the scroll doesn't fight the content-position/animation work (maintain visible content position). #32098 — (Comment linking: step 2) WEB maintain visible content position
21 src/pages/iou/request/step/IOURequestStepDistanceOdometer.tsx 521 InteractionManager.runAfterInteractions(() => { On cancelling the discard-changes confirmation, defers re-focusing the last focused input until after the modal dismiss animation, so focus/keyboard returns cleanly. #87269 — [Odometer] Improvement to DiscardChangesConfirmation usage
22 src/pages/iou/request/step/IOURequestStepReport/hooks/useReportSelectionActions.ts 178 InteractionManager.runAfterInteractions(() => { Defers the report-selection Onyx writes (setTransactionReport/changeTransactionsReport) until after the back-navigation interaction, so the screen pops smoothly. #67048 — Feat: Add ability to unreport transactions v3
23 src/pages/iou/request/step/IOURequestStepReport/hooks/useReportSelectionActions.ts 218 InteractionManager.runAfterInteractions(() => { Defers the changeTransactionsReport (unreport) Onyx write until after the RHP dismiss finishes, so the panel closes cleanly instead of briefly showing a "not here" page. #67925 — Expense - RHP shows not here page when it is dismissing after unreporting expense
24 src/pages/settings/Security/MergeAccounts/MergeResultPage.tsx 200 InteractionManager.runAfterInteractions(() => { After a successful account merge, defers removeScreenFromNavigationState until the modal/navigation transition finishes, avoiding mid-animation navigation-state mutation. #60751 — [Merge Account] Remove the initial route from state after successful merge
25 src/pages/settings/Security/TwoFactorAuth/ReplaceDeviceVerifyNewPage.tsx 60 InteractionManager.runAfterInteractions(() => { On the 2FA replace-device verify step, defers scrolling the ScrollView to its end until interactions/keyboard animation settle so the input scrolls into view smoothly. #79266 — Create a flow to replace the user's two-factor device (reverted #85001, re-landed #85134)
26 src/pages/signin/LoginForm/BaseLoginForm.tsx 228 InteractionManager.runAfterInteractions(() => { On mobile WebKit the keyboard resizes/scrolls the viewport incorrectly; defers scrollIntoView on the submit container until after interactions to correct scroll once the keyboard animation completes. #42603 — handle login scroll on virtual viewport
27 src/pages/workspace/workflows/WorkspaceWorkflowsPage.tsx 195 InteractionManager.runAfterInteractions(() => { Defers the initial fetchData call on mount until after interactions to avoid the approver field flickering / not-found page flashing while the page transition is still in progress. #52163 — fix: Not found page appear briefly after updating the first approver

Fixed Issues

$ #71913
$ #83071

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant