add initial migrations#94474
Draft
collectioneur wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
InteractionManager.runAfterInteractions(() => removeDraftTransactionsByIDs(draftTransactionIDs));imHandle = InteractionManager.runAfterInteractions(() => {useAutoFocusInputsettle first.InteractionManager.runAfterInteractions(() => {preexistingReportID.InteractionManager.runAfterInteractions(() => {InteractionManager.runAfterInteractions(() => {goBacknavigation/animation, so the not-found page isn't briefly shown on report change from the search view.interactionTask = InteractionManager.runAfterInteractions(() => {InteractionManager.runAfterInteractions(() => {InteractionManager.runAfterInteractions(() => {InteractionManager.runAfterInteractions(() => {setTransactionReport/changeTransactionsReport) until after the back-navigation interaction, so the screen pops smoothly.InteractionManager.runAfterInteractions(() => {changeTransactionsReport(unreport) Onyx write until after the RHP dismiss finishes, so the panel closes cleanly instead of briefly showing a "not here" page.InteractionManager.runAfterInteractions(() => {removeScreenFromNavigationStateuntil the modal/navigation transition finishes, avoiding mid-animation navigation-state mutation.InteractionManager.runAfterInteractions(() => {InteractionManager.runAfterInteractions(() => {scrollIntoViewon the submit container until after interactions to correct scroll once the keyboard animation completes.InteractionManager.runAfterInteractions(() => {fetchDatacall on mount until after interactions to avoid the approver field flickering / not-found page flashing while the page transition is still in progress.Fixed Issues
$ #71913
$ #83071
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari