Skip to content

[No QA] Docs updates for E/A#86932 disabled category and tag expense alerts#93865

Merged
muttmuure merged 3 commits into
mainfrom
docs-86932-disabled-category-tag-alerts
Jul 2, 2026
Merged

[No QA] Docs updates for E/A#86932 disabled category and tag expense alerts#93865
muttmuure merged 3 commits into
mainfrom
docs-86932-disabled-category-tag-alerts

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Follow-up help site updates for the violation behavior fixed in #86932.

That PR adds new user-facing alerts when categories or tags are disabled on a workspace while an expense still uses them — a "Category no longer valid" / "Tag no longer valid" violation, plus a Category disabled / Tag disabled alert offering Delete category / Delete tag or Cancel. This mirrors the existing tax behavior already documented in Track Taxes.

This PR adds parallel FAQ entries so the category and tag articles document the same scenario.

  • Create Expense Categories — new FAQ: "What happens to an expense if its category is disabled on the workspace?"
  • Create and Manage Expense Tags — new FAQ: "What happens to an expense if its tag is disabled on the workspace?"

Related

@mukhrr, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Add FAQ entries describing the "Category no longer valid" / "Tag no longer
valid" violation and the disabled-feature alert (Delete category/tag or
Cancel), mirroring the existing tax behavior in Track-Taxes.

Co-authored-by: Mukhriddin Shakhriyorov <mukhrr@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 17, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#86932 disabled category and tag expense alerts [No QA] Docs updates for E/A#86932 disabled category and tag expense alerts Jun 17, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott self-assigned this Jun 19, 2026
@stephanieelliott stephanieelliott marked this pull request as ready for review June 19, 2026 21:53
@stephanieelliott stephanieelliott self-requested a review as a code owner June 19, 2026 21:53
Comment thread docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Create-expense-categories.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Create-expense-categories.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR adds two parallel FAQ entries documenting what happens to an expense when its category or tag is disabled on the workspace, mirroring existing tax behavior. The changes are scoped, consistent, and slot cleanly into the existing FAQ sections of both articles. This review covers only the added lines in the diff.

Scores Summary

  • Readability: 9/10 - Clear, concise, well-structured. Bulleted choices and a logical resolution flow make the steps easy to scan.
  • AI Readiness: 8/10 - FAQ headings are question-based and search-aligned (the FAQ heading is exempt from task-based rules). Full feature context is present. No metadata changes were needed since these are additive FAQ entries.
  • Style Compliance: 8/10 - UI elements (Tag, Category, Delete tag, Delete category, Cancel) are correctly bolded and in Sentence case. Minor: violation strings are wrapped in straight quotes (see findings).

Key Findings

  • Both entries follow an identical, parallel structure across the tag and category articles, which is excellent for consistency and retrieval.
  • Button and field names match the source PR behavior (auto select some values of transaction after deletion one of last 2 elements #86932) and are correctly bold-formatted per the Button Naming Standards.
  • The new headings are proper question-form FAQ entries placed under the existing FAQ heading - no heading-hierarchy violations.
  • Minor: The violation labels Tag no longer valid and Category no longer valid use straight double quotes. The naming conventions discourage wrapping UI labels in quotation marks; consider treating these as UI strings for consistency.
  • Minor: The sentence about enabling tags/categories on the workspace to edit directly could optionally cross-link to the enable/disable instructions already in the same article.

Recommendations

  • Optional: Reconsider the straight-quote treatment of the violation message strings to align with UI-label conventions.
  • Optional: Consider a relative cross-link from the enable-tags/categories sentence to the existing enable/disable section.
  • No blocking issues - the additions are accurate, consistent, and compliant.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md - New FAQ entry, compliant.
  • docs/articles/new-expensify/workspaces/Create-expense-categories.md - New FAQ entry, compliant.

Note: Detailed line-by-line feedback has been provided as inline comments.

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott requested a review from a team June 20, 2026 04:11
@melvin-bot

melvin-bot Bot commented Jun 20, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @muttmuure

@melvin-bot melvin-bot Bot requested review from muttmuure and removed request for a team June 20, 2026 04:12
@melvin-bot

melvin-bot Bot commented Jun 20, 2026

Copy link
Copy Markdown

@muttmuure Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://50301987.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott

Copy link
Copy Markdown
Contributor

all relevant bot comments addressed.

@muttmuure muttmuure merged commit 1ae4252 into main Jul 2, 2026
15 checks passed
@muttmuure muttmuure deleted the docs-86932-disabled-category-tag-alerts branch July 2, 2026 18:58
@OSBotify

OSBotify commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/muttmuure in version: 9.4.27-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/grgia in version: 9.4.27-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants