Skip to content

Docs updates for E/A#91983 Add Review expenses item to For you#93480

Merged
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-review-x-expenses
Jun 19, 2026
Merged

Docs updates for E/A#91983 Add Review expenses item to For you#93480
stephanieelliott merged 1 commit into
mainfrom
melvin-docs-review-x-expenses

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

E/A#91983 adds a new Review X expenses item to Home's For you section. It surfaces policy-flagged expenses on a submitter's draft reports (aggregated across workspaces) and routes them to the flagged expense so they can resolve the rule violation before submitting.

This updates the Understanding the For you Section article to document the new item:

  • Added Review to the list of items that can appear in For you.
  • Listed Review under the items a Submitter may see.
  • Updated where each item takes you, noting Review opens the first flagged expense so the violation can be resolved.
  • Added review expenses and flagged expenses to the article keywords.

Related


@adamgrzybowski, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Adam Grzybowski  <adamgrzybowski@users.noreply.github.com>

@adamgrzybowski adamgrzybowski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@stephanieelliott stephanieelliott marked this pull request as ready for review June 19, 2026 21:42
@stephanieelliott stephanieelliott self-requested a review as a code owner June 19, 2026 21:42
@@ -64,9 +66,10 @@ The items you see in **For you** depend on what actions you’re responsible for

## Where each For you item takes you

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vague navigation phrasing: "taken directly to where you can take action" violates the Deterministic Writing Rule and Prohibited Language section in HELPSITE_NAMING_CONVENTIONS.md (avoid phrases like "Navigate to the area"). The original named the Spend destination explicitly. Since destinations now differ by item, state them concretely instead of generalizing — e.g. "taken directly to the report, expense, or view where that action is completed."

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This is a small, well-scoped update to the Understanding the For you Section article that documents a new Review item in Home For you section. The five changed lines integrate cleanly with the article existing structure, formatting, and tone. The changes are accurate and consistent with surrounding content.

Scores Summary

  • Readability: 9/10 - New bullets are concise, parallel with existing items, and clearly explain what Review does and where it routes.
  • AI Readiness: 9/10 - Keywords expanded with realistic search phrases (review expenses, flagged expenses); content uses the full feature name and aligns with the existing internalScope. No new headings introduced.
  • Style Compliance: 9/10 - The UI label Review is bolded consistently with Submit, Approve, Pay, Export, and Fix, matching the Button and Section naming standards.

Key Findings

  • The new Review bullet in the items list, the Submitters list, and the routing list are all added in parallel form with existing entries.
  • Correctness improvement: the routing sentence changed from taken directly to Spend (filtered) to taken directly to where you can take action, which is accurate now that Review routes to an individual flagged expense rather than to Spend.
  • Keywords reflect real search intent for the new behavior.
  • Minor: workspace rules uses lowercase workspace as a generic possessive. Naming conventions treat Workspace as a defined term; consider capitalizing for consistency. Not blocking.

Recommendations

  • Optional: align workspace rules capitalization with the Workspace term used elsewhere (e.g., Workspace Admins).
  • No structural or compliance changes required. The diff is publish-ready.

Files Reviewed

  • docs/articles/new-expensify/getting-started/Understanding-the-For-you-Section.md - Approved. Clean, accurate, on-convention addition of the Review item.

Note: This focused PR did not warrant inline comments; all feedback is captured above.

@stephanieelliott stephanieelliott merged commit 18789f2 into main Jun 19, 2026
17 checks passed
@stephanieelliott stephanieelliott deleted the melvin-docs-review-x-expenses branch June 19, 2026 21:52
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.17-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@m-natarajan

Copy link
Copy Markdown

@stephanieelliott @adamgrzybowski NO QA steps, OK to checkoff this one?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

1 similar comment
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants