Skip to content

[POC] Remove waitForCollectionCallback from Onyx#93436

Draft
fabioh8010 wants to merge 23 commits into
Expensify:mainfrom
callstack-internal:feature/onyx-store-pr-1
Draft

[POC] Remove waitForCollectionCallback from Onyx#93436
fabioh8010 wants to merge 23 commits into
Expensify:mainfrom
callstack-internal:feature/onyx-store-pr-1

Conversation

@fabioh8010

@fabioh8010 fabioh8010 commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #94331
PROPOSAL:

Tests

We are basically just removing waitForCollectionCallback usage here, functionality should stay the same so we can test only the tab sync issues that are present on main and are being fixed here. Tests are web-only.

  1. With an account logged in, duplicate the current tab so you have 2 tabs with same account for testing.
  2. In Tab A, pin one report from LHN. Go to Tab B and assert the same report was pinned on.
  3. Choose one report in the middle of LHN list, select and draft a message. Go to Tab B and assert the same report has the draft message and the LHN was correctly re-ordered to show the report closer to the top of the list.
  4. Mark one report as unread. Go to Tab B and assert the same report is marked as unread and the Chrome tab displays the notification badge.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-26.at.14.09.06.mov
Screen.Recording.2026-06-26.at.14.12.04.mov

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@fabioh8010
Use newest Onyx changes from Onyx store-based PR 1
71eea11
@fabioh8010
Refactor collection key Onyx.connect cases
7eecb00 
(cherry picked from commit 535279b)
@fabioh8010
Remove waitForCollectionCallback usages and fix resulting type errors
6008df2 
The waitForCollectionCallback connect option no longer exists in Onyx
store-based PR 1, so remove all usages across the app. Collection-root
subscriptions now always deliver snapshots, so the now-properly-typed
snapshot callbacks no longer need the `as unknown as Record<...>` casts;
rebuild the rawID-keyed views with a plain `.replace()`.

Also fix a couple of resulting test type errors: type the collected
collection vars in ReportTest as non-undefined, and cast the resolved
value in the getOnyxValue single-key helper.
@fabioh8010 fabioh8010 force-pushed the feature/onyx-store-pr-1 branch from 04ce43b to 6008df2 Compare June 12, 2026 17:00
@codecov

codecov Bot commented Jun 12, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/libs/DistanceRequestUtils.ts 86.81% <ø> (-0.46%) ⬇️
src/libs/Fullstory/common.ts 0.00% <ø> (ø)
src/libs/Middleware/Pagination.ts 98.41% <ø> (ø)
src/libs/Notification/LocalNotification/index.ts 0.00% <ø> (ø)
src/libs/OptionsListUtils/index.ts 86.24% <ø> (ø)
src/libs/Parser.ts 93.54% <ø> (ø)
src/libs/ReportActionsUtils.ts 78.48% <ø> (ø)
src/libs/ReportTitleUtils.ts 93.10% <ø> (ø)
src/libs/ReportUtils.ts 85.76% <ø> (+0.04%) ⬆️
src/libs/UnreadIndicatorUpdater/index.ts 95.65% <ø> (ø)
... and 19 more
... and 12 files with indirect coverage changes

@fabioh8010

fabioh8010 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 40c913fd89

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@fabioh8010 fabioh8010 mentioned this pull request Jun 26, 2026
Open
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fabioh8010 fabioh8010

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@fabioh8010