fix: Long tag names don't wrap in tag selection list#93202
Conversation
melvin-bot
Bot
requested review from
JmillsExpensify and
ikevin127
and removed request for
a team
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Added design to make sure we get their review on this. Are we wrapping an unlimited number of lines? |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84b7048c43
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| style={{ | ||
| sectionTitleStyles: styles.mt5, | ||
| listItemTitleStyles, | ||
| listItemTitleStyles: styles.w100, |
There was a problem hiding this comment.
On web, this now passes only styles.w100 for tag titles, dropping the previous styles.breakAll. The new multiline flag applies styles.preWrap in BaseSelectListItem, but pre-wrap only wraps at normal break opportunities; a 255-character tag with no spaces (the exact long-name case this picker supports via API_TRANSACTION_TAG_MAX_LENGTH) remains a single unbroken line and will still overflow or be clipped instead of wrapping. Keeping a word-break style here is needed for long unspaced tag names to display fully.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
It seems like we won't have any overflowing/clipping issues for long words without spaces if we remove styles.breakAll. I tested this manually on all platforms, here are the results:
macOS:
Android native:
Android mweb:
iOS safari:
iOS native:
|
@Expensify/design On this PR, I'm confused about the title limit. I set the cap of The title limit was confirmed to be 
So I made it
with-10-limit.movWith with-15-limit.mp4but should we take these too narrow widths into account? |
|
I think 5 is fine personally. The narrow widths you are showing are extreme edge cases. Let's try 5 and see how it goes, and if we get customer feedback, we can adjust. Let's just make sure to store that 5 as a CONST somewhere so it's easy to update in the future if we need to. |
|
@Uzaifm127 Let's stick with Also do you mind manually checking this codex comment in the app to see how we should handle that potential regression with the updated styles there ?
Update: I tested ☝️ this manually and long 1-word seems to break, doesn't overflow - but you should double check just to have double confirmation ✅ |
|
@ikevin127 Made the limit to |
ikevin127
left a comment
ikevin127
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run
npm run compress-svg) - The assets load correctly across all supported platforms.
- The assets are optimized and compressed (for SVG files, run
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-06-10.at.18.42.04.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-10.at.18.40.28.mov
|
🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.4.7-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR is a purely visual rendering fix: long tag and category names now wrap across multiple lines in the selection list instead of being truncated with an ellipsis. The changes are limited to layout plumbing:
There is no new feature, setting, tab, button, workflow, or user-facing capability introduced — only how an existing label is displayed. Help articles under I searched @Uzaifm127, if you believe a help article should be updated for this change, let me know which behavior should be documented and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.4.7-4 🚀
|
7 participants
Explanation of Change
This PR is solving long tag names being truncated in the tag selector instead of wrapping.
TagPickerusesSelectionListWithSectionswithSingleSelectListItem, but it was not enabling multiline row titles. Because of that,BaseSelectListItemrendered each tag withnumberOfLines={1}, so long tag names were cut off with an ellipsis.This PR enables multiline rows in
TagPickerand uses a sharedCONST.TRANSACTION_TAG_AND_CATEGORY_PICKER_MAX_TITLE_LINESlimit for tag/category picker titles. It also forwardstitleNumberOfLinesthroughSingleSelectListItemandMultiSelectListItemtoBaseSelectListItem, so callers that pass a custom title line count actually have that value applied.This also restores the intended behavior for
CategoryPicker, which already passed a custom title line count but had that value dropped bySingleSelectListItem.Fixed Issues
$ #92789
PROPOSAL: #92789 (comment)
Tests
Precondition: A long category and a long tag must be created in the workspace (for example: 255 characters).
Offline tests
Same as Test
QA Steps
Same as Test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native.mov
Android: mWeb Chrome
android-mweb.mov
iOS: Native
ios-native.mov
iOS: mWeb Safari
ios-safari.mov
MacOS: Chrome / Safari
macOS.mov