Revert "[Payment due @marufsharifi] [No QA] Fire search requests for visible todos"#93201
Conversation
|
@marcochavezf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eff1aec37b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| fireSearches(); | ||
| }, [isFocused, isOffline, displayableCardIDsKey, applicabilityKey, suggestedSearchesVisibility]); | ||
| }, [isFocused, isOffline, displayableCardIDsKey, applicabilityKey]); |
There was a problem hiding this comment.
When a user has visible Submit/Approve/Pay/Export todos but those reports are not already hydrated locally, removing the to-do search requests leaves no replacement fetch path: useSearchPageSetup skips the Search API for to-do tabs when shouldUseLiveData is true, and SearchResultsProvider then renders from ONYXKEYS.DERIVED.TODOS, which is computed only from local report/transaction collections. In that fresh-login or cold-cache case the Home/For You counts and the to-do search tabs can stay empty until some unrelated flow loads the reports, so the effect still needs to request the visible to-do searches (or another fetch path must be added).
Useful? React with 👍 / 👎.
|
🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here. |
…-on-openapp Revert "[Payment due @marufsharifi] [No QA] Fire search requests for visible todos" (cherry picked from commit 255c129) (cherry-picked to production by luacmartins)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.3-0 🚀
Bundle Size Analysis (Sentry): |
…-on-openapp Revert "[Payment due @marufsharifi] [No QA] Fire search requests for visible todos" (cherry picked from commit 255c129) (cherry-picked to staging by Julesssss)
|
CP'd to STAGING |
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.4-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. This PR reverts Expensify/App#92299 to fix an infinite loop / elevated Search call volume. The only change is to This is an internal, behind-the-scenes performance fix:
I searched @luacmartins, please confirm you agree no help site updates are needed. If you believe a docs change is warranted, reply with |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.4.5-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀
|
6 participants
Explanation of Change
Reverts #92299 which was causing an infinite loop on Search
Fixed Issues
$ https://expensify.enterprise.slack.com/archives/C0B96MS9B8X
Tests
Verify Search call volumes go down
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari