LHN - Keep Self DM visible while distance expense loads by KJ21-ENG · Pull Request #93167 · Expensify/App

KJ21-ENG · 2026-06-10T09:47:03Z

Explanation of Change

This PR keeps an existing hidden Self DM visible in the LHN while a track-distance expense is still pending.

When trackExpense() optimistically updates a Self DM report, it now normalizes the current user's hidden participant notification preference to the report's default preference. For Self DM, that default is MUTE, matching the existing optimistic Self DM creation path. This keeps the Self DM eligible for the LHN after the user navigates away while the distance expense is still loading.

This also adds regression coverage for the hidden Self DM distance-track optimistic update.

Fixed Issues

$ #92552
PROPOSAL: #92552 (comment)

Tests

Manual verification completed for the onboarding options below; recordings uploaded in the Screenshots/Videos section.

Open the app.
Sign up with a new account and complete onboarding with each of these options:
- Track expenses for my business
- Manage my team's expenses > 11-50 employees
- Something else
Navigate to Inbox.
Create a map distance expense from the FAB and submit it to Self DM.
Before the distance expense finishes loading, navigate away from Self DM.
Verify Self DM remains visible in the LHN while the distance expense is loading.
Repeat steps 1-6 for each onboarding option listed above.

Verify that no errors appear in the JS console

Offline tests

Manual verification completed for the onboarding options below; recordings uploaded in the Screenshots/Videos section.

Open the app.
Sign up with a new account and complete onboarding with each of these options:
- Track expenses for my business
- Manage my team's expenses > 11-50 employees
- Something else
Navigate to Inbox.
Turn off the network connection or otherwise keep the track-distance request pending.
Create a map distance expense from the FAB and submit it to Self DM.
Navigate away from Self DM.
Verify Self DM remains visible in the LHN while the distance expense is pending.
Repeat steps 1-7 for each onboarding option listed above.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

android_mweb1781090220813665.mp4

iOS: Native

ios_native1781090640106857.mp4

iOS: mWeb Safari

ios_mweb1781090461770567.mp4

MacOS: Chrome / Safari

desktop_web1781090318682529.mp4

melvin-bot · 2026-06-10T11:32:22Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

JmillsExpensify

LGTM

KJ21-ENG · 2026-06-11T16:56:53Z

@sobitneupane Kind ping here. Thanks

sobitneupane · 2026-06-15T13:28:48Z

Reviewing the PR.

sobitneupane · 2026-06-16T08:08:08Z

@KJ21-ENG Looks like the issue is no longer reproducible in staging. Could you please verify on your end?

Screen.Recording.2026-06-16.at.13.50.36.mov

sobitneupane

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-16.at.14.18.36.mov

Android: mWeb Chrome

Screen.Recording.2026-06-16.at.14.30.57.mov

iOS: HybridApp

Screen.Recording.2026-06-16.at.14.47.50.mov

iOS: mWeb Safari

Screen.Recording.2026-06-16.at.15.14.23.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-16.at.14.02.06.mov

KJ21-ENG · 2026-06-16T09:33:21Z

@sobitneupane I verified on my end as well, and I agree this is no longer reproducible on staging.

I investigated what changed since this PR is not merged yet. The staging fix appears to have come from the Onyx bump in #92897, which updated react-native-onyx to 3.0.80.

The specific Onyx fix is Expensify/react-native-onyx#791. It changed OnyxSnapshotCache so cache keys include the actual Onyx key instead of only the selector/no-selector identity. That prevents report-key snapshot cache reuse/staleness, which matches the transient LHN/Self DM behavior seen in this issue.

Given that, this PR is likely redundant for the current staging regression. It can still be considered defensive hardening for the case where trackExpense() receives a Self DM with hidden/empty current-user notification preference, but I’m fine closing it if we want to treat the issue as already fixed by the Onyx bump.

Would like to here from you what should be done next.

sobitneupane · 2026-06-16T09:36:27Z

@KJ21-ENG Could you please try reproducing the issue by selecting an option other than Track expenses for my business (specifically "Something Else")?

Sign up with a new account and select "Track expenses for my business".

KJ21-ENG · 2026-06-16T09:42:52Z

@KJ21-ENG Could you please try reproducing the issue by selecting an option other than Track expenses for my business?

Sign up with a new account and select "Track expenses for my business".

@sobitneupane I tried with 'Manage my team's expenses > 11-50 employees' and i was able to reproduce the issue.👀

ezyZip.45.mp4

sobitneupane · 2026-06-16T09:52:27Z

@KJ21-ENG Could you please update the testing steps and retest the solution to ensure it still resolves the issue? I was also able to reproduce with "Something else".

KJ21-ENG · 2026-06-16T09:55:20Z

@sobitneupane Okay, I will update it and will test with all the options. Thanks!

KJ21-ENG · 2026-06-17T14:52:15Z

@sobitneupane Okay, I will update it and will test with all the options. Thanks!

@sobitneupane Tested with all other options as well, fix is working properly.

sobitneupane · 2026-06-22T16:02:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-16.at.14.18.36.mov

Android: mWeb Chrome

Screen.Recording.2026-06-16.at.14.30.57.mov

iOS: HybridApp

Screen.Recording.2026-06-16.at.14.47.50.mov

iOS: mWeb Safari

Screen.Recording.2026-06-16.at.15.14.23.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-16.at.14.02.06.mov

carlosmiceli · 2026-06-22T20:57:10Z

All yours @JmillsExpensify !

github-actions · 2026-06-22T20:59:21Z

🚧 @carlosmiceli has triggered a test Expensify/App build. You can view the workflow run here.

carlosmiceli · 2026-06-22T20:59:53Z

@JmillsExpensify crap, I merged by accident 🤦

OSBotify · 2026-06-22T21:03:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-22T21:05:20Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #93167.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-2f2d2f94438-3b458b4-ddd07088b8235aab1d4e788ebb3bbd19039ea11d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-2f2d2f9-3b458b4-3b73a1f76a70bd5ea5090be48834a4238240503a/index.html

Web 🕸️
https://93167.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-22T23:26:56Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.4.17-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-22T23:28:52Z

🤖 No help site changes required.

I reviewed the changes in this PR against the help site articles under App/docs/articles.

Why no docs update is needed:

This PR is a bug fix to internal optimistic-update logic in src/libs/actions/IOU/TrackExpense.ts (plus regression test coverage). It normalizes a hidden participant's notification preference so a Self DM stays visible in the left-hand navigation while a distance-track expense is still loading.

No new feature, UI label, tab name, button, or setting was added or renamed.
No documented user-facing workflow changed. The closest article, Track expenses, already states that a tracked expense "appears in an Expense Chat in the left-hand navigation menu" — this fix simply restores that already-documented expected behavior by preventing the chat from disappearing during a pending load.

Since this only corrects backend optimistic behavior to match what the help site already describes, no article content needs to change.

@KJ21-ENG, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

Note: no help site PR was created because no documentation changes are required. If you believe an article should be updated, reply with the specific behavior to document and I'll draft it.

OSBotify · 2026-06-23T21:59:10Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2026-06-23T23:37:40Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.17-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Fix hidden Self DM track expense visibility

10d33f5

melvin-bot Bot assigned KJ21-ENG Jun 10, 2026

Mock hybrid app module in TrackExpense test

f7bcf43

KJ21-ENG changed the title ~~[WIP] LHN - Keep Self DM visible while distance expense loads~~ LHN - Keep Self DM visible while distance expense loads Jun 10, 2026

KJ21-ENG marked this pull request as ready for review June 10, 2026 11:32

KJ21-ENG requested review from a team as code owners June 10, 2026 11:32

melvin-bot Bot requested review from JmillsExpensify and sobitneupane and removed request for a team June 10, 2026 11:32

melvin-bot Bot removed the request for review from a team June 10, 2026 11:32

KJ21-ENG mentioned this pull request Jun 10, 2026

[Due for payment 2026-06-30] [$250] LHN - Self DM disappears from LHN while distance expense is loading. #92552

Closed

7 tasks

JmillsExpensify previously approved these changes Jun 10, 2026

View reviewed changes

sobitneupane reviewed Jun 16, 2026

View reviewed changes

Strengthen hidden Self DM LHN regression coverage

bf6572d

KJ21-ENG dismissed JmillsExpensify’s stale review via bf6572d June 17, 2026 14:52

KJ21-ENG requested a review from sobitneupane June 17, 2026 15:10

sobitneupane approved these changes Jun 22, 2026

View reviewed changes

melvin-bot Bot requested a review from carlosmiceli June 22, 2026 16:02

sobitneupane approved these changes Jun 22, 2026

View reviewed changes

carlosmiceli approved these changes Jun 22, 2026

View reviewed changes

carlosmiceli merged commit 2f2d2f9 into Expensify:main Jun 22, 2026
33 of 36 checks passed

OSBotify mentioned this pull request Jun 22, 2026

Deploy Checklist: New Expensify 2026-06-22 #94222

Closed

Uh oh!

Conversation

KJ21-ENG commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 10, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

KJ21-ENG commented Jun 11, 2026

Uh oh!

sobitneupane commented Jun 15, 2026

Uh oh!

sobitneupane commented Jun 16, 2026

Uh oh!

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

Uh oh!

KJ21-ENG commented Jun 16, 2026

Uh oh!

sobitneupane commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KJ21-ENG commented Jun 16, 2026

Uh oh!

sobitneupane commented Jun 16, 2026

Uh oh!

KJ21-ENG commented Jun 16, 2026

Uh oh!

KJ21-ENG commented Jun 17, 2026

Uh oh!

sobitneupane commented Jun 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

carlosmiceli commented Jun 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

carlosmiceli commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

github-actions Bot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 22, 2026

Uh oh!

MelvinBot commented Jun 22, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

OSBotify commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

KJ21-ENG commented Jun 10, 2026 •

edited

Loading

sobitneupane commented Jun 16, 2026 •

edited

Loading

sobitneupane commented Jun 22, 2026 •

edited

Loading