[No QA] Fix ESLint failures in OnboardingPersonalTrackGoal test#93079
Merged
Conversation
Use typed goal values and a complete ResponsiveLayoutResult mock so the new UI test passes ESLint on main. Co-authored-by: Cursor <cursoragent@cursor.com>
Merged
54 tasks
neil-marcellini
approved these changes
Jun 9, 2026
Contributor
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.2-0 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.4-1 🚀
Bundle Size Analysis (Sentry): |
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixes the ESLint check failure on main caused by unsafe type assertions in the newly merged
OnboardingPersonalTrackGoalUI test.translateGoalwithValueOf<typeof CONST.ONBOARDING_PERSONAL_TRACK_GOALS>so the translation path is inferred without casting.ResponsiveLayoutResultcast with a complete mock object usingsatisfies ResponsiveLayoutResult.Fixed Issues
$
Tests
npx eslint tests/ui/OnboardingPersonalTrackGoal.tsx— passes with no errors.npm test -- tests/ui/OnboardingPersonalTrackGoal.tsx— both tests pass.Offline tests
N/A — test-only change.
QA Steps
N/A — test-only change.
Made with Cursor