[No QA] VictoryChart: strict types and parsing by s77rt · Pull Request #92960 · Expensify/App

s77rt · 2026-06-08T18:06:17Z

Explanation of Change

Currently when parsing VictoryChart nodes, some inputs are used as is and we used type assertion to pass them to the underlaying victory native component. However this is not safe as bad data types can still be passed as if it was valid and that may lead to a crash.

This PR fixes that by removing all the used type assertions and instead peform runtime type check.

Fixed Issues

$ #91776
PROPOSAL:

Tests

Open any report
Type 3 messages and note the report actions of each
Run in console

const html = `<victorychart domain="{x: [0.5, 12.5], y: [0, 2000]}" domainpadding="{x: 18, y: 0}" height="430" width="680" padding="{top: 126, bottom: 108, left: 96, right: 32}" style="{parent: { backgroundColor: '#F7F2EF', borderRadius: 16, width: '100%', maxWidth: 680}}"><victorylabel x="32" y="40" text='Monthly spend' style="{ fill: '#002E22', fontSize: 17, fontWeight: 700, fontFamily: 'Expensify Neue', }"/><victorylabel x="32" y="62" text='As of: May 6, 12:49 PM PT' style="{ fill: '#73857E', fontSize: 11, fontWeight: 400, fontFamily: 'Expensify Neue', }"/><victorybar barwidth="11" cornerradius="{top: 6, bottom: 6}" style="{data: {fill: '#1E90F2'}}" data="[ {x: 1.13, y: 1080}, {x: 2.13, y: 1225}, {x: 3.13, y: 1375}, {x: 4.13, y: 1600}, {x: 5.13, y: 1630}, {x: 6.13, y: 1725}, {x: 7.13, y: 1400}, {x: 8.13, y: 1685}, {x: 9.13, y: 1725}, {x: 10.13, y: 1800}, {x: 11.13, y: 1800}, {x: 12.13, y: 1800}, ]" labels="[ 'Jan 2025: $1,080', 'Feb 2025: $1,225', 'Mar 2025: $1,375', 'Apr 2025: $1,600', 'May 2025: $1,630', 'Jun 2025: $1,725', 'Jul 2025: $1,400', 'Aug 2025: $1,685', 'Sep 2025: $1,725', 'Oct 2025: $1,800', 'Nov 2025: $1,800', 'Dec 2025: $1,800', ]"/><victorybar barwidth="11" cornerradius="{top: 6, bottom: 6}" style="{data: {fill: '#13C96B'}}" data="[ {x: 0.87, y: 1200}, {x: 1.87, y: 1320}, {x: 2.87, y: 1570}, ]" labels="['Jan 2026: $1,200', 'Feb 2026: $1,320', 'Mar 2026: $1,570']"/><victorybar barwidth="11" cornerradius="{top: 6, bottom: 6}" style="{data: {fill: '#FF6A00'}}" data="[{x: 3.87, y: 1820}]" labels="['Apr 2026: $1,820']"/><victoryaxis tickvalues="[1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12]" tickformat="['Jan', 'Feb', 'Mar', 'Apr', 'May', 'Jun', 'Jul', 'Aug', 'Sep', 'Oct', 'Nov', 'Dec']" style="{ axis: {stroke: '#E6E1DA', strokeWidth: 1}, ticks: {stroke: 'transparent'}, tickLabels: { fill: '#73857E', fontSize: 11, fontWeight: 500, fontFamily: 'Expensify Neue', padding: 16, }, }"/><victoryaxis dependentaxis tickvalues="[0, 500, 1000, 1500, 2000]" tickformat="['$0', '$500', '$1,000', '$1,500', '$2,000']" style="{ axis: {stroke: 'transparent'}, ticks: {stroke: 'transparent'}, grid: {stroke: '#E6E1DA', strokeWidth: 1}, tickLabels: { fill: '#73857E', fontSize: 11, fontWeight: 500, fontFamily: 'Expensify Neue', padding: 28, }, }"/><victorylegend x="150" y="378" orientation="horizontal" gutter="34" symbolspacer="10" style="{ labels: { fill: '#002E22', fontSize: 13, fontWeight: 500, fontFamily: 'Expensify Neue', }, }" data="[ {name: '2026 spend', symbol: {type: 'circle', fill: '#13C96B', size: 6}}, {name: '2025 spend', symbol: {type: 'circle', fill: '#1E90F2', size: 6}}, {name: 'Last month', symbol: {type: 'circle', fill: '#FF6A00', size: 6}}, ]"/></victorychart>`;

const html2 = `<victorychart horizontal domain="{y: [0, 18000]}" domainpadding="{x: 44, y: 16}" height="464" width="680" padding="{top: 92, bottom: 84, left: 150, right: 32}" style="{ parent: { backgroundColor: '#F7F2EF', borderRadius: 16, width: '100%', maxWidth: 680, }, }" categories="{x: ['Ethan Brooks', 'Sofia Ramirez', 'Michelina Della Donna', 'Priya Patel', 'Alex Chen']}"><victorylabel x="32" y="40" text='Top employees by spend' style="{ fill: '#002E22', fontSize: 17, fontWeight: 700, fontFamily: 'Expensify Neue', }"/><victorylabel x="32" y="62" text='As of: May 6, 12:49 PM PT' style="{ fill: '#73857E', fontSize: 11, fontWeight: 400, fontFamily: 'Expensify Neue', }"/><victoryaxis tickValues="[0,1,2,3,4]" tickformat="['Ethan Brooks', 'Sofia Ramirez', 'Michelina Della Donna', 'Priya Patel', 'Alex Chen']" style="{ axis: {stroke: 'transparent'}, ticks: {stroke: 'transparent'}, grid: {stroke: 'transparent'}, tickLabels: { fill: '#73857E', fontSize: 11, fontWeight: 500, fontFamily: 'Expensify Neue', padding: 24, }, }"/><victoryaxis dependentaxis tickvalues="[0, 3000, 6000, 9000, 12000, 15000, 18000]" tickformat="['$0', '$3,000', '$6,000', '$9,000', '$12,000', '$15,000', '$18,000']" style="{ axis: {stroke: 'transparent'}, ticks: {stroke: 'transparent'}, grid: {stroke: '#E6E1DA', strokeWidth: 1}, tickLabels: { fill: '#73857E', fontSize: 11, fontWeight: 500, fontFamily: 'Expensify Neue', padding: 8, }, }"/><victorygroup horizontal offset="18"><victorybar barwidth="16" cornerradius="{top: 8, bottom: 0}" style="{data: {fill: '#13C96B'}}" data="[ {x: 'Ethan Brooks', y: 9450}, {x: 'Sofia Ramirez', y: 10500}, {x: 'Michelina Della Donna', y: 11900}, {x: 'Priya Patel', y: 13400}, {x: 'Alex Chen', y: 14300}, ]"/><victorybar barwidth="16" cornerradius="{top: 8, bottom: 0}" style="{data: {fill: '#1E90F2'}}" data="[ {x: 'Ethan Brooks', y: 8800}, {x: 'Sofia Ramirez', y: 10250}, {x: 'Michelina Della Donna', y: 11250}, {x: 'Priya Patel', y: 13900}, {x: 'Alex Chen', y: 12500}, ]"/></victorygroup><victorylegend x="250" y="416" orientation='horizontal' gutter="42" symbolspacer="10" style="{ labels: { fill: '#002E22', fontSize: 13, fontWeight: 500, fontFamily: 'Expensify Neue', }, }" data="[ {name: 'This month', symbol: {type: 'circle', fill: '#13C96B', size: 6}}, {name: 'Last month', symbol: {type: 'circle', fill: '#1E90F2', size: 6}}, ]"/></victorychart>`;

const html3 = `<victorychart width="680" height="530" domainpadding="0" style="{ parent: { backgroundColor: '#F7F2EF', borderRadius: 16, width: '100%', maxWidth: 680, }, }"><victoryaxis style="{ axis: {stroke: 'transparent'}, ticks: {stroke: 'transparent'}, grid: {stroke: 'transparent'}, tickLabels: {fill: 'transparent'}, }}"/><victoryaxis dependentaxis style="{ axis: {stroke: 'transparent'}, ticks: {stroke: 'transparent'}, grid: {stroke: 'transparent'}, tickLabels: {fill: 'transparent'}, }}"/><victorylabel x="32" y="40" text='Top categories' style="{ fill: '#002E22', fontSize: 17, fontWeight: 700, fontFamily: 'Expensify Neue' }"/><victorylabel x="32" y="62" text='As of: May 6, 12:49 PM PT' style="{ fill: '#76847E', fontSize: 11, fontWeight: 400, fontFamily: 'Expensify Neue' }"/><victorypie standalone="false" width="680" height="550" padding="{top: 0, bottom: 0, left: 0, right: 0}" innerradius="125" padangle="0.5" radius="145" labelIndicator="&lt;ShiftedLineSegment dy=&quot;0&quot; style=&quot;{ stroke: &#39;#E6E1DA&#39;, strokeWidth: 1 }&quot; /&gt;" labelindicatorinneroffset="12" labelindicatorouteroffset="24" colorscale="['#FED607', '#FF7101', '#F68DFE', '#03D47C', '#50EEF6', '#0185FF']" data="[ {x: 'Other', y: 309700}, {x: 'Postage And Delivery', y: 255800}, {x: 'Rodrigo Test', y: 178900}, {x: 'Travel Meals', y: 165800}, {x: 'Other Costs - COS', y: 58700}, {x: 'Prepaid Expenses', y: 39900}, ]" labels="['Other\\n$309,700', 'Postage And Delivery\\n$255,800', 'Rodrigo Test\\n$178,900', 'Travel Meals\\n$165,800', 'Other Costs - COS\\n$58,700', 'Prepaid Expenses\\n$39,900']" labelcomponent="&lt;victorylabel lineheight=&quot;[1.2, 1.4]&quot; style=&quot;[{fill: '#002E22', fontSize: 11, fontWeight: 700, fontFamily: 'Expensify Neue'}, {fill: '#76847E', fontSize: 11, fontWeight: 400, fontFamily: 'Expensify Neue'}]&quot; /&gt;" labelRadius="220" style="{ data: { stroke: '#F7F2EF' }, }"/><victorylabel x="340" y="265" textanchor='middle' verticalanchor='middle' text="Total\n$1,008,800" lineheight="[1.23, 1.27]" style="[ { fill: '#76847E', fontSize: 13, fontFamily: 'Expensify Neue' }, { fill: '#002E22', fontSize: 26, fontFamily: 'Expensify New Kansas' }, ]" /></victorychart>`;


Onyx.merge("reportActions_[reportID]", {
    [reportActionID1]: { message: [{ html, type: "COMMENT" }] },
    [reportActionID2]: { message: [{ html: html2, type: "COMMENT" }] },
    [reportActionID3]: { message: [{ html: html3, type: "COMMENT" }] },
});

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

n/a

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

codecov · 2026-06-08T18:11:07Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../VictoryChartRenderer/parsers/victoryAxisParser.ts	`85.71% <100.00%> (ø)`
...ictoryChartRenderer/parsers/victoryLegendParser.ts	`100.00% <100.00%> (ø)`
...s/VictoryChartRenderer/parsers/victoryPieParser.ts	`100.00% <100.00%> (ø)`
...ictoryChartRenderer/parsers/victorySeriesParser.ts	`84.61% <100.00%> (-1.10%)`	⬇️
...rs/VictoryChartRenderer/utils/parseRawChartData.ts	`100.00% <100.00%> (ø)`
...ictoryChartRenderer/components/VictoryChartBar.tsx	`9.09% <0.00%> (ø)`
...yChartRenderer/components/VictoryChartBarGroup.tsx	`4.00% <0.00%> (ø)`
...ctoryChartRenderer/components/VictoryChartLine.tsx	`9.09% <0.00%> (ø)`
...enderers/VictoryChartRenderer/utils/parseOffset.ts	`0.00% <0.00%> (ø)`
...s/VictoryChartRenderer/utils/parseRawLegendData.ts	`92.85% <92.85%> (ø)`
... and 10 more
... and 9 files with indirect coverage changes

melvin-bot · 2026-06-08T18:38:18Z

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2026-06-08T18:38:55Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2026-06-08T18:48:14Z

Conflicts

JmillsExpensify

No product review required.

… actual numbers

situchan · 2026-06-09T05:27:31Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

situchan · 2026-06-09T05:37:11Z

-    const categories = parseArrayAttribute<RawChartData>(tnode.attributes.data).filter(isNonNullObject<RawChartData>);
-    const colorScale = parseArrayAttribute<Color>(tnode.attributes.colorscale);
+    const categories = parseRawChartData(tnode.attributes.data);
+    const colorScale = parseAttributeAsStringArray(tnode.attributes.colorscale);


Skia's Color accepts numbers, and the old path kept them. Now any numeric entry in colorscale is filtered out, so that slice falls back to VictoryTheme.colors.default.
Is colorscale always hex strings in practice?

The backend is sending hex

situchan · 2026-06-09T05:42:34Z

+function parseAttributeAsStringArray(attribute: string): string[] | undefined {
+    const parsedValue = parseAttribute(attribute);
+    if (Array.isArray(parsedValue)) {
+        return parsedValue.filter((element): element is string => typeof element === 'string');


String-array attributes with bare-number entries are dropped.

i.e.

pie labels (VictoryChartPie): labels="[1, 2, 3]" → []/undefined → customLabel falls back to slice.label.

axis tickformat (victoryAxisParser): numeric tickformat entries dropped → formatLabel falls back to String(label).

Just confirming we don't have any non-strings for these kinds of properties.

Right now, labels nor tickformat should always be strings. We might want to update this if that changes.

github-actions · 2026-06-09T14:40:57Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-09T14:46:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92960.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1770a7cbbfd-79c0e20-6eee618cad6da24774a8c7a4d862d658bfc3f054/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1770a7c-79c0e20-ffffd16bc5e6fe53301983f6b02d39b14d5b19b9/index.html

Web 🕸️
https://92960.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-10T01:02:21Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T01:04:44Z

🤖 Help site review: no changes required

This PR is an internal code-safety refactor of the VictoryChart renderer — it removes unsafe type assertions and replaces them with runtime type checks when parsing chart node attributes (data, style, labels, axis/legend config, etc.). The goal is to prevent crashes from malformed input.

There is no user-facing behavior, UI, feature, or workflow change:

No new buttons, settings, tabs, or feature names introduced.
Chart rendering output is unchanged for valid input; the only difference is that invalid input is now handled gracefully instead of risking a crash.
VictoryChart is an internal rendering mechanism (charts embedded in report comments), not a documented end-user feature — there are no existing docs/articles files referencing it.

Because nothing in the public Expensify help site describes this internal parsing/rendering logic, no help site article needs to be created or updated, and no draft docs PR was opened.

@s77rt, if you believe a user-facing surface is affected that I may have missed, let me know and I'll re-evaluate.

OSBotify · 2026-06-10T19:55:42Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.4-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T19:58:20Z

Help site review

No help site changes are required for this PR.

This PR ([No QA] VictoryChart: strict types and parsing) is an internal type-safety refactor of the VictoryChart HTML renderer. It removes type assertions in the chart node parsers and replaces them with runtime type checks so malformed data can't be passed through to the underlying Victory components and trigger a crash.

The change is entirely in the parsing/rendering layer:

src/components/HTMLEngineProvider/HTMLRenderers/VictoryChartRenderer/** (parsers, utils, components)
server/victory-chart-renderer/src/resolveCanvasSize.ts
cspell.json and a unit test

There is no change to any user-facing feature, UI label, tab, setting, button, or workflow — and no behavioral change a customer would observe (charts render identically; the only difference is bad input now fails safely instead of crashing). The articles under App/docs/articles document customer-facing product behavior, so none of them are impacted.

Because no documentation update is needed, I did not create a draft help site PR.

@s77rt, please confirm you agree no help site updates are needed. If you believe a customer-facing behavior here should be documented, let me know and I'll draft the PR.

OSBotify · 2026-06-10T23:19:49Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

s77rt added 19 commits June 8, 2026 16:18

add parseCurveType

f0068e8

add parseAttributeAsStringArray, parseAttributeAsNumber

b2249ae

use safer parsers

0366879

add parseAttributeAsString

777ee03

add parseAttributeAsNumberArray

5b95ed4

use safer parsers (2)

593c06e

remove type argument and always return unknown type in parseAttribute

96059d6

add parseRawShiftedLineSegmentStyle

8792145

add parseRawAxisStyle

ff188c7

remove comments

217ddc2

add parseTextAnchor

7333a99

add praseRawLegendStyle

31ea140

add parseRawLabelStyle

74d3a3b

remove parseArrayAttribute

724a4fc

add parseRawChartData

ad4c322

parse colors as string[]

fd8aac8

add parseRawLegendData

f592b1b

remove isNonNullObject

e4e4785

lint

f59ca67

melvin-bot Bot assigned s77rt Jun 8, 2026

s77rt added 2 commits June 8, 2026 19:13

spellcheck

f00eb14

lint

efddba4

s77rt marked this pull request as ready for review June 8, 2026 18:38

s77rt requested review from a team as code owners June 8, 2026 18:38

melvin-bot Bot requested review from joekaufmanexpensify and situchan June 8, 2026 18:38

melvin-bot Bot removed the request for review from a team June 8, 2026 18:38

s77rt mentioned this pull request Jun 8, 2026

[Due for payment 2026-06-17] [$250] Harden Victory chart HTML parsers against malformed input #91776

Closed

melvin-bot Bot requested review from Gonals and removed request for a team June 8, 2026 18:38

s77rt removed the request for review from Gonals June 8, 2026 18:40

luacmartins requested changes Jun 8, 2026

View reviewed changes

JmillsExpensify reviewed Jun 8, 2026

View reviewed changes

s77rt added 3 commits June 8, 2026 22:55

merge main

77b1f58

fix parseAttributeAsNumberArray not converting stringified numbers to…

5fb79bc

… actual numbers

typo

6dc1f63

luacmartins previously approved these changes Jun 8, 2026

View reviewed changes

Comment thread src/components/HTMLEngineProvider/HTMLRenderers/VictoryChartRenderer/utils/parseAttribute.ts

add VictoryChartAttributesParsers.test.ts

e80e9c1

s77rt dismissed luacmartins’s stale review via e80e9c1 June 8, 2026 22:50

s77rt added 2 commits June 8, 2026 23:53

spellcheck

f986b09

use parseAttributeAsNumber

77cc8ba

situchan approved these changes Jun 9, 2026

View reviewed changes

melvin-bot Bot requested a review from luacmartins June 9, 2026 05:43

luacmartins approved these changes Jun 9, 2026

View reviewed changes

luacmartins merged commit 1770a7c into Expensify:main Jun 9, 2026
35 of 36 checks passed

OSBotify mentioned this pull request Jun 10, 2026

Deploy Checklist: New Expensify 2026-06-10 #93122

Closed

70 tasks

Uh oh!

Conversation

s77rt commented Jun 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Jun 8, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Jun 8, 2026

Uh oh!

melvin-bot Bot commented Jun 8, 2026

Uh oh!

situchan commented Jun 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

situchan commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

situchan Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

luacmartins Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Help site review

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

s77rt commented Jun 8, 2026 •

edited

Loading

codecov Bot commented Jun 8, 2026 •

edited by github-actions Bot

Loading

situchan commented Jun 9, 2026 •

edited

Loading