Docs updates for E/A#91646 personal details edit magic code verification

[MelvinBot]

Summary

Documents the user-facing changes from #91646, which secures private personal details behind a magic code verification step and consolidates them onto a single page.

Updates docs/articles/new-expensify/settings/Account-Settings.md:

• Rewrote the personal details section to reflect the consolidated Personal details page (with Basic details and Address sections) reached from the Private section of Account > Profile.
• Documented the new Let's make sure it's you magic code step required when saving legal name, date of birth, phone number, or address.
• Corrected UI labels to match the live UI (e.g., Private, Legal name, Date of birth, Display name) and added phone number to the list of private details.
• Added an FAQ entry explaining why a magic code is required.

All feature names, section headings, and button labels were verified against the live New Expensify UI.

Verification

Screenshots captured from the live New Expensify UI confirming the flow and labels:

Profile > Private section

Consolidated Personal details page

Let's make sure it's you magic code step

@jasperhuangg, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

[MelvinBot]

The failing build check is unrelated to this PR — it's a CI infrastructure breakage that is currently failing on every docs PR, not just this one.

What's failing: The Deploy ExpensifyHelp workflow's Install pcregrep step errors with:

E: Unable to locate package pcregrep

Why it's not this PR: This PR only changes one docs markdown file (docs/articles/new-expensify/settings/Account-Settings.md) — it doesn't touch the workflow or any script. The same workflow passed on main and on PRs through ~15:05 UTC today, then began failing on 8+ different docs branches simultaneously starting ~18:19 UTC, all at the identical apt-get install -y pcregrep step. That pattern points to a runner-image change on blacksmith-2vcpu-ubuntu-2404 (Ubuntu 24.04 Noble), not to anything in any of these PRs.

Recommended central fix (belongs on main, not this PR): The step runs sudo apt-get install -y pcregrep with no preceding apt-get update, and pcregrep is no longer a locatable package on the current Noble runner image. Two options for whoever owns the workflow:

1. Add sudo apt-get update before the install (fixes the case where the rotated image ships stale/empty apt lists), and/or
2. Switch from the EOL PCRE1 tool to PCRE2: install pcre2-utils and replace pcregrep with pcre2grep in .github/scripts/enforceVideoFormats.sh (3 call sites). pcregrep was dropped from Ubuntu 24.04 in favor of pcre2grep.

I'm not pushing this fix to this branch because (a) it's outside the scope of a docs-only PR, and (b) it needs to land once on main to unblock all the affected docs PRs at once. Once the workflow is fixed centrally, re-running this check should pass with no changes here.

[MelvinBot]

🤖 I identified and prepared the fix, but I can't push it — my token lacks the workflow scope required to modify files under .github/workflows/:

! [remote rejected] refusing to allow a Personal Access Token to update workflow
`.github/workflows/deployExpensifyHelp.yml` without `workflow` scope

A human needs to apply the one-line change below (ideally directly on main, since this is breaking every docs PR right now, not just this one).

Root cause (confirmed): The Deploy ExpensifyHelp workflow's Install pcregrep step runs sudo apt-get install -y pcregrep with no preceding apt-get update. The blacksmith-2vcpu-ubuntu-2404 runner image was rotated with a stale/empty apt index, so the package can no longer be located:

E: Unable to locate package pcregrep

This isn't a missing-package problem — pcregrep is in noble/universe. The last successful run at 15:05 UTC today downloaded it cleanly (pcregrep amd64 2:8.39-15build1 from noble/universe). Failures began ~18:19 UTC across 8+ docs branches simultaneously with no workflow change since 06-04 — a runner-image rotation, confirming the index just needs refreshing.

The fix (refresh the apt index before installing):

      - name: Install pcregrep
        run: |
          sudo apt-get update
          sudo apt-get install -y pcregrep

Once this lands on main, re-running the check here should pass with no other changes to this PR.

[stephanieelliott]

This was handled: #91597