[CP Staging] Revert "Remove inline-flex from comment anchors so links wrap inline"#92695
Conversation
melvin-bot
Bot
requested review from
heyjennahay and
mjasikowski
and removed request for
a team
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7cdf2c48d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| textDecorationLineStyle, | ||
| styles.textUnderlinePositionUnder, | ||
| styles.textDecorationSkipInkNone, | ||
| styles.dInlineFlex, |
There was a problem hiding this comment.
When a chat comment contains a multi-word anchor in a narrow column, re-applying display: inline-flex to the rendered link text makes the link an atomic inline-flex box on web, so it cannot break at spaces and instead gets pushed to a new line or overflows rather than wrapping with the surrounding comment text. This reintroduces the behavior that the reverted change removed; the link text should stay inline text so long links like page titles can wrap naturally.
Useful? React with 👍 / 👎.
lakchote
changed the title
|
Not an emergency, straight revert |
|
@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
…neWrapFix [CP Staging] Revert "Remove inline-flex from comment anchors so links wrap inline" (cherry picked from commit 8c5a2a3) (cherry-picked to staging by lakchote)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.3.99-4 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no documentation changes required. This PR reverts #92387, re-adding The help site articles under If you believe a specific help article is affected, let me know which one and I'll take another look. |
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.0-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review — no documentation changes required This PR reverts #92387 by re-adding The change is a purely visual CSS rendering tweak governing how multi-word hyperlinks inside chat comments wrap at line breaks (atomic I reviewed If you believe a specific help article is affected, let me know which one and I'll take another look. |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.0-7 🚀
|
4 participants
Reverts #92387