[No QA] Docs updates for E/A#91725 surface Signer info needed Home task#92634
Conversation
…gner steps Co-authored-by: Dilshod Bunyodov <dilshodmackbook-sketch@users.noreply.github.com>
|
Reviewed the 5 updated help articles — the added Note block accurately reflects the behavior shipped in #91725. UI labels in the note (Signer info needed, Time sensitive, Begin, Home) match the in-app strings in I don't have permission to edit the PR description or flip it out of draft, so leaving the Tests / QA copy here for a maintainer to drop in and mark Tests
QA
|
|
@MelvinBot why was the author of the original PR, |
|
Short answer: this docs PR was opened automatically by me, and my PR-creation step only fills the GitHub Assignees field when an assignee is explicitly handed to it. The help-docs update flow that generated this PR didn't designate Instead of assigning them, the flow surfaced the original author via an @-mention in the PR description ("…please review the files changed and confirm they reflect the current behavior. Then mark this PR So it wasn't a deliberate exclusion — it's a gap in the automation: it requests the original author's review in the body but doesn't also add them to the Assignees field. If the intent is for the feature-PR author to own this docs PR, the right fix is to have the docs flow pass that author through as the assignee at creation time (and they can be added now via the Assignees field). |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@dannymcclain @cretadn22 @Kel-Expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
This is great, thank you @dilshodmackbook-sketch! |
HelpDot Documentation ReviewOverall AssessmentThis PR adds a single Note paragraph to five Global Reimbursement articles (Australia, Canada, Europe, United Kingdom, United States). The note informs readers that designated Directors or Senior Officers will see a Signer info needed task on their Home page and can select Begin to enter their information. The change is small, consistent, and well-placed contextually near the Director/Senior Officer information steps. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: No inline comments were posted as there are no line-level issues requiring correction. |
|
🚀 Deployed to staging by https://github.com/Kel-Expensify in version: 9.4.2-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/Kel-Expensify in version: 9.4.4-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀
|
Explanation of Change
PR #91725 added a new Signer info needed task to the Time sensitive section of the Home page, surfacing pending signer-info actions for global reimbursement bank accounts. When a workspace admin designates a Director or Senior Officer to act as the signer, that person now sees a task on their Home page and can select Begin to enter their information.
This PR updates the global reimbursement help articles so the documented signer/director step reflects this new entry point. A short note was added to each country guide at the point where the designated signer is told they'll be notified.
Files updated:
Global-Reimbursement-United-States.mdGlobal-Reimbursement-Europe.mdGlobal-Reimbursement-Canada.mdGlobal-Reimbursement-United-Kingdom.mdGlobal-Reimbursement-Australia.mdUI labels were verified against
src/languages/en.ts:homePage.timeSensitiveSection.enterSignerInfo.title)homePage.timeSensitiveSection.title)homePage.forYouSection.begin)Fixed Issues
$ #90996
Related PR: #91725
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
QA
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
@dilshodmackbook-sketch, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.