Skip to content

[No QA] Docs updates for E/A#91725 surface Signer info needed Home task#92634

Merged
Kel-Expensify merged 1 commit into
mainfrom
docs/90996-signer-info-home-task
Jun 9, 2026
Merged

[No QA] Docs updates for E/A#91725 surface Signer info needed Home task#92634
Kel-Expensify merged 1 commit into
mainfrom
docs/90996-signer-info-home-task

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

PR #91725 added a new Signer info needed task to the Time sensitive section of the Home page, surfacing pending signer-info actions for global reimbursement bank accounts. When a workspace admin designates a Director or Senior Officer to act as the signer, that person now sees a task on their Home page and can select Begin to enter their information.

This PR updates the global reimbursement help articles so the documented signer/director step reflects this new entry point. A short note was added to each country guide at the point where the designated signer is told they'll be notified.

Files updated:

  • Global-Reimbursement-United-States.md
  • Global-Reimbursement-Europe.md
  • Global-Reimbursement-Canada.md
  • Global-Reimbursement-United-Kingdom.md
  • Global-Reimbursement-Australia.md

UI labels were verified against src/languages/en.ts:

  • Task title: Signer info needed (homePage.timeSensitiveSection.enterSignerInfo.title)
  • Section: Time sensitive (homePage.timeSensitiveSection.title)
  • Button: Begin (homePage.forYouSection.begin)
  • Tab: Home

Fixed Issues

$ #90996

Related PR: #91725

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

QA

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.


@dilshodmackbook-sketch, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

…gner steps

Co-authored-by: Dilshod Bunyodov <dilshodmackbook-sketch@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team June 4, 2026 08:03
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 4, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#91725 surface Signer info needed Home task [No QA] Docs updates for E/A#91725 surface Signer info needed Home task Jun 4, 2026
@dilshodmackbook-sketch

Copy link
Copy Markdown
Contributor

Reviewed the 5 updated help articles — the added Note block accurately reflects the behavior shipped in #91725. UI labels in the note (Signer info needed, Time sensitive, Begin, Home) match the in-app strings in src/languages/en.ts. Confirming the docs are ready.

I don't have permission to edit the PR description or flip it out of draft, so leaving the Tests / QA copy here for a maintainer to drop in and mark Ready for review:

Tests

  1. Open each updated help article on https://help.expensify.com/new-expensify/hubs/wallet-and-payments/ and confirm the new Note block renders correctly under the Director / Senior Officer step:
    • Global-Reimbursement-United-States.md
    • Global-Reimbursement-Europe.md
    • Global-Reimbursement-Canada.md
    • Global-Reimbursement-United-Kingdom.md
    • Global-Reimbursement-Australia.md
  2. Verify the note text matches the in-app strings:
    • Task title: Signer info needed
    • Section: Time sensitive
    • Button: Begin
    • Tab: Home
  3. Verify markdown formatting (bold labels, spacing, surrounding headings) is preserved and the note does not break the article layout.
  4. Cross-check the described behavior against Add "Enter signer info" task to Home Time Sensitive section #91725 (already merged): the designated Director / Senior Officer sees the Signer info needed task on Home → Time sensitive, and Begin opens the Enter Signer Info flow for the correct policy / bank account.

QA

  1. Browse to each of the 5 updated Global Reimbursement help articles on help.expensify.com.
  2. Verify each article now contains a Note explaining that the designated Director / Senior Officer also sees a Signer info needed task in the Time sensitive section of their Home page, with a Begin button to enter their information.
  3. Verify no other content in these articles was unintentionally modified, removed, or reformatted.
  4. Verify links, headings, and surrounding step numbering still render correctly on the published site.

@stephanieelliott

Copy link
Copy Markdown
Contributor

@MelvinBot why was the author of the original PR, dilshodmackbook-sketch, not added as an assignee to this PR?

@MelvinBot

Copy link
Copy Markdown
Contributor Author

Short answer: this docs PR was opened automatically by me, and my PR-creation step only fills the GitHub Assignees field when an assignee is explicitly handed to it. The help-docs update flow that generated this PR didn't designate dilshodmackbook-sketch as an assignee, so the field was left empty.

Instead of assigning them, the flow surfaced the original author via an @-mention in the PR description ("…please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review."), which is why dilshodmackbook-sketch reviewed and confirmed the docs above — they were treated as the intended reviewer/co-author rather than a GitHub assignee.

So it wasn't a deliberate exclusion — it's a gap in the automation: it requests the original author's review in the body but doesn't also add them to the Assignees field. If the intent is for the feature-PR author to own this docs PR, the right fix is to have the docs flow pass that author through as the assignee at creation time (and they can be added now via the Assignees field).

@stephanieelliott stephanieelliott marked this pull request as ready for review June 9, 2026 20:09
@stephanieelliott stephanieelliott self-requested a review as a code owner June 9, 2026 20:09
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @Kel-Expensify

@melvin-bot melvin-bot Bot requested review from Kel-Expensify, cretadn22 and dannymcclain and removed request for a team June 9, 2026 20:09
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@dannymcclain @cretadn22 @Kel-Expensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott

Copy link
Copy Markdown
Contributor

This is great, thank you @dilshodmackbook-sketch!

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single Note paragraph to five Global Reimbursement articles (Australia, Canada, Europe, United Kingdom, United States). The note informs readers that designated Directors or Senior Officers will see a Signer info needed task on their Home page and can select Begin to enter their information. The change is small, consistent, and well-placed contextually near the Director/Senior Officer information steps.

Scores Summary

  • Readability: 9/10 - The added note is clear, concise, and action-oriented. It tells the user exactly where to find the task and what to do. The Australia variant appropriately adjusts for the plural ("Each designated Director or Senior Officer") since that article requires at least two signers.
  • AI Readiness: 8/10 - The note uses full feature names (Signer info needed, Home, Time sensitive) which aids semantic retrieval. No changes to headings or metadata were made, but none were needed for this scope. Minor deduction: the note content is not surfaced through any heading, so an AI system retrieving "how to complete signer info" may not index this passage directly. This is acceptable for a supplementary note.
  • Style Compliance: 10/10 - UI element names are bolded correctly (Signer info needed, Time sensitive, Home, Begin). The phrasing "select Begin" follows the button naming standards. No prohibited language is used. No quotation marks around UI labels. Terminology is consistent across all five files.

Key Findings

  • The note is well-crafted and consistent across all five files, with appropriate singular/plural variation for the Australia article.
  • All UI element references follow the bold formatting and exact-label requirements from HELPSITE_NAMING_CONVENTIONS.md.
  • The placement after the Director/Senior Officer information steps is logical and does not interrupt procedural flow.
  • No cross-linking issues, no heading changes, and no structural concerns.

Recommendations

  • No blocking issues. This PR is ready to merge from a documentation quality standpoint.
  • Optional: Consider whether the Australia article's note could be consolidated closer to the existing "at least two Directors" note (they are adjacent, which is fine, but a single combined note might read slightly more smoothly).

Files Reviewed

  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Australia.md - One note added (plural form for multiple signers). Clean.
  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Canada.md - One note added. Clean.
  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-Europe.md - One note added. Clean.
  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-Kingdom.md - One note added. Clean.
  • docs/articles/new-expensify/wallet-and-payments/Global-Reimbursement-United-States.md - One note added. Clean.

Note: No inline comments were posted as there are no line-level issues requiring correction.

@Kel-Expensify Kel-Expensify merged commit 41f4a2f into main Jun 9, 2026
19 checks passed
@Kel-Expensify Kel-Expensify deleted the docs/90996-signer-info-home-task branch June 9, 2026 21:57
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Kel-Expensify in version: 9.4.2-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Kel-Expensify in version: 9.4.4-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants