Skip to content

Docs updates for E/A#90914 clearing rule field values with None option#92456

Merged
bfitzexpensify merged 1 commit into
mainfrom
docs/89536-clear-rule-field-none-option
Jun 9, 2026
Merged

Docs updates for E/A#90914 clearing rule field values with None option#92456
bfitzexpensify merged 1 commit into
mainfrom
docs/89536-clear-rule-field-none-option

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Documents the new None option added in #90914, which lets users clear a previously selected Category, Tag, or Tax value when configuring a rule.

The original PR enabled allowNoneOption on the shared rule selection picker, so the None option now appears in both:

  • Workspace Merchant Rules (Category, Tag, Tax selection)
  • Personal Expense Rules (Category, Tag, Tax rate selection)

Neither help article previously documented how to clear a previously set field value, so this adds a concise FAQ entry to each.

Files changed

  • docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md — FAQ: how to clear a Category, Tag, or Tax value from a Workspace Merchant Rule
  • docs/articles/new-expensify/settings/Personal-Expense-Rules.md — FAQ: how to clear a Category, Tag, or Tax rate value from an Expense Rule

Authoring compliance

  • Followed HELP_AUTHORING_GUIDELINES.md, HELPSITE_NAMING_CONVENTIONS.md, and TEMPLATE.md.
  • UI labels verified against src/languages/en.ts: the option label is None (common.none), and the save button is Save rule (Save rule, lowercase "r").
  • Added only ## How to / How do I task-based FAQ headings; no new # headings.

Related

@aswin-s, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Adds FAQ entries to Workspace Merchant Rules and Personal Expense Rules
explaining how to clear a Category, Tag, or Tax value using the new None
option, reflecting #90914.

Co-authored-by: Aswin S <aswin-s@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 3, 2026

@aswin-s aswin-s left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanieelliott
stephanieelliott marked this pull request as ready for review June 8, 2026 05:00
@stephanieelliott
stephanieelliott self-requested a review as a code owner June 8, 2026 05:00
@stephanieelliott stephanieelliott self-assigned this Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds two small, well-scoped FAQ entries documenting the new None option for clearing Category, Tag, and Tax/Tax rate values in expense rules. The changes are minimal, clearly written, and follow the existing structure of both articles.

Scores Summary

  • Readability: 9/10 - Clear, concise, and actionable. Each FAQ answer is a single sentence that tells the user exactly what to do. Easy to scan.
  • AI Readiness: 9/10 - Both headings use the "How do I [task]" pattern with specific feature names (Category, Tag, Tax/Tax rate), which supports semantic retrieval well. Placed correctly under the existing # FAQ sections.
  • Style Compliance: 8/10 - UI element names are properly bolded (Category, Tag, Tax rate, None, Save rule). Terminology matches each article's existing conventions. One minor inconsistency: the Personal-Expense-Rules entry uses "click or tap Save rule" while the Workspace-Merchant-Rules entry uses "select Save rule". Per HELPSITE_NAMING_CONVENTIONS.md, "Select" is the preferred verb for UI actions and is more platform-neutral. Recommend changing "click or tap" to "select" in the Personal-Expense-Rules entry for consistency.

Key Findings

  • Both FAQ headings are task-based and searchable, fully compliant with heading rules.
  • UI labels (None, Save rule, Category, Tag, Tax/Tax rate) appear to match the product UI and are consistently bolded.
  • The "Tax rate" vs "Tax" difference between the two articles is correct -- each matches the terminology already established in its respective article.
  • Minor inconsistency in action verb usage between the two new entries ("click or tap" vs "select").

Recommendations

  • In Personal-Expense-Rules.md, change "Then click or tap Save rule" to "Then select Save rule" for consistency with the other entry and with HELPSITE_NAMING_CONVENTIONS.md conventions.

Files Reviewed

  • docs/articles/new-expensify/settings/Personal-Expense-Rules.md -- New FAQ entry added. Minor verb inconsistency noted.
  • docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md -- New FAQ entry added. Fully compliant.

Comment thread docs/articles/new-expensify/workspaces/Workspace-Merchant-Rules.md
@stephanieelliott
stephanieelliott requested a review from a team June 9, 2026 03:55
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed
    For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?
    cc @bfitzexpensify

@melvin-bot
melvin-bot Bot requested review from bfitzexpensify and removed request for a team June 9, 2026 03:55
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@bfitzexpensify

bfitzexpensify commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@bfitzexpensify
bfitzexpensify merged commit 0fd4dab into main Jun 9, 2026
17 checks passed
@bfitzexpensify
bfitzexpensify deleted the docs/89536-clear-rule-field-none-option branch June 9, 2026 06:57
@m-natarajan

Copy link
Copy Markdown

@stephanieelliott @aswin-s No QA steps, OK to checkoff this one?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.4.2-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@Julesssss

Copy link
Copy Markdown
Contributor

@stephanieelliott @aswin-s No QA steps, OK to checkoff this one?

Yeah no QA here, thanks for checking.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.4.4-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants