Skip to content

feat(onboarding): allow public domain users to create Submit workspace#92255

Closed
abzokhattab wants to merge 9 commits into
Expensify:mainfrom
abzokhattab:abzokhattab/submit-onboarding-public-domain
Closed

feat(onboarding): allow public domain users to create Submit workspace#92255
abzokhattab wants to merge 9 commits into
Expensify:mainfrom
abzokhattab:abzokhattab/submit-onboarding-public-domain

Conversation

@abzokhattab

@abzokhattab abzokhattab commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

When the SUBMIT_2026 beta is enabled, public domain users can create a Submit workspace during onboarding by selecting "Submit expenses to my employer" on the Purpose screen.

Fixed Issues

$ #87261
PROPOSAL:

Tests

  1. Enable the SUBMIT_2026 beta
  2. Sign up with a @gmail.com address and skip the Work Email step
  3. On the Purpose screen, select "Submit expenses to my employer"
  4. Verify a Submit workspace is created and you are navigated to Workspace Categories
  • Verify that no errors appear in the JS console

Offline tests

  • Verify that no errors appear in the JS console

QA Steps

  1. Enable the SUBMIT_2026 beta
  2. Sign up with a public domain email (e.g. @gmail.com)
  3. Complete the Work Email onboarding step
  4. On the Purpose screen, select "Submit expenses to my employer"
  5. Verify a Submit workspace is created and the user is navigated to Workspace Categories
  6. Without the SUBMIT_2026 beta, repeat steps 2–5 — verify the Submit workspace is not auto-created
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-06-01.at.20.37.49.mov
iOS: mWeb Safari
Screen.Recording.2026-06-01.at.20.39.21.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-01.at.19.17.47.mov

@abzokhattab
abzokhattab force-pushed the abzokhattab/submit-onboarding-public-domain branch 2 times, most recently from d6fae94 to 28c20b5 Compare June 1, 2026 17:21
@abzokhattab
feat(onboarding): allow public domain users to create a Submit workspace
20baff3 
When the SUBMIT_2026 beta is enabled, skip the Work Email step for
public domain users so they start at the Purpose screen and can select
the EMPLOYER intent to create a Submit workspace.

Without the beta the existing flow is unchanged: public domain users
are still routed to Work Email first.
@abzokhattab
abzokhattab force-pushed the abzokhattab/submit-onboarding-public-domain branch 2 times, most recently from ecce447 to f098cb3 Compare June 1, 2026 17:55
@MelvinBot MelvinBot mentioned this pull request Jun 1, 2026
Merged
50 tasks
@abzokhattab abzokhattab changed the title feat(onboarding): allow public domain users to create Submit workspace [SUBMIT_2026 beta] feat(onboarding): allow public domain users to create Submit workspace Jun 1, 2026
@abzokhattab
abzokhattab marked this pull request as ready for review June 1, 2026 18:44
@abzokhattab
abzokhattab requested review from a team as code owners June 1, 2026 18:44
@melvin-bot
melvin-bot Bot requested review from heyjennahay and hungvu193 and removed request for a team June 1, 2026 18:44
@melvin-bot

melvin-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 1, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f098cb3d48

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/hooks/useOnboardingFlow.ts Outdated
@abzokhattab
abzokhattab force-pushed the abzokhattab/submit-onboarding-public-domain branch from f098cb3 to 2e49852 Compare June 1, 2026 18:49
@abzokhattab
abzokhattab force-pushed the abzokhattab/submit-onboarding-public-domain branch from 2e49852 to da73261 Compare June 1, 2026 18:52
@abzokhattab
Address review feedback: import order, types, tests, and betas comment
df6b3ee 
- Fix import order in useOnboardingFlow.ts (usePermissions after @src/ aliases)
- Default canUseSubmit2026 = false in OnboardingFlow.ts destructuring to make intent explicit
- Add comment in OnboardingModalNavigator explaining betas loading dependency
- Add test for primary scenario: public domain INDIVIDUAL + canUseSubmit2026 bypasses work-email
- Add getOnboardingStepCounter tests for Submit 2026 beta with/without Work Email prefix
- Fix null → undefined in test params (OnyxEntry is T | undefined, not T | null | undefined)
@abzokhattab
Remove betas loading comment from OnboardingModalNavigator
a9a1a6f
@abzokhattab
Merge branch 'main' into abzokhattab/submit-onboarding-public-domain
d772ff2
@abzokhattab

abzokhattab commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

@hungvu193 ready for review .. the failing error is unrelated

@abzokhattab
abzokhattab force-pushed the abzokhattab/submit-onboarding-public-domain branch from 5dadc48 to 2a54c88 Compare June 2, 2026 10:31
@hungvu193

hungvu193 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Currently, the 3 step is:

  1. Verify the onboarding starts at the Purpose screen (not Work Email)

However, while testing I can see the Work email appears first, can you confirm if this is expected? If yes, then please update the test steps. Ty

Screen.Recording.2026-06-02.at.21.33.35.mov

@abzokhattab
Wait for betas to load before deciding onboarding initial route
426ea66 
OnboardingModalNavigator committed initialRouteName at mount before the
betas Onyx key finished loading, so canUseSubmit2026 read false and public
domain users were locked into the Work Email screen even with SUBMIT_2026
enabled. Gate rendering on betas loading alongside account.
@abzokhattab

abzokhattab commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

looks like a race condition for the beta onyx .. i just fixed it ... please have alook @hungvu193

@hungvu193

hungvu193 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

hmm still the same

Screen.Recording.2026-06-03.at.11.18.28.mov

@hungvu193

hungvu193 commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@abzokhattab Can you prioritize this one? 😄

@abzokhattab

abzokhattab commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

back on it

@abzokhattab
Merge origin/main into abzokhattab/submit-onboarding-public-domain
aed9d57 
Resolve getOnboardingStepCounterTest conflict by keeping Submit 2026
beta flow tests and main's updated public VSB flow expectations.
@abzokhattab

abzokhattab commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

I have a product question: Currently, when a user signs up with a public email, the "add work email" modal appears first. and If they provide and validate a work email, onboarding completes immediately, which means the "join employer" step is never reached. Should we skip the "add work email" step if the submit beta is enabled, or keep it as is? @garrettmknight

Screen.Recording.2026-06-08.at.13.30.54.mov

@abzokhattab

abzokhattab commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

PR is ready @hungvu193 given the discussion on slack we decided to keep the work email step as is and work on it on another ticket.

@abzokhattab
revert: remove Work Email bypass from Submit onboarding PR
c4a9c0c 
The PR scope is only enabling Submit workspace creation when selecting
EMPLOYER on the Purpose screen. Revert all changes that skipped or
gated the Work Email step for public domain users with SUBMIT_2026 beta.
@abzokhattab

abzokhattab commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Well, after retesting, it looks like the issue got fixed on main in another PR ... rn i can create a submit workspace with the Gmail account

Screen.Recording.2026-06-08.at.14.05.52.mov

@abzokhattab abzokhattab closed this Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@heyjennahay heyjennahay Awaiting requested review from heyjennahay
@hungvu193 hungvu193 Awaiting requested review from hungvu193

Assignees

@abzokhattab abzokhattab

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@abzokhattab @hungvu193