Skip to content

Scan - In multiple receipt modal animation is not shown #92239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chuckdries merged 6 commits into from
Jun 2, 2026
Merged

Scan - In multiple receipt modal animation is not shown #92239

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e3320ce
fix: adjust default width and height of multiscan modal
rinej Jun 1, 2026
dc17772
fix: add original imageHeight
rinej Jun 1, 2026
08170c5
chore: cleanup
rinej Jun 1, 2026
1c1e0c8
Merge branch 'main' into Scan-In-multiple-receipt-modal-animation-is-…
rinej Jun 1, 2026
f839852
Merge branch 'main' into Scan-In-multiple-receipt-modal-animation-is-…
rinej Jun 2, 2026
97ef904
Merge remote-tracking branch 'upstream/main' into Scan-In-multiple-re…
rinej Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/pages/iou/request/step/IOURequestStepScan/components/MultiScanEducationalModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ function MultiScanEducationalModal() {
title={translate('iou.scanMultipleReceipts')}
image={lazyIllustrations.MultiScan}
shouldRenderSVG
imageHeight="auto"
imageWidth="auto"
imageHeight={220}
modalInnerContainerStyle={styles.pt0}
illustrationOuterContainerStyle={styles.multiScanEducationalPopupImage}

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Set the modal illustration aspect ratio

When the SVG now falls back to ImageSVG's 100% width/height, FeatureTrainingModal still wraps it in a 4:3 inner viewport because illustrationAspectRatio is omitted (the default is the video ratio, 1280/960). This modal’s outer container uses styles.multiScanEducationalPopupImage with aspectRatio: 1.7, matching the multi-scan SVG viewBox (375/220), so the 4:3 inner view becomes taller than the clipped outer view and the centered SVG is cropped at the bottom on the same Android/iOS path this fixes. Pass the SVG’s aspect ratio here so the image renders at the intended size instead of being partially hidden.

Useful? React with 👍 / 👎.

@mkhutornyi mkhutornyi Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughs?

Original code was: imageHeight={220}

@rinej rinej Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, added the original approach

onConfirm={dismissEducationalPopup}
Expand Down
Loading