[No QA] Bump ruby/setup-ruby to v1.310.0 (node24)#92220
Conversation
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR standardizes the pinned ruby/setup-ruby GitHub Action SHA across key CI workflows by bumping to v1.310.0, which runs on the Node 24 Actions runtime (aligning with GitHub’s Node 20 deprecation timeline).
Changes:
- Updated
ruby/setup-rubypinned SHA tov1.310.0(Node 24 runtime) in multiple workflows. - Aligned previously Node 20–pinned workflows with the rest of the repo’s Node 24–pinned usages.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 14 comments.
| File | Description |
|---|---|
| .github/workflows/remote-build-ios.yml | Updates ruby/setup-ruby pin used by the remote iOS build workflow. |
| .github/workflows/deploy.yml | Updates ruby/setup-ruby pins across Android/iOS deploy-related jobs. |
| .github/workflows/buildIOS.yml | Updates ruby/setup-ruby pin used during iOS build workflow. |
| .github/workflows/androidBump.yml | Updates ruby/setup-ruby pin used by the Android rollout bumper workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1708262ebc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Co-authored-by: Cursor <cursoragent@cursor.com>
1708262 to
59fa486
Compare
|
@ShridharGoel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.99-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀
|
Explanation of Change
Bumps the node20 SHA of
ruby/setup-rubyto v1.310.0 (node24 runtime) acrossbuildIOS.yml,deploy.yml,remote-build-ios.yml, andandroidBump.yml. The other workflows already pin a node24 SHA of this action — this standardises all usages.Fixed Issues
$ #92208
PROPOSAL:
Tests
Offline tests
N/A — CI workflow change only, no offline behavior changed.
QA Steps
N/A — title includes
[No QA], CI infrastructure change only.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — CI workflow change only, no app UI modified.
Android: mWeb Chrome
N/A — CI workflow change only, no app UI modified.
iOS: Native
N/A — CI workflow change only, no app UI modified.
iOS: mWeb Safari
N/A — CI workflow change only, no app UI modified.
MacOS: Chrome / Safari
N/A — CI workflow change only, no app UI modified.