[No QA] Bump mxschmitt/action-tmate to v3.24 (node24)#92219
Conversation
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Updates the generateTranslations GitHub Actions workflow to use a newer mxschmitt/action-tmate revision that runs on the Node 24 Actions runtime, aligning with the repository’s broader migration off deprecated Node 20.
Changes:
- Bumped
mxschmitt/action-tmatefrom a Node 20-era pinned SHA to the v3.24 (Node 24) pinned SHA in thegenerateTranslationsworkflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Co-authored-by: Cursor <cursoragent@cursor.com>
dadff3d to
1f91605
Compare
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.99-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀
|
Explanation of Change
Bumps
mxschmitt/action-tmatefrom a node20 SHA to v3.24 (node24 runtime) ingenerateTranslations.yml.Fixed Issues
$ #92208
PROPOSAL:
Tests
generateTranslationsworkflow runs under node24 without errors.Offline tests
N/A — CI workflow change only, no offline behavior changed.
QA Steps
N/A — title includes
[No QA], CI infrastructure change only.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — CI workflow change only, no app UI modified.
Android: mWeb Chrome
N/A — CI workflow change only, no app UI modified.
iOS: Native
N/A — CI workflow change only, no app UI modified.
iOS: mWeb Safari
N/A — CI workflow change only, no app UI modified.
MacOS: Chrome / Safari
N/A — CI workflow change only, no app UI modified.