[No QA] Bump aws-actions/configure-aws-credentials to v6.1.3 (node24)#92216
Conversation
|
@codex review |
There was a problem hiding this comment.
Pull request overview
Updates the remote build GitHub Actions workflows to use the Node 24-compatible SHA of aws-actions/configure-aws-credentials, aligning these remote build jobs with the ongoing migration away from deprecated Node 20 Actions runtimes.
Changes:
- Bump
aws-actions/configure-aws-credentialspin in the iOS remote build workflow to the new SHA (v6.1.3 / Node 24 runtime). - Bump
aws-actions/configure-aws-credentialspin in the Android remote build workflow to the new SHA (v6.1.3 / Node 24 runtime).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/remote-build-ios.yml | Updates the AWS credentials action pin used by the remote iOS build job to a Node 24-compatible SHA. |
| .github/workflows/remote-build-android.yml | Updates the AWS credentials action pin used by the remote Android build job to a Node 24-compatible SHA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Co-authored-by: Cursor <cursoragent@cursor.com>
7b0be4b to
8317012
Compare
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.3.99-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀
|
Explanation of Change
Bumps the node20 SHA of
aws-actions/configure-aws-credentialsto v6.1.3 (node24 runtime) inremote-build-android.ymlandremote-build-ios.yml. The other workflows already pin a node24 SHA of this action.Fixed Issues
$ #92208
PROPOSAL:
Tests
Offline tests
N/A — CI workflow change only, no offline behavior changed.
QA Steps
N/A — title includes
[No QA], CI infrastructure change only.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
N/A — CI workflow change only, no app UI modified.
Android: mWeb Chrome
N/A — CI workflow change only, no app UI modified.
iOS: Native
N/A — CI workflow change only, no app UI modified.
iOS: mWeb Safari
N/A — CI workflow change only, no app UI modified.
MacOS: Chrome / Safari
N/A — CI workflow change only, no app UI modified.