Skip to content

[No QA] Docs updates for E/A#91691 Rename Save search button to Save view#92190

Merged
greg-schroeder merged 6 commits into
mainfrom
docs-91691-save-view
Jun 19, 2026
Merged

[No QA] Docs updates for E/A#91691 Rename Save search button to Save view#92190
greg-schroeder merged 6 commits into
mainfrom
docs-91691-save-view

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Follow-up to the UI rename in #91691, which changed the saved-view page title and submit button from Save search to Save view (the search.saveSearchsearch.saveView translation key).

This updates the help site articles that referenced the old Save search button label so they match the current UI. Only explicit button-label references were changed — the Saved searches feature name and other "saved search" terminology were left untouched because the app still uses that wording (e.g. the Saved menu and "Delete saved search").

Files changed

  • docs/articles/new-expensify/insights/How-to-Use-Insights-in-Expensify.md — "Click Save search" → "Click Save view"
  • docs/articles/new-expensify/insights/View-the-Top-Merchants-report.md — "click Save search" → "click Save view"
  • docs/articles/new-expensify/insights/View-the-Top-Categories-report.md — "click Save search" → "click Save view"
  • docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md — "clicking Save search" → "clicking Save view"

Intentionally not changed

  • Using-Reports-in-New-Expensify.md — the "How to save a search" steps reference the Save entry button (common.save), which is unchanged, and the conceptual "saved searches" wording, which the app still uses.
  • "saved search query" / "saved searches" references in Insights and other articles — these describe the unchanged feature concept, not the renamed button.

Verification

Verified against the merged source in #91691:

  • Save-view page title and submit button: search.saveView = "Save view" (src/pages/Search/SearchSavePage.tsx).
  • Search-bar entry button remains Save (common.save) (src/components/Search/SearchPageHeader/SearchSaveButton.tsx).
  • Sentence case ("Save view") matches the Naming Conventions button-label rule.

@mdneyazahmad, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Reflects the UI rename in E/A#91691 where the saved-view button and page
title changed from "Save search" to "Save view".

Co-authored-by: mdneyazahmad <mdneyazahmad@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 1, 2026
@MelvinBot MelvinBot mentioned this pull request Jun 1, 2026
51 tasks
@github-actions github-actions Bot changed the title Docs updates for E/A#91691 Rename Save search button to Save view [No QA] Docs updates for E/A#91691 Rename Save search button to Save view Jun 1, 2026
@OSBotify

This comment has been minimized.

@mdneyazahmad mdneyazahmad left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it just Save?

In the docs it says Save search and updates to Save view after we update in this PR #91691

Image

@OSBotify

This comment has been minimized.

@stephanieelliott
stephanieelliott marked this pull request as ready for review June 9, 2026 03:34
@stephanieelliott
stephanieelliott self-requested a review as a code owner June 9, 2026 03:34
@stephanieelliott

Copy link
Copy Markdown
Contributor

Good catch @mdneyazahmad! I've updated the file to match the UI

1. Go to the **Spend** or **Expenses** tab.
2. Use filters to adjust the category grouping or timeframe.
3. Apply filters and click **Save search** to save your custom report.
3. Apply filters and click **Save** to save your custom view.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step formatting: This step combines two distinct actions ("Apply filters" and "click Save"). Per the step formatting standard (HELP_AUTHORING_GUIDELINES.md Section 5), steps should be sequential and each describe a single action. Consider splitting into two steps:

  1. Apply filters.
  2. Click Save to save your custom view.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates four help articles to replace the old Save search button label with Save, aligning documentation with the UI change from #91691. The changes are minimal, targeted, and well-scoped -- only the explicit button-label references were updated, while conceptual "saved search" terminology was intentionally left intact where the app still uses it.

Scores Summary

  • Readability: 9/10 - The changed lines are clear and action-oriented. Button references remain properly bolded and embedded in sequential step instructions. One minor note: File 1 has a trailing space on the changed line, though this is cosmetic.
  • AI Readiness: 9/10 - No impact on headings, metadata, or heading hierarchy. The changes are purely inline label updates that maintain the existing article structure. No new content was added that would require additional YAML metadata or heading adjustments.
  • Style Compliance: 10/10 - The changes follow all naming conventions precisely. Button names use bold formatting and Sentence case (Save), matching the exact UI label (common.save). No quotation marks, no paraphrasing, no synonym substitution. The distinction between the Save button (entry point) and the "Save view" page title is correctly handled per the PR's verification against source code.

Key Findings

  • All four changes consistently update the same label across articles, maintaining deterministic writing (no stylistic variation between files).
  • The surrounding text appropriately shifts from "custom report"/"custom version" to "custom view" to match the renamed feature concept, which is a good complementary update.
  • The PR description is thorough in documenting what was and was not changed, including verification against source code -- a strong practice for UI-label alignment PRs.
  • One observation: The cross-link in View-the-Top-Categories-report.md and View-the-Top-Merchants-report.md uses a full URL (https://help.expensify.com/...) rather than a relative link. Per the Cross-Linking Standards in HELP_AUTHORING_GUIDELINES.md Section 7, relative links are required. However, this is pre-existing (not part of this diff), so it is not scored against this PR.

Recommendations

  • No blocking issues. The changes are correct and ready to merge.
  • Consider removing the trailing whitespace on line 148 of How-to-Use-Insights-in-Expensify.md (minor).
  • For a future PR, consider converting the full URLs in the cross-links of the Top Categories and Top Merchants articles to relative links per governance rules.

Files Reviewed

  • docs/articles/new-expensify/insights/How-to-Use-Insights-in-Expensify.md -- Button label updated correctly.
  • docs/articles/new-expensify/insights/View-the-Top-Categories-report.md -- Button label updated correctly.
  • docs/articles/new-expensify/insights/View-the-Top-Merchants-report.md -- Button label updated correctly.
  • docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md -- Button label updated correctly.

Note: This review assessed only the proposed changes (diff), not unchanged portions of the files.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I checked the CI status and there are no failing checks on this PR. Every CI check is passing:

  • CLA, actionlint, build, dryRun, spellcheck, validate, validateImmutableActionRefs, validateSchemas, verify, verifySignedCommits, security/snyk

The only check not yet showing green is review (the PR Reviews with Claude Code action), which is an automated review job that was still in progress, not a failure. It resolves on its own and doesn't gate the PR.

It's likely the checks were simply still running (e.g. build was pending) at the time of the request and have since completed successfully. No fix is needed — nothing is broken.

@stephanieelliott
stephanieelliott requested a review from a team June 9, 2026 03:57
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @greg-schroeder

@melvin-bot
melvin-bot Bot requested review from greg-schroeder and removed request for a team June 9, 2026 03:58
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@stephanieelliott stephanieelliott self-assigned this Jun 9, 2026
@stephanieelliott

Copy link
Copy Markdown
Contributor

Bump @greg-schroeder

@stephanieelliott
stephanieelliott removed the request for review from mdneyazahmad June 18, 2026 22:01
@greg-schroeder
greg-schroeder merged commit 4e67c82 into main Jun 19, 2026
17 checks passed
@greg-schroeder
greg-schroeder deleted the docs-91691-save-view branch June 19, 2026 09:10
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/greg-schroeder in version: 9.4.16-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.16-5 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants