[No QA] Docs updates for E/A#91691 Rename Save search button to Save view#92190
Conversation
Reflects the UI rename in E/A#91691 where the saved-view button and page title changed from "Save search" to "Save view". Co-authored-by: mdneyazahmad <mdneyazahmad@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
mdneyazahmad
left a comment
There was a problem hiding this comment.
Is it just Save?
In the docs it says Save search and updates to Save view after we update in this PR #91691
This comment has been minimized.
This comment has been minimized.
|
Good catch @mdneyazahmad! I've updated the file to match the UI |
|
A preview of your ExpensifyHelp changes have been deployed to https://e1ace7d5.helpdot.pages.dev ⚡️ Updated articles: |
| 1. Go to the **Spend** or **Expenses** tab. | ||
| 2. Use filters to adjust the category grouping or timeframe. | ||
| 3. Apply filters and click **Save search** to save your custom report. | ||
| 3. Apply filters and click **Save** to save your custom view. |
There was a problem hiding this comment.
Step formatting: This step combines two distinct actions ("Apply filters" and "click Save"). Per the step formatting standard (HELP_AUTHORING_GUIDELINES.md Section 5), steps should be sequential and each describe a single action. Consider splitting into two steps:
- Apply filters.
- Click Save to save your custom view.
HelpDot Documentation ReviewOverall AssessmentThis PR updates four help articles to replace the old Save search button label with Save, aligning documentation with the UI change from #91691. The changes are minimal, targeted, and well-scoped -- only the explicit button-label references were updated, while conceptual "saved search" terminology was intentionally left intact where the app still uses it. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This review assessed only the proposed changes (diff), not unchanged portions of the files. |
|
I checked the CI status and there are no failing checks on this PR. Every CI check is passing:
The only check not yet showing green is It's likely the checks were simply still running (e.g. |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
|
@greg-schroeder Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Bump @greg-schroeder |
|
🚀 Deployed to staging by https://github.com/greg-schroeder in version: 9.4.16-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/blimpich in version: 9.4.16-5 🚀
|
Summary
Follow-up to the UI rename in #91691, which changed the saved-view page title and submit button from Save search to Save view (the
search.saveSearch→search.saveViewtranslation key).This updates the help site articles that referenced the old Save search button label so they match the current UI. Only explicit button-label references were changed — the Saved searches feature name and other "saved search" terminology were left untouched because the app still uses that wording (e.g. the Saved menu and "Delete saved search").
Files changed
docs/articles/new-expensify/insights/How-to-Use-Insights-in-Expensify.md— "Click Save search" → "Click Save view"docs/articles/new-expensify/insights/View-the-Top-Merchants-report.md— "click Save search" → "click Save view"docs/articles/new-expensify/insights/View-the-Top-Categories-report.md— "click Save search" → "click Save view"docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md— "clicking Save search" → "clicking Save view"Intentionally not changed
Using-Reports-in-New-Expensify.md— the "How to save a search" steps reference the Save entry button (common.save), which is unchanged, and the conceptual "saved searches" wording, which the app still uses.Verification
Verified against the merged source in #91691:
search.saveView= "Save view" (src/pages/Search/SearchSavePage.tsx).common.save) (src/components/Search/SearchPageHeader/SearchSaveButton.tsx).@mdneyazahmad, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.