refactor: update isConciergeChatReport usage across multiple components by cretadn22 · Pull Request #92135 · Expensify/App

cretadn22 · 2026-05-30T08:34:11Z

Explanation of Change

Fixed Issues

$ #66411
PROPOSAL:

Tests

Open any workspace chat.
Click the Concierge icon.
Verify that the Concierge side panel displays on the right, featuring a close (X) button in the header.

Verify that no errors appear in the JS console

Offline tests

Open any workspace chat.
Click the Concierge icon.
Verify that the Concierge side panel displays on the right, featuring a close (X) button in the header.

QA Steps

Open any workspace chat.
Click the Concierge icon.
Verify that the Concierge side panel displays on the right, featuring a close (X) button in the header.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Screen.Recording.2026-06-03.at.21.28.22.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-05-30T08:34:17Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c22353e3d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

codecov · 2026-05-30T08:39:23Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../OptionRowLHN/OptionRow/ProductTrainingTooltip.tsx	`100.00% <100.00%> (ø)`
src/hooks/useBankAccountUnlockEffect.ts	`85.71% <100.00%> (ø)`
src/pages/inbox/AccountManagerBanner.tsx	`100.00% <100.00%> (ø)`
src/pages/inbox/HeaderView.tsx	`95.27% <100.00%> (ø)`
src/pages/DynamicReportDetailsPage.tsx	`56.11% <0.00%> (ø)`
src/pages/ProfilePage.tsx	`0.00% <0.00%> (ø)`
... and 11 files with indirect coverage changes

joekaufmanexpensify · 2026-06-01T21:48:56Z

No product review needed

cretadn22 · 2026-06-02T04:01:26Z

@DylanDylann Can you review this PR?

DylanDylann · 2026-06-04T10:07:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-06-05.at.09.58.14.mov

DylanDylann · 2026-06-09T07:01:37Z

@rlinoz Kindly bump

rlinoz · 2026-06-09T14:10:55Z

Thank you!

github-actions · 2026-06-09T14:33:31Z

🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-09T14:39:56Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #92135.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-af710b6086b-79c0e20-6eee618cad6da24774a8c7a4d862d658bfc3f054/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-af710b6-79c0e20-ffffd16bc5e6fe53301983f6b02d39b14d5b19b9/index.html

Web 🕸️
https://92135.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-10T01:01:06Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.2-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T01:03:47Z

Help site review: no documentation changes required

I reviewed the changes in this PR against Expensify's help site files under App/docs/articles.

Conclusion: No help site updates are needed.

This is an internal code refactor. The only change is threading a conciergeReportID argument into existing isConciergeChatReport(...) calls across six components:

src/components/LHNOptionsList/OptionRowLHN/OptionRow/ProductTrainingTooltip.tsx
src/hooks/useBankAccountUnlockEffect.ts
src/pages/DynamicReportDetailsPage.tsx
src/pages/ProfilePage.tsx
src/pages/inbox/AccountManagerBanner.tsx
src/pages/inbox/HeaderView.tsx

There is no change to user-facing behavior, UI labels, feature names, tabs, settings, or buttons — the Concierge side panel, banners, tooltips, and report details continue to behave exactly as before. Since help site articles document product behavior (not implementation details like function signatures), no article requires an update, and no draft docs PR was created.

Because no documentation changes are required, there is no help site PR to link or review. If you believe a specific article should be updated, let me know which behavior changed and I'll revisit.

@cretadn22

OSBotify · 2026-06-10T19:54:27Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.4-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-10T19:57:53Z

🤖 Help site review: No documentation changes required.

This PR is a pure internal refactor. It updates the isConciergeChatReport() utility to take an explicit conciergeReportID argument and threads that value through all six call sites:

src/components/LHNOptionsList/OptionRowLHN/OptionRow/ProductTrainingTooltip.tsx
src/hooks/useBankAccountUnlockEffect.ts
src/pages/DynamicReportDetailsPage.tsx
src/pages/ProfilePage.tsx
src/pages/inbox/AccountManagerBanner.tsx
src/pages/inbox/HeaderView.tsx

There is no change to user-facing behavior — no new feature, no renamed/added UI labels, tabs, settings, or buttons. The Concierge side-panel close button, profile page, and account-manager banner all behave exactly as before; only the internal mechanism for detecting a Concierge chat changed.

Since the help site (App/docs/articles) documents product behavior rather than implementation details, nothing there needs to be updated. No draft docs PR was created.

@cretadn22, since this is an internal refactor with no behavior change, there is no help site PR to review. If you believe any product behavior actually changed here, let me know and I'll create the docs PR.

OSBotify · 2026-06-10T23:18:34Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

refactor: update isConciergeChatReport usage across multiple components

5c22353

cretadn22 requested review from a team as code owners May 30, 2026 08:34

melvin-bot Bot assigned cretadn22 May 30, 2026

melvin-bot Bot requested review from DylanDylann and joekaufmanexpensify and removed request for a team and DylanDylann May 30, 2026 08:34

melvin-bot Bot removed the request for review from a team May 30, 2026 08:34

chatgpt-codex-connector Bot reviewed May 30, 2026

View reviewed changes

Comment thread src/pages/DynamicReportDetailsPage.tsx

joekaufmanexpensify removed their request for review June 1, 2026 21:49

DylanDylann reviewed Jun 2, 2026

View reviewed changes

Comment thread src/components/LHNOptionsList/OptionRowLHN/OptionRow/ProductTrainingTooltip.tsx

cretadn22 added 2 commits June 3, 2026 21:16

Merge branch 'main' into

4c5fe0c

Add conciergeReportID to DynamicReportDetailsPage component

3149f0c

DylanDylann approved these changes Jun 5, 2026

View reviewed changes

melvin-bot Bot requested a review from rlinoz June 5, 2026 02:58

rlinoz approved these changes Jun 9, 2026

View reviewed changes

rlinoz merged commit af710b6 into Expensify:main Jun 9, 2026
34 checks passed

OSBotify mentioned this pull request Jun 10, 2026

Deploy Checklist: New Expensify 2026-06-10 #93122

Closed

70 tasks

melvin-bot Bot mentioned this pull request Jun 10, 2026

[Due for payment 2026-07-21] [Partial Payment made] Remove Onyx.connect() for the key: ONYXKEYS.CONCIERGE_REPORT_ID in src/libs/ReportUtils.ts #66411

Open

Uh oh!

Conversation

cretadn22 commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 30, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codecov Bot commented May 30, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

joekaufmanexpensify commented Jun 1, 2026

Uh oh!

cretadn22 commented Jun 2, 2026

Uh oh!

Uh oh!

DylanDylann commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

DylanDylann commented Jun 9, 2026

Uh oh!

rlinoz commented Jun 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Help site review: no documentation changes required

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

MelvinBot commented Jun 10, 2026

Uh oh!

OSBotify commented Jun 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cretadn22 commented May 30, 2026 •

edited

Loading

codecov Bot commented May 30, 2026 •

edited by github-actions Bot

Loading

DylanDylann commented Jun 4, 2026 •

edited

Loading