InteractionManager migration - ContactMethodDetailsPage#92050
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
JmillsExpensify
left a comment
There was a problem hiding this comment.
No product review required.
Reviewer Checklist
Screenshots/VideosiOS: NativeSimulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-06-03.at.16.18.27.moviOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-06-03.at.16.23.37.movMacOS: Chrome / SafariScreen.Recording.2026-06-03.at.16.08.39.mov |
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM
This is a clean, well-reasoned migration. The turnOnDeleteModal change is safe because the modal promise already resolves post-animation. The TransitionTracker migration in onEntryTransitionEnd follows the project's established pattern and is safer for navigation timing than InteractionManager. No blocking issues ✅
|
🚧 @roryabraham has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.3.99-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 No help site changes required. I reviewed the changes in this PR against the help site articles under Why: This PR is a purely internal refactor of focus-timing logic in The help site documents user-facing features and workflows (e.g. adding/verifying contact methods), not internal animation/focus-timing mechanisms. Nothing documented there changes as a result of this PR, so no draft PR was created.
If you believe a behavior change here does warrant a docs update, reply with |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀
|
Explanation of Change
Removes two redundant
InteractionManager.runAfterInteractionswrappers inContactMethodDetailsPage.await showRemoveContactMethodModal(): the Promise already resolves post-animation (viaConfirmModalWrapper.handleModalHide→ModalContext.closeModal), so deferringfocusLastSelectedfurther is unnecessary.onEntryTransitionEnd: replacingInteractionManagerwithTransitionTracker.runAfterTransitions()Fixed Issues
$ #71913
$ #83069
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-05-29.at.10.11.34.mov
Android: mWeb Chrome
Screen.Recording.2026-05-29.at.10.10.37.mov
Screen.Recording.2026-05-29.at.10.03.44.mov
iOS: Native
Screen.Recording.2026-05-29.at.10.12.07.mov
iOS: mWeb Safari
Screen.Recording.2026-05-29.at.10.10.10.mov
Screen.Recording.2026-05-29.at.10.05.08.mov
MacOS: Chrome / Safari
Screen.Recording.2026-06-02.at.08.42.00.mov