Fix Continue setup and Start over button do not appear after returning to initial page#91939
Conversation
|
@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
trjExpensify
left a comment
There was a problem hiding this comment.
Makes sense to me. CC: @joekaufmanexpensify for vis!
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-05-29.at.14.05.20.movAndroid: mWeb ChromeScreen.Recording.2026-05-29.at.13.56.21.moviOS: HybridAppScreen.Recording.2026-05-29.at.14.02.35.moviOS: mWeb SafariScreen.Recording.2026-05-29.at.13.57.23.movMacOS: Chrome / SafariScreen.Recording.2026-05-29.at.13.53.15.mov |
|
🚧 @arosiclair has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 9.3.90-0 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Help site review: no changes required. I reviewed the change in this PR against the help articles under What this PR does: A one-line fix to internal logic in Why no docs update is needed:
No draft help site PR was created since the existing articles already reflect the (now-restored) behavior. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.90-3 🚀
|
Explanation of Change
In the Wallet bank-account flow (Account → Wallet → Add bank account),
policyIDis not passed in the route params. Once the user partially completes manual bank setup, the backend populatesachData.policyIDwith a real ID. When the user navigates back to the entry point,hasInProgressVBBAcomparedachData.policyID(a real ID) againstpolicyIDParam(undefined) and bailed out, so "Continue setup" / "Start over" never rendered — the user saw "Log into your bank" / "Connect manually" instead.This is a regression from #88193, which moved the USD flow to URL-based navigation and removed the inline
setShouldShowContinueSetupButton(true)path that previously handled this case.The fix skips the
policyIDcomparison when the caller doesn't pass apolicyID(the Wallet flow has no policy context), while preserving the guard for workspace-scoped callers.Fixed Issues
$ #91884
PROPOSAL: N/A
Tests
Precondition:
Offline tests
Same as in the Tests section.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as in the Tests section.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mp4
Android: mWeb Chrome
android_web.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
ios_web.mov
MacOS: Chrome / Safari
web.mp4