Public room not display in LHN after anon user login from a thread of public room by nkdengineer · Pull Request #91931 · Expensify/App

nkdengineer · 2026-05-28T08:24:46Z

Explanation of Change

Public room not display in LHN after anon user login from a thread of public room

Fixed Issues

$ #90536
PROPOSAL: #90536 (comment)

Tests

Navigate to this link - https://staging.new.expensify.com/r/1540486774487195 as anon user
Click on any thread on the public room
Click on Sign in button at bottom-right corner
Log in with a new account and complete onboarding flow
Click on Inbox tab
1. Verify that the public room appears in LHN

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as test

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2026-05-28.at.15.14.17.mov

Android: mWeb Chrome

Screen.Recording.2026-05-28.at.15.20.15.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2026-05-28.at.15.18.46.mov

MacOS: Chrome / Safari

Screen.Recording.2026-05-28.at.15.12.10.mov

nkdengineer · 2026-05-28T08:25:20Z

I have an login issue with IOS native device, will update later.

codecov · 2026-05-28T08:36:47Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/ONYXKEYS.ts	`100.00% <ø> (ø)`
src/libs/actions/Report/index.ts	`69.37% <0.00%> (-0.08%)`	⬇️
src/pages/inbox/ReportFetchHandler.tsx	`85.18% <66.66%> (-1.09%)`	⬇️
... and 12 files with indirect coverage changes

melvin-bot · 2026-05-28T08:45:14Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3049ade856

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-28T08:47:27Z

    RAM_ONLY_IS_CHECKING_PUBLIC_ROOM: 'isCheckingPublicRoom',

+    /** The report ID of the public room that the user is currently viewing */
+    RAM_ONLY_VIEWING_PUBLIC_ROOM_REPORT_ID: 'ramOnlyViewingPublicRoomReportID',


Register the viewing public room key as RAM-only

This new key is named and used as transient state, but it is not added to ramOnlyKeys in src/setup/index.ts (I checked the Onyx init list there). As a result, the last public room ID can be persisted across reloads/sessions, and joinPublicRoomIfNeeded() may later call openReport() for a stale room when an anonymous user signs in from an unrelated route. Please add this key to the Onyx RAM-only configuration or otherwise clear it after use.

Useful? React with 👍 / 👎.

I renamed the key. And this is cleared when we sign out and only set for anonymous user so it's safe.

hungvu193 · 2026-05-31T15:32:53Z

@MelvinBot Assign me to this PR since I'm the C+ of original issue.

MelvinBot · 2026-05-31T15:34:16Z

Done — assigned you to this PR, hungvu193. Verified you're an assignee on the linked issue #90536 as C+.

hungvu193 · 2026-05-31T15:48:53Z

@MelvinBot Add me to the reviewer of this PR.

MelvinBot · 2026-05-31T15:50:20Z

Done — added you as a reviewer, hungvu193.

hungvu193 · 2026-06-01T03:25:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-06-01.at.12.44.36.mov

Android: mWeb Chrome

Screen.Recording.2026-06-01.at.12.46.55.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2026-06-01.at.10.28.59.mov

MacOS: Chrome / Safari

Screen.Recording.2026-06-01.at.10.23.03.mov

hungvu193 · 2026-06-01T03:45:46Z

@nkdengineer I'm not able to test on IOS native 🤔 , do you face the same issue?

Screen.Recording.2026-06-01.at.10.45.20.mov

nkdengineer · 2026-06-02T08:25:37Z

@hungvu193 I got the error like this on IOS native.

Screen.Recording.2026-06-02.at.15.25.18.mov

hungvu193 · 2026-06-02T14:22:49Z

@nkdengineer Can you double check if we also get this issue one main?

JmillsExpensify

LGTM though for the record, I don't think we should spend time on this.

nkdengineer · 2026-06-03T09:29:53Z

@hungvu193 It works now.

github-actions · 2026-06-03T19:17:22Z

🚧 @blimpich has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-03T19:25:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91931.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1a25481fadb-aefc2a3-0a15d54e8a0f72a72459bb1764053c09d872d9c1/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1a25481-aefc2a3-f3d85ee3c63385f692362ca5796488c93228c8ac/index.html

Web 🕸️
https://91931.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-04T07:57:19Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.3.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-06-04T07:58:55Z

Help site review — no changes required

I reviewed this PR against the help site articles under App/docs/articles and no documentation updates are required.

Why: This is a bug fix that restores intended behavior. The change tracks the public room report ID while an anonymous user is viewing a public room (or one of its threads), then re-fetches that report after the user signs in so the public room appears in the LHN as expected. It introduces no new feature, no new UI, no renamed labels/tabs/buttons, and no change to any documented user-facing workflow.

Review details

The linked issue (Expensify/App#90536) describes a regression where the expected result ("Public room should display in LHN") was not happening. The PR simply makes the existing/expected behavior work correctly.
The only help article that mentions public rooms — Chat-Features-and-Moderation-Tools.md — covers moderation only, not LHN visibility or the anonymous-sign-in flow. Nothing in that article (or elsewhere in App/docs/articles) documents the behavior this PR touches, so there is nothing to update.
Changes are purely internal: a new Onyx key (VIEWING_PUBLIC_ROOM_REPORT_ID), a setter action, and effect logic in ReportFetchHandler.tsx.

Since no help site changes are needed, I did not create a draft docs PR.

@hungvu193, please confirm you agree that no help site changes are required for this PR. If you believe a documentation update is warranted, let me know what behavior should be documented and I'll create the draft PR.

OSBotify · 2026-06-05T17:50:53Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

nkdengineer added 3 commits May 14, 2026 16:31

fix public

30c3b50

resolve conflict

ff06f2c

refactor code

d8f387f

melvin-bot Bot assigned nkdengineer May 28, 2026

run prettier

3049ade

nkdengineer marked this pull request as ready for review May 28, 2026 08:45

nkdengineer requested review from a team as code owners May 28, 2026 08:45

melvin-bot Bot requested review from JmillsExpensify and hungvu193 and removed request for a team and hungvu193 May 28, 2026 08:45

melvin-bot Bot removed the request for review from a team May 28, 2026 08:45

chatgpt-codex-connector Bot reviewed May 28, 2026

View reviewed changes

rename the key

3ffef6e

MelvinBot assigned hungvu193 May 31, 2026

MelvinBot requested a review from hungvu193 May 31, 2026 15:50

Merge branch 'main' into fix/90536

7680846

JmillsExpensify approved these changes Jun 3, 2026

View reviewed changes

Merge branch 'main' into fix/90536

5e53f96

hungvu193 approved these changes Jun 3, 2026

View reviewed changes

melvin-bot Bot requested a review from blimpich June 3, 2026 09:44

blimpich approved these changes Jun 3, 2026

View reviewed changes

blimpich merged commit 1a25481 into Expensify:main Jun 3, 2026
32 checks passed

github-actions Bot mentioned this pull request Jun 3, 2026

Investigate workflow job failing on main: test / test (job 5) #92570

Closed

OSBotify mentioned this pull request Jun 4, 2026

Deploy Checklist: New Expensify 2026-06-04 #92626

Closed

100 tasks

applause-bot Bot mentioned this pull request Jun 4, 2026

[$250] Anon user can't reach public room #92672

Open

7 tasks

melvin-bot Bot mentioned this pull request Jun 5, 2026

[Due for payment 2026-06-12] [$250] Public room - Public room not display in LHN after anon user login from a thread of public room #90536

Closed

7 tasks

This was referenced Jun 9, 2026

Fix/92672 anon public room lhn #93048

Closed

fix: keep public room in LHN for anonymous users #93054

Open

Uh oh!

Conversation

nkdengineer commented May 28, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

nkdengineer commented May 28, 2026

Uh oh!

codecov Bot commented May 28, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 28, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 28, 2026

Choose a reason for hiding this comment

Uh oh!

nkdengineer May 28, 2026

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented May 31, 2026

Uh oh!

MelvinBot commented May 31, 2026

Uh oh!

hungvu193 commented May 31, 2026

Uh oh!

MelvinBot commented May 31, 2026

Uh oh!

hungvu193 commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hungvu193 commented Jun 1, 2026

Uh oh!

nkdengineer commented Jun 2, 2026

Uh oh!

hungvu193 commented Jun 2, 2026

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Jun 3, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

OSBotify commented Jun 4, 2026

Uh oh!

MelvinBot commented Jun 4, 2026

Help site review — no changes required

Uh oh!

OSBotify commented Jun 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented May 28, 2026 •

edited by github-actions Bot

Loading

hungvu193 commented Jun 1, 2026 •

edited

Loading