[CP Staging] Fix: Gate Copy Settings behind bulkEditWorkspaces beta by fedirjh · Pull Request #91819 · Expensify/App

fedirjh · 2026-05-27T10:13:04Z

Explanation of Change

The "Copy settings" option in the workspace 3-dot menu is currently available to all admin users. This PR gates it behind the new bulkEditWorkspaces beta so the feature remains hidden until it's ready for wider rollout.

Adds BULK_EDIT_WORKSPACES: 'bulkEditWorkspaces' to CONST.BETAS
Checks isBetaEnabled(CONST.BETAS.BULK_EDIT_WORKSPACES) before showing the "Copy settings" menu item in WorkspacesListPage

Fixed Issues

$ https://expensify.slack.com/archives/C01GTK53T8Q/p1779860551016579
$ #91791
$ #91792
$ #91793
$ #91805
$ #91821
$ #91825
$ #91827
$ #91830
$ #91833
PROPOSAL:

Tests

Preconditions: Have at least two workspaces where you are an admin.

Without the beta:

Navigate to https://staging.new.expensify.com/
Go to Workspaces
Click on the 3-dot menu of any workspace
Verify there is no "Copy settings" option

With the beta (bulkEditWorkspaces):

Enable the bulkEditWorkspaces beta on your account
Go to Workspaces
Click on the 3-dot menu of any workspace
Verify the "Copy settings" option is shown

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

github-actions · 2026-05-27T10:25:14Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

fedirjh · 2026-05-27T10:53:34Z

It's passing in the adhoc build :

melvin-bot · 2026-05-27T10:54:15Z

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2026-05-27T11:04:37Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

mountiny

Thanks!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 917b6552a5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-05-27T11:15:55Z

            const hasEligibleCopyTarget = candidates.length > 1 || (candidates.length === 1 && candidates.at(0) !== item.policyID);

-            if (hasEligibleCopyTarget) {
+            if (hasEligibleCopyTarget && isBetaEnabled(CONST.BETAS.BULK_EDIT_WORKSPACES)) {


Block direct Copy Settings routes behind beta

When bulkEditWorkspaces is disabled, this only removes the menu entry, but the deep link remains registered at policy/:policyID/copy-settings (src/ROUTES.ts:2954) and the page wrapper still only checks admin access (CopyPolicySettingsSelectWorkspacesPage.tsx:167). Any admin without the beta who has or guesses the URL can still open the Copy Settings flow, so the feature is not actually gated; please also block the Copy Settings routes/pages with the same beta check, as other beta-gated workspace pages do.

Useful? React with 👍 / 👎.

github-actions · 2026-05-27T11:22:06Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

[CP Staging] Fix: Gate Copy Settings behind bulkEditWorkspaces beta (cherry picked from commit 7924a11) (cherry-picked to staging by mountiny)

github-actions · 2026-05-27T11:27:57Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91819.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-7924a11b6d0-95249bd-eb6ce27647811de3186bec41d296bcc1ae7a5caf/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-7924a11-95249bd-d498a8b9e369ee0bc9c4a448829897eaa14f37c6/index.html

Web 🕸️
https://91819.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-27T11:33:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-05-27T12:09:24Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.83-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-27T12:13:10Z

I reviewed the changes in this PR and checked the help site articles under App/docs/articles.

No help site changes are required.

This PR gates the existing "Copy settings" option behind the bulkEditWorkspaces beta flag — it restricts visibility of an existing feature rather than introducing new user-facing behavior. There are no existing help site articles that reference "Copy settings" or the copy-policy-settings flow, so nothing needs to be updated or added.

The existing Duplicate Workspace article covers a separate feature and is unaffected by this change.

Once the bulkEditWorkspaces beta is fully rolled out and the feature becomes generally available, a new help site article for "Copy settings" may be warranted at that time.

@fedirjh, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-27T17:28:51Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-05-27T17:58:37Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.84-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-27T18:03:28Z

I reviewed the changes in this PR and the help site articles under App/docs/articles.

Finding: No help site changes are required.

This PR gates the "Copy settings" option behind a bulkEditWorkspaces beta flag — it hides an unreleased feature, not a user-facing behavior change. There is no existing help article for "Copy settings." The only related article (docs/articles/new-expensify/workspaces/Duplicate-Workspace.md) covers the separate "Duplicate Workspace" feature, which is unaffected by this change.

A help site article for "Copy settings" should be created when the feature exits beta and becomes generally available.

@fedirjh, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T10:51:43Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.86-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T10:58:41Z

🤖 I reviewed the changes in this PR and checked the help site files under App/docs/articles.

No help site changes are required.

This PR gates the "Copy settings" menu item behind the bulkEditWorkspaces beta. The "Copy settings" feature (which copies workspace settings to other existing workspaces) is not currently documented on the help site. The existing Duplicate Workspace article covers a different feature (creating a new workspace from an existing one) and is unaffected by this change.

Since "Copy settings" is being placed behind a beta flag, it should not be documented on the help site until it's generally available.

@fedirjh, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T13:48:59Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.3.88-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-28T13:51:14Z

No help site changes are required for this PR.

Reason: This PR gates the "Copy settings" menu item behind the bulkEditWorkspaces beta flag, hiding a feature that isn't publicly available yet. There are no existing help site articles documenting the "Copy settings" feature (the existing Duplicate-Workspace.md article covers a separate feature). Since the feature is behind a beta gate and not user-facing, no documentation updates are needed at this time. Documentation should be created when the feature is released to all users.

@fedirjh, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-28T20:41:21Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.88-2 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

feat: gate Copy Settings behind bulkEditWorkspaces beta

917b655

melvin-bot Bot assigned fedirjh May 27, 2026

fedirjh requested a review from mountiny May 27, 2026 10:21

mountiny changed the title ~~Fix: Gate Copy Settings behind bulkEditWorkspaces beta~~ [CP Staging] Fix: Gate Copy Settings behind bulkEditWorkspaces beta May 27, 2026

This comment has been minimized.

Sign in to view

fedirjh marked this pull request as ready for review May 27, 2026 10:53

fedirjh requested review from a team as code owners May 27, 2026 10:53

melvin-bot Bot requested review from JmillsExpensify and carlosmiceli and removed request for a team May 27, 2026 10:53

melvin-bot Bot removed the request for review from a team May 27, 2026 10:54

mountiny approved these changes May 27, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed May 27, 2026

View reviewed changes

mountiny merged commit 7924a11 into Expensify:main May 27, 2026
46 of 47 checks passed

OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 27, 2026

OSBotify mentioned this pull request May 27, 2026

Deploy Checklist: New Expensify 2026-05-26 #91756

Closed

54 tasks

fedirjh deleted the fedirjh/copy-settings-beta-gate branch May 27, 2026 12:07

Uh oh!

Conversation

fedirjh commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

This comment has been minimized.

fedirjh commented May 27, 2026

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

mountiny commented May 27, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

MelvinBot commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

MelvinBot commented May 27, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

MelvinBot commented May 28, 2026

Uh oh!

OSBotify commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

fedirjh commented May 27, 2026 •

edited

Loading