[Payment due @situchan] [No QA] Victory Chart: Support VictoryGroup by s77rt · Pull Request #91550 · Expensify/App

s77rt · 2026-05-24T23:00:42Z

Explanation of Change

Added support to <VictoryGroup />

Fixed Issues

https://github.com/Expensify/Expensify/issues/636601
PROPOSAL:

Tests

Open report
Add comment
Note reportID and reportActionID
Run code:

const html2 = `<victorychart horizontal domain="{y: [0, 18000]}" domainpadding="{x: 44, y: 16}" height="464" width="680" padding="{top: 92, bottom: 84, left: 150, right: 32}" style="{ parent: { backgroundColor: '#F7F2EF', borderRadius: 16, width: '100%', maxWidth: 680, }, }"><victorylabel x="32" y="40" text='Top employees by spend' style="{ fill: '#002E22', fontSize: 17, fontWeight: 700, fontFamily: 'Expensify Neue', }"/><victorylabel x="32" y="62" text='As of: May 6, 12:49 PM PT' style="{ fill: '#73857E', fontSize: 11, fontWeight: 400, fontFamily: 'Expensify Neue', }"/><victoryaxis tickformat="(name) => (name.length > 16 ? name.slice(0, 15) + '…' : name)" style="{ axis: {stroke: 'transparent'}, ticks: {stroke: 'transparent'}, grid: {stroke: 'transparent'}, tickLabels: { fill: '#73857E', fontSize: 11, fontWeight: 500, fontFamily: 'Expensify Neue', padding: 24, }, }"/><victoryaxis dependentaxis tickvalues="[0, 3000, 6000, 9000, 12000, 15000, 18000]" tickformat="['$0', '$3,000', '$6,000', '$9,000', '$12,000', '$15,000', '$18,000']" style="{ axis: {stroke: 'transparent'}, ticks: {stroke: 'transparent'}, grid: {stroke: '#E6E1DA', strokeWidth: 1}, tickLabels: { fill: '#73857E', fontSize: 11, fontWeight: 500, fontFamily: 'Expensify Neue', padding: 8, }, }"/><victorygroup horizontal offset="18"><victorybar barwidth="16" cornerradius="{top: 8, bottom: 0}" style="{data: {fill: '#13C96B'}}" data="[ {x: 'Ethan Brooks', y: 9450}, {x: 'Sofia Ramirez', y: 10500}, {x: 'Michelina Della Donna', y: 11900}, {x: 'Priya Patel', y: 13400}, {x: 'Alex Chen', y: 14300}, ]"/><victorybar barwidth="16" cornerradius="{top: 8, bottom: 0}" style="{data: {fill: '#1E90F2'}}" data="[ {x: 'Ethan Brooks', y: 8800}, {x: 'Sofia Ramirez', y: 10250}, {x: 'Michelina Della Donna', y: 11250}, {x: 'Priya Patel', y: 13900}, {x: 'Alex Chen', y: 12500}, ]"/></victorygroup><victorylegend x="250" y="416" orientation='horizontal' gutter="42" symbolspacer="10" style="{ labels: { fill: '#002E22', fontSize: 13, fontWeight: 500, fontFamily: 'Expensify Neue', }, }" data="[ {name: 'This month', symbol: {type: 'circle', fill: '#13C96B', size: 6}}, {name: 'Last month', symbol: {type: 'circle', fill: '#1E90F2', size: 6}}, ]"/></victorychart>`;

Onyx.merge("reportActions_[report ID]", {
    "[report action ID]": { message: [{ html: html2, type: "COMMENT" }] },
});

Verify the chart looks same as follow

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

n/a

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

s77rt · 2026-05-24T23:06:59Z

+            {barChildren.map((child) => {
+                const yKey = getYKey(child);
+                const {nodeStyles} = parseStyles(child);
+                return (
+                    <BarGroup.Bar
+                        key={`${child.tagName ?? 'node'}-${yKey}`}
+                        color={nodeStyles.fill ?? DEFAULT_CHART_COLOR}
+                        points={points[yKey]}
+                    />
+                );
+            })}


FWIW, I tried wrapping this a separate component but it failed because BarGroup only renders children of type BarGroup.Bar

s77rt · 2026-05-25T16:58:56Z

+const BAR_BETWEEN_GROUP_PADDING = 2 / 3;
+const BAR_WITHIN_GROUP_PADDING = BAR_INNER_PADDING;


I may change these values when adding horizontal charts. VN uses % values for the padding, unlike VC offset param which is in pixels.

I chose 2/3 as that what appeared closest to https://virtual-cfo-charts.netlify.app/ (after removing horizontal attribute)

melvin-bot · 2026-05-25T17:03:39Z

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan · 2026-05-25T17:06:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d710c6e01

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-25T17:09:00Z

+            betweenGroupPadding={BAR_BETWEEN_GROUP_PADDING}
+            withinGroupPadding={BAR_WITHIN_GROUP_PADDING}


Parse VictoryGroup offset when computing bar spacing

VictoryChartBarGroup hard-codes betweenGroupPadding/withinGroupPadding and never reads tnode.attributes.offset, so grouped charts that rely on different <victorygroup offset="..."> values will render with incorrect spacing. This commit adds support for victorygroup, but without mapping offset the layout is only correct for one fixed spacing profile and diverges from the source chart markup.

Useful? React with 👍 / 👎.

Yeah I noted this here #91550 (comment) I don't know yet how to get % spacing from the offset. NAB. I will work on the horizontal support and see what can be done for this if any

codecov · 2026-05-25T17:12:23Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ents/HTMLEngineProvider/BaseHTMLEngineProvider.tsx	`83.33% <100.00%> (+0.21%)`	⬆️
...oryChartRenderer/components/VictoryChartSeries.tsx	`18.18% <ø> (ø)`
...yChartRenderer/components/VictoryChartBarGroup.tsx	`15.78% <15.78%> (ø)`
... and 8 files with indirect coverage changes

situchan · 2026-05-25T17:15:10Z

+    );
+}
+
+VictoryCharBarGroup.displayName = 'VictoryCharBarGroup';


No need displayName

As per guideline

Hmm yeah, all Victory Chart components have this and need to be updated. NAB though

situchan · 2026-05-25T17:15:51Z

Here's the expected behavior on resize:

#91540 (comment)

roryabraham

Otherwise LGTM

roryabraham · 2026-05-25T21:02:41Z

                contentModel: HTMLContentModel.block,
            }),
+            victorygroup: HTMLElementModel.fromCustomModel({
+                tagName: 'victorygroup',


I suggest we be more specific, in case Victory adds more group types:

Suggested change

tagName: 'victorygroup',

tagName: 'victorybargroup',

The tag name is from Victory Chart HTML, it's always victorygroup (from <VictoryGroup />)

Don’t we define the victory chart HTML ourselves?

Hmm? No? AFAIK we only define the html tags to be processed by the html render engine

situchan · 2026-05-26T06:06:25Z

@s77rt this is not handled in this PR right?

s77rt · 2026-05-26T06:13:10Z

@situchan Right, those styles issues have same root cause and will be handled in that other issue #91515

situchan

Style issues on narrow width are being fixed separately. Out of scope.

melvin-bot · 2026-05-26T06:22:17Z

🎯 @situchan, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - no internal issue.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

OSBotify · 2026-05-26T14:49:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-05-26T14:58:37Z

🚧 @luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-26T15:14:22Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91550.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-f3621b7d4ba-73f6a85-be5531bed2d9a7a3ff072281cd4c27aaaca3d752/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-f3621b7-73f6a85-535a466a6dfa2a8923e03e2a32a62bf0676dc7a7/index.html

Web 🕸️
https://91550.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-05-26T20:38:48Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.83-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

MelvinBot · 2026-05-26T20:46:10Z

I reviewed the changes in this PR. It adds internal support for <VictoryGroup /> in the Victory Chart HTML rendering engine — specifically a new VictoryChartBarGroup component, a new HTML element model registration, and a series renderer mapping.

No help site changes are required. This is a purely internal/technical change to the chart rendering pipeline. It does not introduce, modify, or remove any user-facing feature, workflow, setting, or UI element that would be documented on the help site.

@s77rt, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-05-27T17:28:26Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot · 2026-05-27T17:29:12Z

🤖 Payment issue created: #91867

s77rt added 2 commits May 24, 2026 23:00

add VictoryCharBarGroup

b8e6dcc

add bar padding

5c2908e

melvin-bot Bot assigned s77rt May 24, 2026

s77rt commented May 24, 2026

View reviewed changes

luacmartins self-requested a review May 25, 2026 14:37

s77rt changed the title ~~Victory Chart: Support VictoryGroup + Polar charts~~ Victory Chart: Support VictoryGroup May 25, 2026

s77rt changed the title ~~Victory Chart: Support VictoryGroup~~ [No QA] Victory Chart: Support VictoryGroup May 25, 2026

s77rt added 3 commits May 25, 2026 17:49

lint

104f247

add victorygroup to cspell.json

0e9f29b

Merge branch 'main' into polar-charts

e4c5906

s77rt commented May 25, 2026

View reviewed changes

ts

5d710c6

s77rt marked this pull request as ready for review May 25, 2026 17:03

s77rt requested review from a team as code owners May 25, 2026 17:03

melvin-bot Bot requested review from heyjennahay and marufsharifi and removed request for a team May 25, 2026 17:03

melvin-bot Bot removed the request for review from a team May 25, 2026 17:03

s77rt requested review from situchan and removed request for marufsharifi May 25, 2026 17:04

chatgpt-codex-connector Bot reviewed May 25, 2026

View reviewed changes

situchan reviewed May 25, 2026

View reviewed changes

roryabraham approved these changes May 25, 2026

View reviewed changes

luacmartins requested changes May 25, 2026

View reviewed changes

Comment thread ...ts/HTMLEngineProvider/HTMLRenderers/VictoryChartRenderer/components/VictoryChartBarGroup.tsx

luacmartins approved these changes May 25, 2026

View reviewed changes

s77rt mentioned this pull request May 26, 2026

[Payment due @situchan] [No QA] Victory Chart: Support horizontal bars #91659

Merged

51 tasks

situchan approved these changes May 26, 2026

View reviewed changes

melvin-bot Bot changed the title ~~[No QA] Victory Chart: Support VictoryGroup~~ [Payment due @situchan] [No QA] Victory Chart: Support VictoryGroup May 26, 2026

luacmartins merged commit f3621b7 into Expensify:main May 26, 2026
85 of 96 checks passed

OSBotify mentioned this pull request May 26, 2026

Deploy Checklist: New Expensify 2026-05-26 #91756

Closed

54 tasks

melvin-bot Bot mentioned this pull request May 27, 2026

[Due for payment 2026-06-03] Payment issue for E/App PR#91550 #91867

Closed

		const BAR_BETWEEN_GROUP_PADDING = 2 / 3;
		const BAR_WITHIN_GROUP_PADDING = BAR_INNER_PADDING;

		betweenGroupPadding={BAR_BETWEEN_GROUP_PADDING}
		withinGroupPadding={BAR_WITHIN_GROUP_PADDING}

Uh oh!

Conversation

s77rt commented May 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 25, 2026

Uh oh!

situchan commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 25, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented May 25, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan commented May 25, 2026

Uh oh!

roryabraham left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

situchan commented May 26, 2026

Uh oh!

s77rt commented May 26, 2026

Uh oh!

situchan left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

github-actions Bot commented May 26, 2026

Uh oh!

OSBotify commented May 26, 2026

Uh oh!

MelvinBot commented May 26, 2026

Uh oh!

OSBotify commented May 27, 2026

Uh oh!

melvin-bot Bot commented May 27, 2026

Uh oh!

s77rt commented May 24, 2026 •

edited

Loading

situchan commented May 25, 2026 •

edited

Loading

codecov Bot commented May 25, 2026 •

edited by github-actions Bot

Loading