Skip to content

[No QA] Fix link for transferring billing ownership#91471

Merged
muttmuure merged 3 commits into
mainfrom
stephanieelliott-patch-1
Jun 9, 2026
Merged

[No QA] Fix link for transferring billing ownership#91471
muttmuure merged 3 commits into
mainfrom
stephanieelliott-patch-1

Conversation

@stephanieelliott

Copy link
Copy Markdown
Contributor

Fixed broken link and duplicated content.

@stephanieelliott stephanieelliott self-assigned this May 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This is a small, focused PR that makes two improvements to the "What to do if you can't update a subscription" section: removing a duplicate paragraph and replacing a placeholder (LINK) with a real relative link. Both changes are positive, but the diff introduces a net regression by removing the grammatically correct duplicate line while keeping the line that contains a grammar error.

Scores Summary

  • Readability: 6/10 - The duplicate removal and real link improve clarity, but the surviving line on line 116 contains a grammar error ("requesting to canceling" instead of "requesting to cancel") that harms readability. The removed duplicate line (old line 117) actually had the correct phrasing.
  • AI Readiness: 8/10 - The real relative link with a fragment anchor (#how-to-transfer-billing-ownership) improves cross-article discoverability. Descriptive anchor text ("transfer billing ownership") supports semantic retrieval.
  • Style Compliance: 8/10 - The cross-link correctly uses a relative path with descriptive anchor text, following the Cross-Linking Standards in HELP_AUTHORING_GUIDELINES.md Section 7. The link is placed after an explanatory sentence (not inside numbered steps), which is compliant.

Key Findings

  • Positive: Removing the duplicate paragraph is a clear improvement and the placeholder (LINK) replacement with a proper relative link is well-formed and compliant with governance rules.
  • Critical: The diff keeps the wrong version of the duplicated line. Old line 116 reads "requesting to canceling your subscription" (grammatically incorrect), while the removed old line 117 read "requesting to cancel your subscription" (correct). The PR should fix line 116 to use "requesting to cancel" instead of "requesting to canceling."
  • Note: There is also an existing placeholder (LINK) on line 108 in the "How to transfer billing ownership" section that remains unresolved, but that is outside the scope of this diff.

Recommendations

  1. Fix the grammar error on line 116: Change "requesting to canceling" to "requesting to cancel" -- this is the highest-priority fix since the diff effectively chose the wrong version of the duplicate to keep.
  2. Consider addressing the remaining (LINK) placeholder on line 108 in a follow-up, as it creates a broken user experience.

Files Reviewed

  • docs/articles/new-expensify/billing-and-subscriptions/Add-a-payment-card-and-view-your-subscription.md -- Duplicate line removed and placeholder link replaced; grammar issue remains on the retained line.

Review based on governance rules in docs/HELP_AUTHORING_GUIDELINES.md, docs/HELPSITE_NAMING_CONVENTIONS.md, and docs/TEMPLATE.md.

@github-actions github-actions Bot changed the title Fix link for transferring billing ownership [No QA] Fix link for transferring billing ownership May 22, 2026
@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 6, 2026
@stephanieelliott
stephanieelliott requested a review from a team June 6, 2026 02:09
@melvin-bot

melvin-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @muttmuure

@melvin-bot
melvin-bot Bot requested review from muttmuure and removed request for a team June 6, 2026 02:09
@melvin-bot

melvin-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

@muttmuure Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

This comment has been minimized.

@OSBotify

OSBotify commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://095ad005.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott

Copy link
Copy Markdown
Contributor Author

Bump @muttmuure, can you review plz?

@muttmuure
muttmuure merged commit af9a59b into main Jun 9, 2026
14 checks passed
@muttmuure
muttmuure deleted the stephanieelliott-patch-1 branch June 9, 2026 07:50
@melvin-bot melvin-bot Bot added the Emergency label Jun 9, 2026
@melvin-bot

melvin-bot Bot commented Jun 9, 2026

Copy link
Copy Markdown

@muttmuure looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/muttmuure in version: 9.4.2-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/muttmuure in version: 9.4.4-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.4-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Emergency HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants