Update addCopilot copy#91463
Conversation
Change "Add a copilot to your account" to "Add a copilot" in both en.ts and es.ts translations. Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/it.ts b/src/languages/it.ts
index 1aff9e08..faa8e67d 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -9057,7 +9057,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
copilotDelegatedAccess: 'Copilot: Accesso delegato',
copilotDelegatedAccessDescription: 'Consenti agli altri membri di accedere al tuo account.',
learnMoreAboutDelegatedAccess: "Scopri di più sull'accesso delegato",
- addCopilot: 'Aggiungi copilota',
+ addCopilot: 'Aggiungi un copilota',
membersCanAccessYourAccount: 'Questi membri possono accedere al tuo account:',
youCanAccessTheseAccounts: 'Puoi accedere a questi account:',
role: ({role}: OptionalParam<DelegateRoleParams> = {}) => {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 930e16b2..b72cc2d0 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -9025,7 +9025,7 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
copilotDelegatedAccess: 'Copilot: Gedelegeerde toegang',
copilotDelegatedAccessDescription: 'Sta andere leden toe toegang te krijgen tot je account.',
learnMoreAboutDelegatedAccess: 'Meer informatie over gedelegeerde toegang',
- addCopilot: 'Copiloot toevoegen',
+ addCopilot: 'Co-piloot toevoegen',
membersCanAccessYourAccount: 'Deze leden hebben toegang tot je account:',
youCanAccessTheseAccounts: 'Je hebt toegang tot deze accounts:',
role: ({role}: OptionalParam<DelegateRoleParams> = {}) => {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index ae16eba7..3890f8a6 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -9011,7 +9011,7 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
copilotDelegatedAccess: 'Copilot: Dostęp delegowany',
copilotDelegatedAccessDescription: 'Zezwól innym członkom na dostęp do Twojego konta.',
learnMoreAboutDelegatedAccess: 'Dowiedz się więcej o dostępie delegowanym',
- addCopilot: 'Dodaj pilota',
+ addCopilot: 'Dodaj kopilota',
membersCanAccessYourAccount: 'Ci członkowie mają dostęp do Twojego konta:',
youCanAccessTheseAccounts: 'Masz dostęp do tych kont:',
role: ({role}: OptionalParam<DelegateRoleParams> = {}) => {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 9e33df2c..d1d52bc8 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -9017,7 +9017,7 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
copilotDelegatedAccess: 'Copilot: Acesso delegado',
copilotDelegatedAccessDescription: 'Permitir que outros membros acessem sua conta.',
learnMoreAboutDelegatedAccess: 'Saiba mais sobre acesso delegado',
- addCopilot: 'Adicionar copiloto',
+ addCopilot: 'Adicionar um copiloto',
membersCanAccessYourAccount: 'Esses membros podem acessar sua conta:',
youCanAccessTheseAccounts: 'Você pode acessar essas contas:',
role: ({role}: OptionalParam<DelegateRoleParams> = {}) => {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 0b93cab5..106b71ca 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -8788,7 +8788,7 @@ ${reportName}
copilotDelegatedAccess: 'Copilot:委托访问',
copilotDelegatedAccessDescription: '允许其他成员访问你的账户。',
learnMoreAboutDelegatedAccess: '了解更多关于委托访问的信息',
- addCopilot: '添加副驾',
+ addCopilot: '添加副驾驶',
membersCanAccessYourAccount: '这些成员可以访问你的账户:',
youCanAccessTheseAccounts: '您可以访问这些账户:',
role: ({role}: OptionalParam<DelegateRoleParams> = {}) => {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@MelvinBot please add the polyglot parrot translations above. |
|
The failing Re-running the failed check should resolve it. |
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
Applied the polyglot parrot translations for |
|
@jamesdeanexpensify Do we have a GH issue that we could link in the description? |
|
@pecanoro - I do not, just trimming copy here and there where it makes sense. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@pecanoro thank you! Am I able to merge? |
|
🚧 @pecanoro has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.83-0 🚀
Bundle Size Analysis (Sentry): |
|
The help site article Draft PR created: #91761 @jamesdeanexpensify, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
Update "Add Copilot" to "Add a copilot" to match the updated UI button text from Expensify#91463. Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.3.83-3 🚀
|
Explanation of Change
Update the
addCopilotcopy from "Add a copilot to your account" to the simpler "Add a copilot". Updated the Spanish translation accordingly.Fixed Issues
$
PROPOSAL:
Tests
Same as QA steps
Offline tests
N/A - copy-only change
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari