Bump Fullstory library to 1.70.1 by fabioh8010 · Pull Request #91413 · Expensify/App

fabioh8010 · 2026-05-22T10:44:47Z

Explanation of Change

Upgrade and align Fullstory libraries to latest versions between Standalone and HybridApp.

Fixed Issues

$ #91225
$ #91291
PROPOSAL:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13948

Tests

Simple test, we only want to check if the app is building with the latest bumps

Open the app.
Assert it loads correctly.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-05-27.at.13.26.54.mov

Screen.Recording.2026-05-27.at.13.27.52.mov

github-actions · 2026-05-22T10:44:57Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

fabioh8010 · 2026-05-22T10:45:47Z

Commit 448e234 is for testing and allows us to use our emails for FS recording, it will be reverted later.

codecov · 2026-05-22T10:55:37Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/libs/Fullstory/common.ts	`0.00% <ø> (ø)`
src/libs/Fullstory/index.ts	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

github-actions · 2026-05-22T11:09:45Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-05-22T12:04:08Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

…p-1.70.1

melvin-bot · 2026-05-27T13:21:55Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6e0cfefd20

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-05-27T13:24:14Z

-        return false;
-    }
-
    return true;


Restore the FullStory initialization gate

This unconditional return makes FS.shouldInitialize true for every environment and email domain, so both index.ts and index.native.ts will consent and identify users in staging/dev and for expensify.com accounts that were explicitly excluded before. The comments in the callers still state that FullStory is production-only, and the old predicate allowed only production or fullstory...@qa test accounts while excluding the partner domain, so this change starts recording sessions in contexts that should not be captured.

Useful? React with 👍 / 👎.

This is just for testing, will be removed later.

chatgpt-codex-connector · 2026-05-27T13:24:15Z

        new Promise((resolve) => {
            if (!isInitialized()) {
-                init({orgId: 'o-1WN56P-na1'}, resolve);
+                init({orgId: 'o-1WN56P-na1', debug: true}, resolve);


Do not enable FullStory debug mode for all web sessions

Passing debug: true here enables FullStory's verbose browser diagnostics whenever web FullStory starts, including production sessions once a normal user is identified. That leaks SDK internals into end-user consoles and adds avoidable production logging/noise; if this was only needed while validating the library bump, it should not be left on for every web session.

Useful? React with 👍 / 👎.

This is just for testing, will be removed later.

github-actions · 2026-05-27T13:49:01Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

Eskalifer1 · 2026-05-27T16:48:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

video_2026-05-27_19-47-10.mp4

Android: mWeb Chrome

video_2026-05-27_19-47-03.mp4

iOS: HybridApp

91413-ios-native.mov

iOS: mWeb Safari

91413-ios-web.mov

MacOS: Chrome / Safari

91413-web.mov

joekaufmanexpensify · 2026-05-27T21:22:29Z

No product review needed

Eskalifer1 · 2026-05-28T08:48:22Z

Regarding APP-8Z0, I don't know if it's just a coincidence, but I've noticed that the number of crashes has increased since May 7. It was in this deployment that this library was updated from 1.68.3 to 1.70.0.

Here's the PR

The first crash occurred on March 27. It seems that in this PR, the library was updated from 1.64.2 to 1.68.3, which was likely the cause of the crashes, so it appears that the problem lies somewhere within the library itself.

Also, APP-8PM experienced its first crashes after this update

Just my findings :)

Eskalifer1

I didn't encounter any issues. It seems that Fullstory is working, and I didn't notice any crashes during testing.

Let's revert the test changes

Eskalifer1 · 2026-05-28T20:31:56Z

Let's resolve conflicts and remove HOLD from title

cc: @fabioh8010

fabioh8010 · 2026-06-01T13:18:40Z

Regarding APP-8Z0, I don't know if it's just a coincidence, but I've noticed that the number of crashes has increased since May 7. It was in this deployment that this library was updated from 1.68.3 to 1.70.0.

Here's the PR

The first crash occurred on March 27. It seems that in this PR, the library was updated from 1.64.2 to 1.68.3, which was likely the cause of the crashes, so it appears that the problem lies somewhere within the library itself.

Also, APP-8PM experienced its first crashes after this update

Just my findings :)

@Eskalifer1 these reports are all connected to emitOnSessionStarted so I think #91435 will cover them as well.

fabioh8010 · 2026-06-01T13:20:07Z

Let's resolve conflicts and remove HOLD from title

cc: @fabioh8010

Done! I also decided to revert my bumps of @fullstory/browser, @fullstory/babel-plugin-annotate-react and @fullstory/babel-plugin-react-native. The same was done before in #92153 that was reverted due to Deploy Blockers.

Eskalifer1 · 2026-06-01T13:44:17Z

@Eskalifer1 these reports are all connected to emitOnSessionStarted so I think #91435 will cover them as well.

Yes, that's possible. The PR was deployed 4 days ago in version 9.3.88-2. It seems there haven't been any crashes since then:
https://expensify.sentry.io/issues/7380643580/events/25193cf84fc34d1690e03346bf16eb46/?project=4510228107427840&query=release%3Anew.expensify%409.3.88-2%20release%3Anew.expensify%409.3.89-7&referrer=previous-event&statsPeriod=7d

https://expensify.sentry.io/issues/7373312361/?project=4510228107427840&query=release%3Anew.expensify%409.3.88-2%20release%3Anew.expensify%409.3.89-7&statsPeriod=7d

Does it make sense to bump the version numbers if the bug can already be fixed, or should we put these two PRs on hold and monitor the situation for 1–2 weeks?

cc: @fabioh8010 @mountiny

mountiny · 2026-06-01T16:36:34Z

I think we can still proceed with the bump, is this all good to merge? @fabioh8010 @Eskalifer1

Eskalifer1 · 2026-06-02T17:00:51Z

I think yes, let's hear @fabioh8010 and resolve conflicts

fabioh8010 · 2026-06-02T17:03:22Z

I think we should still proceed with the PR as we are fixing the mismatch with standalone and hybrid versions, and there are library bug fixes in their release notes too

fabioh8010 · 2026-06-02T17:03:39Z

There are conflicts again, solving

fabioh8010 · 2026-06-02T17:28:13Z

@mountiny @Eskalifer1 updated both PRs with main again

fabioh8010 · 2026-06-03T15:59:57Z

Updates:

Updated Bump Fullstory library to 1.70.1 #91413 and https://github.com/Expensify/Mobile-Expensify/pull/13948 with main again, all yours @mountiny
I will be OOO on Thursday and Friday and will return on Jun 8th.

github-actions · 2026-06-03T20:33:02Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-06-03T20:49:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91413.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-5ffa4914c09-4b459aa-d337159e09d145055a574da3e5b38a6f8acc87b2/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-5ffa491-4b459aa-62fbcd335aef7af587b5cce39bfd5eadd7ceee3c/index.html

Web 🕸️
https://91413.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-04T07:56:37Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.99-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-06-05T17:50:11Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.99-9 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bump Fullstory libraries

6b6c9bb

melvin-bot Bot assigned fabioh8010 May 22, 2026

TEST: Disable FS restrictions

448e234

This comment has been minimized.

Sign in to view

fabioh8010 added 3 commits May 27, 2026 09:31

Merge branch 'main' into feature/fullstory-bump-1.70.1

c5b3aed

Update Podfile.lock

333cc3c

Merge remote-tracking branch 'origin/main' into feature/fullstory-bum…

6e0cfef

…p-1.70.1

fabioh8010 changed the title ~~Bump Fullstory libraries~~ [HOLD https://github.com/Expensify/App/pull/91435] Bump Fullstory libraries May 27, 2026

fabioh8010 marked this pull request as ready for review May 27, 2026 13:21

fabioh8010 requested review from a team as code owners May 27, 2026 13:21

melvin-bot Bot requested review from Eskalifer1 and joekaufmanexpensify and removed request for a team and Eskalifer1 May 27, 2026 13:21

melvin-bot Bot removed the request for review from a team May 27, 2026 13:21

fabioh8010 mentioned this pull request May 27, 2026

[Due for payment 2026-06-12] [$250] [Sentry: APP-8Z0 / APP-8PM] HybridApp iOS EXC_BAD_ACCESS in FullStory native onSessionStarted #91291

Closed

chatgpt-codex-connector Bot reviewed May 27, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

joekaufmanexpensify removed their request for review May 27, 2026 21:22

Eskalifer1 approved these changes May 28, 2026

View reviewed changes

melvin-bot Bot requested a review from mountiny May 28, 2026 08:57

fabioh8010 added 2 commits June 1, 2026 13:58

Merge branch 'main' into feature/fullstory-bump-1.70.1

87966ec

Update Podfile.lock

94bfab3

fabioh8010 changed the title ~~[HOLD https://github.com/Expensify/App/pull/91435] Bump Fullstory libraries~~ Bump Fullstory library to 1.70.1 Jun 1, 2026

Revert test changes

3c0702c

Merge branch 'main' into feature/fullstory-bump-1.70.1

938f7f1

Merge branch 'main' into feature/fullstory-bump-1.70.1

0718a20

mountiny approved these changes Jun 3, 2026

View reviewed changes

mountiny merged commit 5ffa491 into Expensify:main Jun 3, 2026
22 checks passed

OSBotify mentioned this pull request Jun 4, 2026

Deploy Checklist: New Expensify 2026-06-04 #92626

Closed

100 tasks

melvin-bot Bot mentioned this pull request Jun 5, 2026

[Due for payment 2026-06-12] [Due for payment 2026-06-04] [$250] [Sentry: APP-8KQ] iOS Fatal C++ Exception: St14overflow_error #91225

Closed

Uh oh!

Conversation

fabioh8010 commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

fabioh8010 commented May 22, 2026

Uh oh!

codecov Bot commented May 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions Bot commented May 22, 2026

Uh oh!

This comment has been minimized.

github-actions Bot commented May 22, 2026

Uh oh!

This comment has been minimized.

melvin-bot Bot commented May 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Choose a reason for hiding this comment

Uh oh!

fabioh8010 May 27, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot May 27, 2026

Choose a reason for hiding this comment

Uh oh!

fabioh8010 May 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 27, 2026

Uh oh!

This comment has been minimized.

Eskalifer1 commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

joekaufmanexpensify commented May 27, 2026

Uh oh!

Eskalifer1 commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eskalifer1 left a comment

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 commented May 28, 2026

Uh oh!

fabioh8010 commented Jun 1, 2026

Uh oh!

fabioh8010 commented Jun 1, 2026

Uh oh!

Eskalifer1 commented Jun 1, 2026

Uh oh!

mountiny commented Jun 1, 2026

Uh oh!

Eskalifer1 commented Jun 2, 2026

Uh oh!

fabioh8010 commented Jun 2, 2026

Uh oh!

fabioh8010 commented Jun 2, 2026

Uh oh!

fabioh8010 commented Jun 2, 2026

Uh oh!

fabioh8010 commented Jun 3, 2026

Uh oh!

fabioh8010 commented May 22, 2026 •

edited

Loading

codecov Bot commented May 22, 2026 •

edited by github-actions Bot

Loading

Eskalifer1 commented May 27, 2026 •

edited

Loading

Eskalifer1 commented May 28, 2026 •

edited

Loading