fix: show contact names instead of phone numbers in imported contact lists by aswin-s · Pull Request #91395 · Expensify/App

aswin-s · 2026-05-22T08:00:51Z

Explanation of Change

In src/libs/PersonalDetailOptionsListUtils/index.ts, createOption calls getDisplayNameForParticipant which resolves the display name by looking up accountID in the global Onyx allPersonalDetails store. For device-imported contacts, the accountID is optimistically generated and does not exist in Onyx, so the lookup fails and falls back to displaying the raw phone number — even though displayName/firstName/lastName are already present on the personalDetail object passed in.

Fix: pass {[personalDetail.accountID]: personalDetail} as personalDetailsData to getDisplayNameForParticipant. This lets the existing resolver find the contact's name from the local object rather than failing the Onyx lookup. For real Onyx-backed personal details, the injected object is identical to the Onyx entry — no behavior change for existing callers.

Fixed Issues

$ #91150
PROPOSAL: #91150 (comment)

Tests

On iOS or Android, open the create-expense flow and grant contacts permission when prompted.
Observe the imported contacts list.
Verify each contact row displays the contact's name (e.g. "John Smith") with the phone number as secondary text — not just the phone number.
Create an expense by selecting a contact and verify the recipient name appears correctly throughout the flow.

Verify that no errors appear in the JS console

Offline tests

Not applicable — contact import is a device-local operation that does not require network access.

QA Steps

On iOS or Android staging build, open the create-expense flow and grant contacts permission.
Verify the imported contacts list shows contact names (not raw phone numbers).
Select a contact and complete the expense flow — verify the name persists correctly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

Contact import is available only on native platforms

iOS: Native

Simulator.Screen.Recording.-.iPhone.17.Pro.Max.-.2026-05-26.at.23.17.10.mp4

iOS: mWeb Safari

Contact import is available only on native platforms

MacOS: Chrome / Safari

Contact import is available only on native platforms

… list

codecov · 2026-05-22T08:14:19Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/OptionsListUtils/index.ts	`85.21% <100.00%> (+0.05%)`	⬆️
...es/iou/request/step/IOURequestStepConfirmation.tsx	`64.44% <100.00%> (ø)`
src/libs/PersonalDetailOptionsListUtils/index.ts	`70.64% <66.66%> (-0.21%)`	⬇️
... and 13 files with indirect coverage changes

…timistic IDs

…cons

Phone contacts from device address book were showing only their phone numbers in the IOU participants list. getParticipantsOption discarded participant.text (device contact name) for unknown accountIDs, and IOURequestStepConfirmation routed phone contacts through getReportOption which doesn't preserve the contact name. Prefer participant.text when the personal detail has no login, and route participants without a reportID through getParticipantsOption.

Replace nested ternary with an if/else chain. Removes two unjustified eslint-disable comments and adds inline justification on the remaining one (empty string from device contacts must fall through to the formatted phone number).

melvin-bot · 2026-05-26T17:54:35Z

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ZhenjaHorbach · 2026-06-01T08:53:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

2026-06-04.11.44.43.mov

Android: mWeb Chrome

NA

iOS: HybridApp

2026-06-04.11.44.43.mov

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

NA

JmillsExpensify

LGTM

JmillsExpensify

LGTM

# Conflicts: # src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Pass detail (rather than undefined) to getDisplayNameOrDefault in the no-login branch so users whose login is hidden by the backend keep their displayName. Phone-contact stubs still resolve to the formatted phone number because the stub has no displayName.

ZhenjaHorbach · 2026-06-09T11:48:31Z

@aswin-s
Can you fix conflicts, please?

aswin-s · 2026-06-09T12:58:05Z

@ZhenjaHorbach Resolved conflicts with main

…tisfy lint seatbelt

aswin-s · 2026-06-19T11:26:22Z

@ZhenjaHorbach Could you take another look at this?

ZhenjaHorbach · 2026-06-19T16:16:59Z

Sorry for delay
Check today or tomorrow!

MonilBhavsar · 2026-06-25T03:42:50Z

@ZhenjaHorbach PR reviewer checklist is failing

ZhenjaHorbach · 2026-06-25T06:10:42Z

Strange
Everything is good with my checklist

github-actions · 2026-06-25T11:48:48Z

🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-06-25T11:51:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-06-25T11:54:24Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #91395.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-3c4d0c6d3a2-f38ade5-8f72bb680c8b4eeae894b05d64febbaf104cc5ff/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-3c4d0c6-f38ade5-d1e6964544b1a9b8eeab991a223fcef669f29e7e/index.html

Web 🕸️
https://91395.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-06-25T21:50:30Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.4.20-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-06-25T21:53:55Z

🤖 Help site review: no documentation changes required.

This PR is a UI display bug fix — it makes imported device contacts render their name (e.g. "John Smith") instead of the raw phone number in the create-expense participant list, by resolving the display name from the local personalDetail object instead of failing the Onyx lookup. The changes are confined to OptionsListUtils, PersonalDetailOptionsListUtils, and IOURequestStepConfirmation.

I reviewed App/docs/articles and found no help article that documents:

Importing/selecting device (phone) contacts when creating an expense, or
How participant names vs. phone numbers are displayed in that flow.

Because no published help content describes this behavior, there is nothing to correct or add — the fix restores the intended display without changing any documented feature, setting, label, or workflow. So I did not create a draft docs PR.

If you believe a specific existing article does cover this flow and should be updated, reply with @MelvinBot and point me to it and I'll take another pass.

mitarachim · 2026-06-25T23:57:04Z

@aswin-s This PR is failing in step 4 because of a regression issue #94644

The issue is reproducible in: Android

Bug7191466_1782427309313.Screen_Recording_20260626_013105_Expensify.mp4

aswin-s · 2026-06-26T01:37:47Z

@mitarachim This PR only handles the display of contact names in the create expense flow. Displaying name in the report after expense creation is a separate issue.

OSBotify · 2026-06-26T19:22:24Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.4.20-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned aswin-s May 22, 2026

aswin-s changed the title ~~fix: show contact names instead of phone numbers in imported contacts…~~ fix: show contact names instead of phone numbers in imported contact lists May 22, 2026

fix: show contact names instead of phone numbers in imported contacts…

e463a4e

… list

aswin-s force-pushed the fix/issue-91150 branch from 1edc3ef to e463a4e Compare May 22, 2026 08:04

aswin-s added 5 commits May 22, 2026 13:58

test: add unit tests for createOption display name resolution with op…

ec142c0

…timistic IDs

fix(test): use optional chaining to satisfy TS strict null check on i…

f5924c0

…cons

Merge remote-tracking branch 'origin/main' into fix/issue-91150

51acc6d

aswin-s marked this pull request as ready for review May 26, 2026 17:54

aswin-s requested review from a team as code owners May 26, 2026 17:54

melvin-bot Bot requested review from JmillsExpensify and ZhenjaHorbach and removed request for a team May 26, 2026 17:54

melvin-bot Bot removed the request for review from a team May 26, 2026 17:54

JmillsExpensify previously approved these changes Jun 3, 2026

View reviewed changes

ZhenjaHorbach reviewed Jun 3, 2026

View reviewed changes

Comment thread src/libs/OptionsListUtils/index.ts

test: add getParticipantsOption unit tests

12a7e2a

aswin-s dismissed JmillsExpensify’s stale review via 12a7e2a June 3, 2026 13:16

aswin-s requested a review from ZhenjaHorbach June 3, 2026 13:19

ZhenjaHorbach reviewed Jun 4, 2026

View reviewed changes

Comment thread src/libs/OptionsListUtils/index.ts Outdated

JmillsExpensify previously approved these changes Jun 5, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into fix/issue-91150

d908ebb

# Conflicts: # src/pages/iou/request/step/IOURequestStepConfirmation.tsx

aswin-s dismissed JmillsExpensify’s stale review via d908ebb June 5, 2026 13:12

aswin-s force-pushed the fix/issue-91150 branch from 7e3a4e3 to d908ebb Compare June 5, 2026 13:12

aswin-s requested a review from ZhenjaHorbach June 5, 2026 13:22

Merge remote-tracking branch 'origin/main' into fix/issue-91150

bab2307

aswin-s added 2 commits June 9, 2026 19:42

fix(test): replace as Participant casts with typed declarations to sa…

25dc36b

…tisfy lint seatbelt

Merge remote-tracking branch 'origin/main' into fix/issue-91150

b754fc5

ZhenjaHorbach approved these changes Jun 24, 2026

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar June 24, 2026 20:04

MonilBhavsar approved these changes Jun 25, 2026

View reviewed changes

MonilBhavsar merged commit 3c4d0c6 into Expensify:main Jun 25, 2026
33 of 35 checks passed

OSBotify mentioned this pull request Jun 25, 2026

Deploy Checklist: New Expensify 2026-06-25 #94631

Closed

60 tasks

applause-bot Bot mentioned this pull request Jun 25, 2026

[Due for payment 2026-07-23] [$250] Chat - Imported contact list name is not shown in the expense #94644

Open

7 tasks

melvin-bot Bot mentioned this pull request Jun 26, 2026

[Due for payment 2026-07-03] [$250] Import Contacts - Contact names not displayed in contact list #91150

Closed

7 tasks

Uh oh!

Conversation

aswin-s commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented May 22, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented May 26, 2026

Uh oh!

ZhenjaHorbach commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Jun 9, 2026

Uh oh!

aswin-s commented Jun 9, 2026

Uh oh!

aswin-s commented Jun 19, 2026

Uh oh!

ZhenjaHorbach commented Jun 19, 2026

Uh oh!

MonilBhavsar commented Jun 25, 2026

Uh oh!

ZhenjaHorbach commented Jun 25, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

OSBotify commented Jun 25, 2026

Uh oh!

github-actions Bot commented Jun 25, 2026

Uh oh!

OSBotify commented Jun 25, 2026

Uh oh!

MelvinBot commented Jun 25, 2026

Uh oh!

mitarachim commented Jun 25, 2026

Uh oh!

aswin-s commented Jun 26, 2026

Uh oh!

OSBotify commented Jun 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

aswin-s commented May 22, 2026 •

edited

Loading

codecov Bot commented May 22, 2026 •

edited by github-actions Bot

Loading

ZhenjaHorbach commented Jun 1, 2026 •

edited

Loading